Giter VIP home page Giter VIP logo

Comments (5)

JohnRDOrazio avatar JohnRDOrazio commented on July 17, 2024

I'm pretty sure that's what @engrnand was trying to convey when he opened issue #5554...

from phpunit.

JohnRDOrazio avatar JohnRDOrazio commented on July 17, 2024

as you can see in the source code, the $name parameter is required, no default value is provided:

public function __construct(string $name)

This should either be:

public function __construct(string $name = '') 

or documentation should be updated to reflect the necessity of this parameter.

I must add, that I'm not using PHPUnit on the command line, I am using it together with ratchetphp to send the results of tests over a websocket to a web UI.

from phpunit.

sebastianbergmann avatar sebastianbergmann commented on July 17, 2024

The necessity of this parameter is documented through the fact that it is not optional.

from phpunit.

JohnRDOrazio avatar JohnRDOrazio commented on July 17, 2024

I'm really sorry @sebastianbergmann , but that seems to be a bit of an attitude there. If there is some use to the $name parameter (and I'm sure there is), please document the use of it. Otherwise if there is no real use, could you explain for what reason this is considered legal:

class MyTest extends TestCase {
  public function test() {
    //perform a test
  }
}
$mytest = new MyTest('');

but this isn't:

class MyTest extends TestCase {
  public function test() {
    //perform a test
  }
}
$mytest = new MyTest;

Is there any real difference? Other than to make life more complicated?

from phpunit.

sebastianbergmann avatar sebastianbergmann commented on July 17, 2024

TestCase objects are only supposed to be created and used by PHPUnit itself, not by third-party extensions for/wrappers around PHPUnit.

from phpunit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.