fake server does not respond to JSONP XHR about sinon HOT 9 CLOSED

I believe this has to do with the type of the request. Jsonp requests are loaded with script injection, right? So I suppose they wouldn't be in need of a fake XHR object.

from sinon.

To fake JSON-P, you have to stub the jQuery function you're calling. In your example, jQuery.get.

from sinon.

Oh I see. So you're saying, rather than using faker servers, do something like:

url = "http://fake.com/foo/bar"
arg = '[{ id: 12, comment: "Hey there" }]'
stub = sinon.stub(jQuery, "ajax").yieldsTo("success",arg)

# spy 
callback = sinon.spy()

# remote call
$.ajax(
    url: url
    success: callback
    dataType: "jsonp"    
)

# assertions 
assert(callback.calledWith(arg)).isTrue("Search run via ajax on a remote resource")                     

# clean up test stubs
stub.restore()

The part I don't understand is why we need to use yieldsTo() as opposed to returns()? What makes yieldsTo different?

from sinon.

The ajax method doesn't return anything. yieldsTo causes Sinon to automatically invoke the success callback, like jQuery would, in the case of a successful request.

from sinon.

Awesome. Thanks!

from sinon.

Just one more curious note. I noticed that even when I run the request with "json," the success callback was still not being run. I could use the data request type "html" to make it work, but now I'm curious why the fake server does not return success state when the expected data type is "json."

server = sinon.fakeServer.create()
url = "/some/article/comments.json"
# set up server
server.respondWith("GET", url, [200, { "Content-Type": "application/json" }, '[{ id: 12, name: "Hey there" }]'])

# spy 
callback = sinon.spy()

# remote call
$.get(url, {}, ->
                        console.log "hi"
                        callback.call() 
        , "json")
# respond from fake server
server.respond()

# assertions
assert(callback.called).isTrue("Search run via ajax on fake server")

# clean up
server.restore()

from sinon.

Hook up an error handler with jQuery and you will see why. jQuery tries to parse JSON as, well, JSON, and your response is not valid (need to quote the keys). Better to pass JSON.stringify({ ... }) to respondWith

from sinon.

Aha! I doff my hat to you, sir! :-)

from sinon.

thank you very much for this! wasted a lot of time trying to debug this!

from sinon.