Giter VIP home page Giter VIP logo

Comments (5)

JanCervenyy avatar JanCervenyy commented on September 22, 2024

The implementation needs to be slightly modified according to the initial description (https://czechglobe-doab.slack.com/archives/CLN16B9CH/p1571978282001000), i.e. I would do it following way:

OD = measure_od()
while OD > min_OD:
     setAux2(1)             # this turns on the pump (works only if the pump goes from 0 to 1)
     time.sleep(20)        # sleep 20 seconds, should be enough to accomplish steps 1. and 2.
     setAux2(0)        # reset the pump to zero state that is necessary for success of next set of the pump
     time.sleep(20)
     OD = measure_od()

from pbrcontrol.

xtrojak avatar xtrojak commented on September 22, 2024

It was just a testing close, the issue has not been resolved by implementation yet.

from pbrcontrol.

DanDayne avatar DanDayne commented on September 22, 2024

I tried to address this in this commit. I expect bugs to occur, but I do not have the resources to test it at the moment. @xtrojak could possibly try it out?

Basically, I added a pump manager which manages the pump state for ePBRs in its own thread - log messages should be consistent with other device classes.

from pbrcontrol.

xtrojak avatar xtrojak commented on September 22, 2024

The pump manager is working, but will be possibly modified to more general usage.

from pbrcontrol.

DanDayne avatar DanDayne commented on September 22, 2024

TODO: move pump manager to Phenometrics\PBR

from pbrcontrol.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.