snaiel / godot4thirdpersoncombatprototype Goto Github PK

f602211

f602211

this codebase is just spaghetti in an unconvincing composition mask

What's bad?

• why does a crosshair need access to a backstab and dizzy component? IT SHOULD JUST BE A CROSSHAIR with a toggle specifying if it should be shown or not!
• when making the spellcaster enemy, why is the enemy script so tightly coupled that I need an attack component? And so many other dependencies.
• Importing animation libraries requires certain animations scripts. For example, importing combat_animations_1 requires HitAndDeathAnimations, DizzyVictimAnimations, DizzyFinisherAnimations, BlockAnimations, ParryAnimations, and probs more. What if i only need the hit, death, and dizzy victim animations? Not sure how to deal with this hmmm.

TODO

• decouple crosshair
• clean up enemy script
• create component managers?
• actually utilise composition
• actually utilise the observer pattern, signals

man i have no idea what im doing. I just spent hours removing everything from the enemy script, then spent hours putting it back bruh. Also the swordsman's movement is broken now. like how does that even happen.

OKAY here is my new plan. turns out a base enemy requires a lot of components to get started. But i realised that attack, block, parry, spell components are the ones that need to be able to swapped in or out. So i just need to make it so that doing this swapping is done nicely in a modular way. The base enemy shouldn't have declared references to these components.

I might just be going crazy now but handling weapon impact in the enemies should be more modular right? If those components shouldn't be referenced, ill need new handlers for when an enemy gets hit, blocks the player or parries the player. So essentially make the _on_hitbox_weapon_hit method modular. So nodes for backstab, dizzy finisher, hit, block, parry? Maybe doing it this way can allow for new/other types of behaviour when handling an incoming weapon.

I also feel the same for the character animations script. There really shouldn't be much exported variables. I also think setting and getting parameters in the animation tree should be done similar to how beehave handles the blackboard. Basically use a custom getter and setter for flexibility.

Also probably should be done for function calls in the animation tracks. Instead of accessing the animations script directly, just send a message to the parent animations script which will handle all the dispatching. OH MY GOD THIS IS THE MEDIATOR PATTERN. Edit: this is actually the command pattern. Bro all these design patterns are like the same thing lmao. no but i get it. i think...

• decouple crosshair
• dont reference ability components
• weapon impact handlers
• clean up and decouple character animations
• custom setter and getter for animation tree
• make character animations the mediator handle commands from animation tracks for the scripts

lerp is bad

it feels sluggish/sloppy

probably shouldn't use lerp for everything

Hello. I'm not quite sure if this is a problem on my end but I tried to clone this project to play around with and learn but it seems that there are a few broken dependencies in a few of the entities and animation scenes.

If you press E at the checkpoint where the player death animation is playing, the player will respawn and be in death mode meaning you cannot move

from f602211

f602211

Steps to replicate:

• Hold W
• Wait a bit to start walking then left click
• Let go of everything

To Reproduce

1. make enemy dizzy from damage
2. walk away

Desired Behaviour

• player should be free to move around/ do what they please
• not locked into a dizzy finisher animation/state
• show crosshair when near
• perform dizzy finisher if player attacks while crosshair is showing
• attack normally when away/ crosshair not showing

f602211

• animations
• initial scene setup
• figure out how attacking works for this new non melee dude
• #43

• particles?
• enemies?
• occlusion culling?

I think instead of using the camera's rotation (which is lerped, lagging behind, causing the spiral), use player direction to enemy?

This occurs because you do not have Blender imports configured with Godot. See the documentation on Blender imports in Godot here: https://docs.godotengine.org/en/stable/tutorials/assets_pipeline/importing_scenes.html#importing-blend-files-directly-within-godot

In order to load the project, you must install Blender https://www.blender.org/ as this is what's used for the 3d models. The models are meant to be automatically loaded in using Blender within Godot but this needs to be configured.

After installing Blender, locate the install directory. For example, here is the location for my Blender on Linux:

Blender locations for Linux, Windows, Mac are documented here: https://docs.blender.org/manual/en/latest/advanced/blender_directory_layout.html

Once you have identified your blender install path, go to the Editor option in the top left menu in Godot. Then select Editor Settings

Then go to FileSystem > Import and paste your Blender path into Blender 3 Path.

Afterwards, just reload the project and it should work now.

#5

#10 thx for initial implementation

• make instability reach maximum, then stun player on next hit.
• sfx
• player kneel?
• instability meter animation then reset
• camera shake? (need to see where else to implement, not too much tho)
• fix getting hit sound straight after getting stunned