Freeze pause doesn't stop on last fade-in frame of screens with short fade-ins about overlunky HOT 5 CLOSED

That does sound like a better check for variable fade lengths, I don't know what I was thinking. Also sounds more and more like you should just make this stuff exactly like you want in your script and maybe I'll port it back to OL, or you could just make a PR to fix OL along with making your script... I still find myself not interested to open vscode this whole week anyway.

from overlunky.

If you're taking a break from working on this stuff, then that's fine. I'm pretty sure I can fix this particular issue myself in OL.

Regarding implementing my own pause system in TASW, that was what I originally wanted to do, but I ran into some gross issues with the hotkey system. It's possible that I'm not using the hotkey system correctly, so I haven't reported anything for those issues. In the meantime, I thought it might be easier if I keep using OL for now and migrate users from fade pauses to game loop freeze pauses. I'm willing to release a TASW version where the pauses are a little hacky since this is still way better than the fade pause limitations that exist in the live version.

Independent TASW pausing is still on my backlog, and I'll give some thought to how I could port my own pause system back into OL.

from overlunky.

I'm working on a PR to fix this issue, as well as rename the fade variables. What cases was this particular check meant to catch?

from overlunky.

I think there was a screen that fades without setting loading. Maybe out of character selection?

from overlunky.

I see it flicker a fade_value of 1 for a couple frames when it loads the character selection. I didn't check every single screen and I'm not really confident about whether that check is unimportant, so I'm just going to revert that particular change in my PR.

from overlunky.