Comments (13)
AnandChowdhary
commented on June 3, 2024
Seems to me that it's failing on this line: https://github.com/squalrus/merge-bot/blob/master/lib/pull.js#L7
When payload.pull_request is undefined, this.ref = heads/${payload.pull_request.head.ref}; throws an error, but that seems weird since other lines above don't throw this...
from merge-bot.
squalrus
commented on June 3, 2024
Thank you for reporting! I will look into the issue this evening and let you know what I find.
from merge-bot.
squalrus
commented on June 3, 2024
@AnandChowdhary I am curious if it (1) has anything to do with opening pull requests between forks, or (2) that you are on an older version of merge-bot (latest is v0.4.0).
I opened a PR to test, but I may need some help triggering the bot: elninotech/uppload#95
from merge-bot.
squalrus
commented on June 3, 2024
@AnandChowdhary I updated merge-bot to v0.4.1 to include the logging needed to debug your issue. I updated my PR into your repo to include the latest version.
from merge-bot.
AnandChowdhary
commented on June 3, 2024
Thank you, @squalrus!
I've merged your PR with the new version, and am now testing a PR. I'm making a new PR to see if it's triggered now.
from merge-bot.
AnandChowdhary
commented on June 3, 2024
The logs are here from that merge: https://github.com/elninotech/uppload/runs/472090462?check_suite_focus=true
payload: {
"avatar_url": "https://avatars2.githubusercontent.com/oa/1508?v=4",
"branches": [
{
"commit": {
"sha": "a97a890bd526ba0b2cb0c1a3f4f3d7864d64d054",
"url": "https://api.github.com/repos/elninotech/uppload/commits/a97a890bd526ba0b2cb0c1a3f4f3d7864d64d054"
},
"name": "master",
"protected": false
}
],
"commit": {
"author": {
"avatar_url": "https://avatars3.githubusercontent.com/u/2841780?v=4",
"events_url": "https://api.github.com/users/AnandChowdhary/events{/privacy}",
"followers_url": "https://api.github.com/users/AnandChowdhary/followers",
"following_url": "https://api.github.com/users/AnandChowdhary/following{/other_user}",
"gists_url": "https://api.github.com/users/AnandChowdhary/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/AnandChowdhary",
"id": 2841780,
"login": "AnandChowdhary",
"node_id": "MDQ6VXNlcjI4NDE3ODA=",
"organizations_url": "https://api.github.com/users/AnandChowdhary/orgs",
"received_events_url": "https://api.github.com/users/AnandChowdhary/received_events",
"repos_url": "https://api.github.com/users/AnandChowdhary/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/AnandChowdhary/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/AnandChowdhary/subscriptions",
"type": "User",
"url": "https://api.github.com/users/AnandChowdhary"
},
"comments_url": "https://api.github.com/repos/elninotech/uppload/commits/a97a890bd526ba0b2cb0c1a3f4f3d7864d64d054/comments",
"commit": {
"author": {
"date": "2020-02-27T10:17:48Z",
"email": "[email protected]",
"name": "Anand Chowdhary"
},
"comment_count": 0,
"committer": {
"date": "2020-02-27T10:17:48Z",
"email": "[email protected]",
"name": "GitHub"
},
"message": "Merge pull request #95 from squalrus/master\n\nUpdate merge-bot to v0.4.1",
"tree": {
"sha": "12618237f38c2651b13421cead1fd5597587ba4d",
"url": "https://api.github.com/repos/elninotech/uppload/git/trees/12618237f38c2651b13421cead1fd5597587ba4d"
},
"url": "https://api.github.com/repos/elninotech/uppload/git/commits/a97a890bd526ba0b2cb0c1a3f4f3d7864d64d054",
"verification": {
"payload": "tree 12618237f38c2651b13421cead1fd5597587ba4d\nparent 86f7659f6a425dca376108cd85e9d22809157b41\nparent d5d6def5ea57f46ed4be53cdb535410cf038b05b\nauthor Anand Chowdhary <[email protected]> 1582798668 +0100\ncommitter GitHub <[email protected]> 1582798668 +0100\n\nMerge pull request #95 from squalrus/master\n\nUpdate merge-bot to v0.4.1",
"reason": "valid",
"signature": "-----BEGIN PGP SIGNATURE-----\n\nwsBcBAABCAAQBQJeV5dMCRBK7hj4Ov3rIwAAdHIIALA3K1kyut1EBBRXfpxYLuLZ\nIPuqWB3/K4hgjSGnuYNueLiEl5RZvkFLk45zapu9LBYOI+5rWy9KyQCrXrbtHU6x\nzWTi1dVZoiYYQYTPxS6ynhRKLNOonLFaVsJG/KN0xE5/O3Gxw7fi5r1hGAocro0L\n2hs3Mz8J1WOzXVGK2G9Gq1EeRLcvw/KgGyqgpWwkt8RCLP1djddJzOsSWWn6nWCx\n76wACqBw/TxrOwAFaEazniuAYNoi8muwQD8EGY4q9/7CuDDKgKYxP9ZfhBmOQJ0q\njZLKEOguz7/oPnjefMGF2ptDYml1XVLu8wKZaKR5U/amaNnXRI8eY0M/Z7AINZE=\n=QnWb\n-----END PGP SIGNATURE-----\n",
"verified": true
}
},
"committer": {
"avatar_url": "https://avatars3.githubusercontent.com/u/19864447?v=4",
"events_url": "https://api.github.com/users/web-flow/events{/privacy}",
"followers_url": "https://api.github.com/users/web-flow/followers",
"following_url": "https://api.github.com/users/web-flow/following{/other_user}",
"gists_url": "https://api.github.com/users/web-flow/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/web-flow",
"id": 19864447,
"login": "web-flow",
"node_id": "MDQ6VXNlcjE5ODY0NDQ3",
"organizations_url": "https://api.github.com/users/web-flow/orgs",
"received_events_url": "https://api.github.com/users/web-flow/received_events",
"repos_url": "https://api.github.com/users/web-flow/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/web-flow/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/web-flow/subscriptions",
"type": "User",
"url": "https://api.github.com/users/web-flow"
},
"html_url": "https://github.com/elninotech/uppload/commit/a97a890bd526ba0b2cb0c1a3f4f3d7864d64d054",
"node_id": "MDY6Q29tbWl0MTMwMjI3NDQyOmE5N2E4OTBiZDUyNmJhMGIyY2IwYzFhM2Y0ZjNkNzg2NGQ2NGQwNTQ=",
"parents": [
{
"html_url": "https://github.com/elninotech/uppload/commit/86f7659f6a425dca376108cd85e9d22809157b41",
"sha": "86f7659f6a425dca376108cd85e9d22809157b41",
"url": "https://api.github.com/repos/elninotech/uppload/commits/86f7659f6a425dca376108cd85e9d22809157b41"
},
{
"html_url": "https://github.com/elninotech/uppload/commit/d5d6def5ea57f46ed4be53cdb535410cf038b05b",
"sha": "d5d6def5ea57f46ed4be53cdb535410cf038b05b",
"url": "https://api.github.com/repos/elninotech/uppload/commits/d5d6def5ea57f46ed4be53cdb535410cf038b05b"
}
],
"sha": "a97a890bd526ba0b2cb0c1a3f4f3d7864d64d054",
"url": "https://api.github.com/repos/elninotech/uppload/commits/a97a890bd526ba0b2cb0c1a3f4f3d7864d64d054"
},
"context": "continuous-integration/travis-ci/push",
"created_at": "2020-02-27T10:19:43+00:00",
"description": "The Travis CI build passed",
"id": 8941919094,
"name": "elninotech/uppload",
"organization": {
"avatar_url": "https://avatars3.githubusercontent.com/u/2952546?v=4",
"description": "",
"events_url": "https://api.github.com/orgs/elninotech/events",
"hooks_url": "https://api.github.com/orgs/elninotech/hooks",
"id": 2952546,
"issues_url": "https://api.github.com/orgs/elninotech/issues",
"login": "elninotech",
"members_url": "https://api.github.com/orgs/elninotech/members{/member}",
"node_id": "MDEyOk9yZ2FuaXphdGlvbjI5NTI1NDY=",
"public_members_url": "https://api.github.com/orgs/elninotech/public_members{/member}",
"repos_url": "https://api.github.com/orgs/elninotech/repos",
"url": "https://api.github.com/orgs/elninotech"
},
"repository": {
"archive_url": "https://api.github.com/repos/elninotech/uppload/{archive_format}{/ref}",
"archived": false,
"assignees_url": "https://api.github.com/repos/elninotech/uppload/assignees{/user}",
"blobs_url": "https://api.github.com/repos/elninotech/uppload/git/blobs{/sha}",
"branches_url": "https://api.github.com/repos/elninotech/uppload/branches{/branch}",
"clone_url": "https://github.com/elninotech/uppload.git",
"collaborators_url": "https://api.github.com/repos/elninotech/uppload/collaborators{/collaborator}",
"comments_url": "https://api.github.com/repos/elninotech/uppload/comments{/number}",
"commits_url": "https://api.github.com/repos/elninotech/uppload/commits{/sha}",
"compare_url": "https://api.github.com/repos/elninotech/uppload/compare/{base}...{head}",
"contents_url": "https://api.github.com/repos/elninotech/uppload/contents/{+path}",
"contributors_url": "https://api.github.com/repos/elninotech/uppload/contributors",
"created_at": "2018-04-19T14:23:20Z",
"default_branch": "master",
"deployments_url": "https://api.github.com/repos/elninotech/uppload/deployments",
"description": "📁 Uppload is a better JavaScript image uploader with 30+ plugins",
"disabled": false,
"downloads_url": "https://api.github.com/repos/elninotech/uppload/downloads",
"events_url": "https://api.github.com/repos/elninotech/uppload/events",
"fork": false,
"forks": 53,
"forks_count": 53,
"forks_url": "https://api.github.com/repos/elninotech/uppload/forks",
"full_name": "elninotech/uppload",
"git_commits_url": "https://api.github.com/repos/elninotech/uppload/git/commits{/sha}",
"git_refs_url": "https://api.github.com/repos/elninotech/uppload/git/refs{/sha}",
"git_tags_url": "https://api.github.com/repos/elninotech/uppload/git/tags{/sha}",
"git_url": "git://github.com/elninotech/uppload.git",
"has_downloads": true,
"has_issues": true,
"has_pages": false,
"has_projects": false,
"has_wiki": false,
"homepage": "https://uppload.js.org",
"hooks_url": "https://api.github.com/repos/elninotech/uppload/hooks",
"html_url": "https://github.com/elninotech/uppload",
"id": 130227442,
"issue_comment_url": "https://api.github.com/repos/elninotech/uppload/issues/comments{/number}",
"issue_events_url": "https://api.github.com/repos/elninotech/uppload/issues/events{/number}",
"issues_url": "https://api.github.com/repos/elninotech/uppload/issues{/number}",
"keys_url": "https://api.github.com/repos/elninotech/uppload/keys{/key_id}",
"labels_url": "https://api.github.com/repos/elninotech/uppload/labels{/name}",
"language": "TypeScript",
"languages_url": "https://api.github.com/repos/elninotech/uppload/languages",
"license": {
"key": "mit",
"name": "MIT License",
"node_id": "MDc6TGljZW5zZTEz",
"spdx_id": "MIT",
"url": "https://api.github.com/licenses/mit"
},
"merges_url": "https://api.github.com/repos/elninotech/uppload/merges",
"milestones_url": "https://api.github.com/repos/elninotech/uppload/milestones{/number}",
"mirror_url": null,
"name": "uppload",
"node_id": "MDEwOlJlcG9zaXRvcnkxMzAyMjc0NDI=",
"notifications_url": "https://api.github.com/repos/elninotech/uppload/notifications{?since,all,participating}",
"open_issues": 6,
"open_issues_count": 6,
"owner": {
"avatar_url": "https://avatars3.githubusercontent.com/u/2952546?v=4",
"events_url": "https://api.github.com/users/elninotech/events{/privacy}",
"followers_url": "https://api.github.com/users/elninotech/followers",
"following_url": "https://api.github.com/users/elninotech/following{/other_user}",
"gists_url": "https://api.github.com/users/elninotech/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/elninotech",
"id": 2952546,
"login": "elninotech",
"node_id": "MDEyOk9yZ2FuaXphdGlvbjI5NTI1NDY=",
"organizations_url": "https://api.github.com/users/elninotech/orgs",
"received_events_url": "https://api.github.com/users/elninotech/received_events",
"repos_url": "https://api.github.com/users/elninotech/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/elninotech/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/elninotech/subscriptions",
"type": "Organization",
"url": "https://api.github.com/users/elninotech"
},
"private": false,
"pulls_url": "https://api.github.com/repos/elninotech/uppload/pulls{/number}",
"pushed_at": "2020-02-27T10:17:50Z",
"releases_url": "https://api.github.com/repos/elninotech/uppload/releases{/id}",
"size": 23681,
"ssh_url": "[email protected]:elninotech/uppload.git",
"stargazers_count": 623,
"stargazers_url": "https://api.github.com/repos/elninotech/uppload/stargazers",
"statuses_url": "https://api.github.com/repos/elninotech/uppload/statuses/{sha}",
"subscribers_url": "https://api.github.com/repos/elninotech/uppload/subscribers",
"subscription_url": "https://api.github.com/repos/elninotech/uppload/subscription",
"svn_url": "https://github.com/elninotech/uppload",
"tags_url": "https://api.github.com/repos/elninotech/uppload/tags",
"teams_url": "https://api.github.com/repos/elninotech/uppload/teams",
"trees_url": "https://api.github.com/repos/elninotech/uppload/git/trees{/sha}",
"updated_at": "2020-02-27T10:17:52Z",
"url": "https://api.github.com/repos/elninotech/uppload",
"watchers": 623,
"watchers_count": 623
},
"sender": {
"avatar_url": "https://avatars3.githubusercontent.com/u/2841780?v=4",
"events_url": "https://api.github.com/users/AnandChowdhary/events{/privacy}",
"followers_url": "https://api.github.com/users/AnandChowdhary/followers",
"following_url": "https://api.github.com/users/AnandChowdhary/following{/other_user}",
"gists_url": "https://api.github.com/users/AnandChowdhary/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/AnandChowdhary",
"id": 2841780,
"login": "AnandChowdhary",
"node_id": "MDQ6VXNlcjI4NDE3ODA=",
"organizations_url": "https://api.github.com/users/AnandChowdhary/orgs",
"received_events_url": "https://api.github.com/users/AnandChowdhary/received_events",
"repos_url": "https://api.github.com/users/AnandChowdhary/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/AnandChowdhary/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/AnandChowdhary/subscriptions",
"type": "User",
"url": "https://api.github.com/users/AnandChowdhary"
},
"sha": "a97a890bd526ba0b2cb0c1a3f4f3d7864d64d054",
"state": "success",
"target_url": "https://travis-ci.org/elninotech/uppload/builds/655737447?utm_source=github_status&utm_medium=notification",
"updated_at": "2020-02-27T10:19:43+00:00"
}config: {
"blocking_labels": [
"do not merge"
],
"labels": [
"ready"
],
"merge_method": "squash",
"review_required": true,
"checks_enabled": true,
"test_mode": true
}##[error]Cannot read property 'labels' of undefined
from merge-bot.
AnandChowdhary
commented on June 3, 2024
Got 2 comments from merge-bot: elninotech/uppload#96 based on reviewer actions. After adding the "ready" label, it works perfectly! :)
from merge-bot.
AnandChowdhary
commented on June 3, 2024
Now, the only thing I'd like to explore is that if it's not eligible for merging, we just end the action with a neutral check, because it's triggered several times and the workflows page looks like this:
Even though it merged perfectly, it also didn't merge several times for the same PR which pollutes the statuses.
from merge-bot.
AnandChowdhary
commented on June 3, 2024
Okay, this is silly of me. Another GitHub app I installed, "merge-me", actually merged that PR, not this GitHub Action. This is the most recent debug message:
merge bot test mode
triggered by: labeled
integration requirements
required label(s): ["ready"]
blocking label(s): ["do not merge"]
reviewers required: true
merge method: squash
pull request stats
labels: ["ready"]
requested reviewers: []
reviewers: {"AlexImb":{"date":"2020-02-27T10:37:05Z","state":"APPROVED"}}
checks: {"total":10,"completed":9,"success":6}
result
eligible for merge: false
Does this mean it would change to "eligible for merge: true" when all checks are completed? I'll remove that app and try again...
from merge-bot.
squalrus
commented on June 3, 2024
Thanks again for the help.
- I opened another PR to get debug data from a forked PR: elninotech/uppload#97
- I think there is an issue with the
checksstatus (separate issue).
from merge-bot.
AnandChowdhary
commented on June 3, 2024
I've merged the PR. Let's see what we can debug from here. :)
Logs after merging: https://github.com/elninotech/uppload/runs/481963327?check_suite_focus=true
from merge-bot.
squalrus
commented on June 3, 2024
Where did the logs come from? It doesn't look like it ran as part of that PR: https://github.com/elninotech/uppload/pull/97/checks
I opened another PR, but rather than merging, would you mind adding a label to trigger the workflow? elninotech/uppload#98
from merge-bot.
AnandChowdhary
commented on June 3, 2024
Done! https://github.com/elninotech/uppload/runs/484204553
from merge-bot.
Related Issues (20)
- Update from base branch before merging. HOT 9
- follow the configured required review count HOT 2
- Don't merge until checks complete HOT 5
- Re-trigger Action when checks complete HOT 1
- ##[warning]Unexpected input 'GITHUB_TOKEN' HOT 1
- GITHUB_TOKEN is unknown as a parameter HOT 1
- README is out of date. HOT 1
- Not detecting reviews? HOT 3
- Pullrequests from forks result in No commit found HOT 3
- Is there a way to merge without labeling? HOT 6
- merge-bot failing with error on pull request HOT 8
- `No commit found for SHA: fix_3353` from `ref` as `heads/branch_name` vs `sha`
- Allow merges even if the base branch changes HOT 2
- Time based allow/block of merges HOT 1
- Bug: don't make all properties required when configuring HOT 1
- Remove `node_modules` HOT 2
- Feature: on commit, remove label(?) or Re-request review(?) HOT 1
- Error: Cannot read properties of undefined (reading 'labels')
- Remove "review_requested" from trigger example HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from merge-bot.