Giter VIP home page Giter VIP logo

Comments (6)

squalrus avatar squalrus commented on June 3, 2024 2

Awesome, thank you for investigating! I will look into this!

from merge-bot.

Undeadlol1 avatar Undeadlol1 commented on June 3, 2024 1

Also, this is the output of bot running in test mode if "labels" field is empty:
image

Seems like there is a fallback to empty string somewhere.

from merge-bot.

squalrus avatar squalrus commented on June 3, 2024

Thanks for reaching out! In your config .yml have you tried setting reviewers to true and labels blank?

reviewers: true
labels: 

I too would expect that work, if not it's a scenario we should support.

from merge-bot.

Undeadlol1 avatar Undeadlol1 commented on June 3, 2024
name: Merge Bot

on:
  pull_request:
    types:
      - labeled
      - ready_for_review
      - synchronize
      - unlabeled
  pull_request_review:
    types:
      - dismissed
      - submitted

jobs:
  merge:
    runs-on: ubuntu-latest
    name: Merge
    steps:
      - name: PR Merge Bot
        uses: squalrus/[email protected]
        with:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          test: true
          reviewers: true
          labels: null
          blocking_labels: do not merge
          checks_enabled: true
          method: squash
          delete_source_branch: true

I tried:
removing "labels" line
make it empty
add "~" to it

None of it worked.
Also, seems like this field is required. Github editor suggests that this field can not be empty.

image

from merge-bot.

squalrus avatar squalrus commented on June 3, 2024

If you are able, could you test with the no-labels branch checked in? The "required labels" output in your debug comment should now be [] (no empty string) and the test for mergability should now pass.

Thanks again for the feedback!

from merge-bot.

Undeadlol1 avatar Undeadlol1 commented on June 3, 2024

I am very thankful for your work.
Sadly I can not test this feature, our project now uses different github action.

from merge-bot.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.