Comments (6)
Awesome, thank you for investigating! I will look into this!
from merge-bot.
Also, this is the output of bot running in test mode if "labels" field is empty:
Seems like there is a fallback to empty string somewhere.
from merge-bot.
Thanks for reaching out! In your config .yml
have you tried setting reviewers
to true
and labels
blank?
reviewers: true
labels:
I too would expect that work, if not it's a scenario we should support.
from merge-bot.
name: Merge Bot
on:
pull_request:
types:
- labeled
- ready_for_review
- synchronize
- unlabeled
pull_request_review:
types:
- dismissed
- submitted
jobs:
merge:
runs-on: ubuntu-latest
name: Merge
steps:
- name: PR Merge Bot
uses: squalrus/[email protected]
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
test: true
reviewers: true
labels: null
blocking_labels: do not merge
checks_enabled: true
method: squash
delete_source_branch: true
I tried:
removing "labels" line
make it empty
add "~" to it
None of it worked.
Also, seems like this field is required. Github editor suggests that this field can not be empty.
from merge-bot.
If you are able, could you test with the no-labels
branch checked in? The "required labels" output in your debug comment should now be []
(no empty string) and the test for mergability should now pass.
Thanks again for the feedback!
from merge-bot.
I am very thankful for your work.
Sadly I can not test this feature, our project now uses different github action.
from merge-bot.
Related Issues (19)
- Update from base branch before merging. HOT 9
- follow the configured required review count HOT 2
- Don't merge until checks complete HOT 5
- Re-trigger Action when checks complete HOT 1
- Unable to perform integration check HOT 13
- ##[warning]Unexpected input 'GITHUB_TOKEN' HOT 1
- GITHUB_TOKEN is unknown as a parameter HOT 1
- README is out of date. HOT 1
- Not detecting reviews? HOT 3
- Pullrequests from forks result in No commit found HOT 3
- merge-bot failing with error on pull request HOT 8
- `No commit found for SHA: fix_3353` from `ref` as `heads/branch_name` vs `sha`
- Allow merges even if the base branch changes HOT 2
- Time based allow/block of merges HOT 1
- Bug: don't make all properties required when configuring HOT 1
- Remove `node_modules` HOT 2
- Feature: on commit, remove label(?) or Re-request review(?) HOT 1
- Remove "review_requested" from trigger example HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from merge-bot.