Comments (3)
bartelemi
commented on June 3, 2024
It must be this line of code:
Line 26 in 7cc41ca
if (Object.keys(this.reviews).length == 0) {
return false;
}In our logs reviews is an empty array (for some reason), so this check returns false.
from merge-bot.
aaron-trout
commented on June 3, 2024
Yeah, I've been having a poke about in the Github API as well. Seems in this specific flow where the reviewers are automatically assigned by CODEOWNERS and it happens to be a group, then when this event happens:
Seem to end up with no "requested" reviewers:
But if you call the endpoint to list the reviews:
So maybe it is because they were not explicitly "requested" as reviewers?
from merge-bot.
squalrus
commented on June 3, 2024
@aaron-trout and @bartelemi -- no problem with the PRs and issues -- I appreciate the help!
I am working on getting your PRs in and then can look at this issue.
from merge-bot.
Related Issues (20)
- Update from base branch before merging. HOT 9
- follow the configured required review count HOT 2
- Don't merge until checks complete HOT 5
- Re-trigger Action when checks complete HOT 1
- Unable to perform integration check HOT 13
- ##[warning]Unexpected input 'GITHUB_TOKEN' HOT 1
- GITHUB_TOKEN is unknown as a parameter HOT 1
- README is out of date. HOT 1
- Pullrequests from forks result in No commit found HOT 3
- Is there a way to merge without labeling? HOT 6
- merge-bot failing with error on pull request HOT 8
- `No commit found for SHA: fix_3353` from `ref` as `heads/branch_name` vs `sha`
- Allow merges even if the base branch changes HOT 2
- Time based allow/block of merges HOT 1
- Bug: don't make all properties required when configuring HOT 1
- Remove `node_modules` HOT 2
- Feature: on commit, remove label(?) or Re-request review(?) HOT 1
- Error: Cannot read properties of undefined (reading 'labels')
- Remove "review_requested" from trigger example HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from merge-bot.