Typescript typings are out of date and not stored in the the repo about animated-scroll-to HOT 6 CLOSED

Hey,
Thank you for the PR. I will look into and merge as soon as I can. I’m on vacation at the moment, so it might take me couple of days.
Cheers!

from animated-scroll-to.

Hello @sanddigital,

I finally got some time to check your PR, and thank you for doing it, I'll make sure to merge those changes. But I don't get why would I include typings file in the repo. I left out compiled lib folder on purpose. To my knowledge it is enough for typings to be available on npm only.

Am I missing something?

Thank you!

from animated-scroll-to.

I decided to do what you suggested, and made some trivial naming changes. Published 2.0.4

Thank you again! I'll close the PR.

from animated-scroll-to.

HI @Stanko thanks for taking a look at this!

I noticed that you didn't merge the changes I put in. One of those changes was to export interface - which makes the typings available to consumers, without them being exported consumers can't utilise them.

To answer the question on including typings in the repo, it just leaves out the mystery of where they come from when looking through the repo.

Can you consider adding the exports as I had done in the PR?

It also looks like you have updated the IOptions incorrectly (there is a passive option which is never used). This is also something that was in the PR.

Can you also consider updating this type to reflect the actual IOptions?

Thanks

from animated-scroll-to.

Will do! I’m traveling today, I’ll probably get to it tomorrow.

from animated-scroll-to.

Should be fine now:
https://github.com/Stanko/animated-scroll-to/blob/c0ecbca48175e1d55aca24aad6b069829c655d9b/lib/animated-scroll-to.d.ts

from animated-scroll-to.