Comments (9)
I cooked up a small how-to example:
https://codesandbox.io/s/gracious-flower-07r5j
It shows how to scroll on mount and on click. Both to specific position and to a element.
Cheers!
from animated-scroll-to.
Hello, library doesn't alter the DOM at all. It just scrolls the page (or element).
Cheers!
P.S. My company used it on a dozen of large React projects already, we never had any issues.
from animated-scroll-to.
animateScrollTo(document.querySelector("#xcv")); .......isn't document.querySelector considered as dom manipulation ?
from animated-scroll-to.
It is actually on user’s side. Library does not access DOM nor alter it.
Cheers!
from animated-scroll-to.
ok Thanks,i don't know where to post my questions since these are all obviously questions not issues and i do wana thank you for your quick reply .I would really appreciate it if you could confirm that the following code is how i'm supposed to use your library in create-react-app :
class App extends Component {
b(){
animateScrollTo(document.querySelector("#xcv"));
}
render() {
return (
<div className="App">
<Button color="primary" onClick={this.b.bind(this)}>primary</Button>
<p>many paragraphs here to show the effect </p>
<h1 id="xcv">zzzzzzzzz</h1>
</div>
);
}
}
export default App;
Of course there is more code but i just added what really mattered and simplified it as much as possible.
from animated-scroll-to.
Excellent job,This was what i'd meant from the beginning ; using refs is a more react-friendly way to do it but since i'm a novice developer i can't really argue with your previous reply "It is actually on user’s side. Library does not access DOM nor alter it." .
from animated-scroll-to.
Would you be happy with me adding something to the docs in an MR about using this library with ReactJS?
It's immensely useful and really effective 👍 💯
from animated-scroll-to.
Sorry, but I really don't get it, it is a single function you need to call somewhere in the lifecycle, what is there to document?
from animated-scroll-to.
I just thought that having the code sandbox and showing an example in the README.md is more approachable to people than having to guess if it will work as expected with ReactJS.
Up to you, it's only an idea which is why I am asking first before just creating a pull request :)
from animated-scroll-to.
Related Issues (20)
- Can you update the CHANGELOG.md for v2? HOT 1
- V2 - Cannot find module 'animated-scroll-to' from 'scrollTo.js' HOT 1
- Switching to commonjs instead of es2015 HOT 2
- v2 breaks SSR apps HOT 4
- Typescript typings are out of date and not stored in the the repo HOT 6
- can you remove comment script tag HOT 4
- Limit scroll directions HOT 1
- No trigger HOT 4
- OnComplete option is not available since v2 HOT 4
- Remove "@types/node" dependency
- Compile Error on node 14 HOT 3
- wrong dependency? HOT 3
- Add note about scroll-behaviour: smooth to readme HOT 3
- [Feature] Add support for iframe contentWindow HOT 1
- It don't work on my mobile applications HOT 4
- Set default options during import HOT 4
- Using with Typescript and useRef hook throws a type error HOT 2
- [feature] add support for scroll-to element and locate it from bottom HOT 1
- Speed can't be changed HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from animated-scroll-to.