Comments (9)
A spreadsheet to pick values from.
from cashflow.
With regards to the spacing scale I would like to know if you want to use clamp or we can use a scale and increment? I don't know if you found it but there's a great dev doc on the newer feature of spacingScale here: https://developer.wordpress.org/news/2023/03/22/everything-you-need-to-know-about-spacing-in-block-themes/#customizing-the-spacing-scale. I 'think' even a simple 7 and 0.25 might work for your case but would like confirmation.
This isn't a blocker more something to discuss tomorrow @kimcoleman.
from cashflow.
There are quite a few fonts in the theme.json for Memberlite. It probably is a good idea to focus on a few and consider bringing more in with the Style variations. What do you think @kimcoleman ?
from cashflow.
Colors:
We need to have the following:
- Default color palettes
- Duotones: ideally I would recommend not having default duotones on - you might decided to have this feature off, but the monotone is useful for image unification.
- Gradients: some subtle ones can be useful.
from cashflow.
Shadows:
We have the ability since 6.2 to add shadows which might be useful for some lift on simple elements. Just adding as option for something to bring into theme.json.
https://developer.wordpress.org/news/2023/01/12/using-the-box-shadow-feature-for-themes/
from cashflow.
There are quite a few fonts in the theme.json for Memberlite. It probably is a good idea to focus on a few and consider bringing more in with the Style variations. What do you think @kimcoleman ?
Agreed - let's keep theme.json just the default heading font, body font, and then also a system serif and system sans serif.
Then the style variations can bring more in.
One issue, though, is that we kind of want a named font to use the font name, but really to be able to use that font choice in supporting stylesheets (if we need them and probably will at least for some PMPro things), it needs to be generic like "body-font" and "header-font". I have a workaround PHP that duplicates a named font property to a generic one. I can show you this code and logic on a shared stream. Maybe you know a better workaround for this.
from cashflow.
With regards to the spacing scale I would like to know if you want to use clamp or we can use a scale and increment? I don't know if you found it but there's a great dev doc on the newer feature of spacingScale here: https://developer.wordpress.org/news/2023/03/22/everything-you-need-to-know-about-spacing-in-block-themes/#customizing-the-spacing-scale. I 'think' even a simple 7 and 0.25 might work for your case but would like confirmation.
This isn't a blocker more something to discuss tomorrow @kimcoleman.
I defer to you on this one. We used clamp in a previous block theme, but I also don't love how its scaling all the time. If spacingScale is the newer approach, I want to use it.
from cashflow.
I have today added:
- Default typography settings.
- Default theme palette based on default from Memberlite.
- Default theme.json settings.
- A basic duotone to set any image to mono.
- A basic gradient based on the orange color from theme.
- Content width and wide settings from Memberlite.
- Folder structure setup for assets, patterns, templates and template parts.
- A link default style.
- A background and text default style.
- Spacing defaults using what is native at a 7 step for now.
- Default shadows.
- Block gap set up 1.2rem for now.
- Typography line-height set to 1.7 for now.
- Headings: added default heading sizes using font scale.
@kimcoleman things to discuss in our sync are now split into separate issues to try and work out along way as this one could get unwieldily.
from cashflow.
Closing as from now on because we have a foundation will work on specific PRs to make this easier for you to track.
from cashflow.
Related Issues (10)
- Patterns: define what ones the theme will include HOT 2
- Define what core blocks need styling HOT 5
- Define what PMPro blocks need styling
- To discuss: home.php HOT 2
- List out all templates and template parts HOT 3
- Add block style functionality to theme HOT 1
- Define what block style(s) want HOT 2
- Typography scale review and set HOT 1
- Template parts to create HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cashflow.