sorry, accidentally hit enter. Problem description:

When I have nested braces in a \() expression, swift-mode ends the \() expression after the first closing brace

Hi,

with the _ commit a new bug has been introduced: _ within an identifier breaks the identifier:

As you can see, the identifier seems to end at the _ char.

Regards,

The last few branches in the indentation command return the same result and can be simplified. This is in the cond around line 146.

Received via email from Sean O'Rourke:

Underscore is a word character in Swift, not whitespace, so

(modify-syntax-entry ?_ "-" table)

in "swift-mode-syntax-table" is wrong.

When writing code which concatenates strings over multiple lines, swift-mode indents like following:

    var x = "abc"
    x += "cde" +
        "fgh" +
          "ijk" +
            "lmn" +
              "opq"

Correct indentation would be like this:

    x += "cde" +
           "fgh" +
           "ijk" +
           "lmn" +
           "opq"

do {
//
} while true
// indent doesn't work here

Two things:

1. Small issue: The repl seems to eat up 7 or so outputs for each time one sends the buffer for evaluation.

2. More annoying: Sending a buffer for evaluation where the buffer's code using all-man style bracing upsets the repl and it doesn't evaluate. K&R style works fine, of course.

/*
/*
*/
This should be commented out.
*/

Write a mode to support the Swift REPL. Implement commands for loading code and regions into the REPL.

Hi,

when writing a class with multiple inherited items one may want to add a line break:

class ProductsViewController: UIViewController, UITableViewDataSource, UITableViewDelegate, UITabBarDelegate {
}

currently swift-mode indents like this:

class ProductsViewController: UIViewController, UITableViewDataSource,
UITableViewDelegate, UITabBarDelegate {

This doesn't look right, better would be something like this:

class ProductsViewController: UIViewController, UITableViewDataSource,
                              UITableViewDelegate, UITabBarDelegate {
}

Best regards,
CK

The indentation is correct with the var xyz

class Foo {
    var xyz
    func Bar {
        let x = 1
        let y = 2
    }
}

However, the indication is incorrect if the func Foo method is the first element of the class.

class Foo {
    func Bar {
    let x = 1
    let y = 2
}
}

Experimentation seems to indicate that a method definition immediately following an opening brace produces incorrect results.

func g() {
    func x() {
    let x = 1
}
}

I tried to decipher the issue, but wasn't able to make much progress without at least a few pointers in the right direction.

As reported by @taku0 in #76 indentation of the multi-line expression in this form is a bit off:

let foo =
    bar +
  baz +
  a

Hi,

indention for enums is totally bugged:

enum OrderViewTableTakeAwayCells: Int {
  case DeliveryCell = 0,
                      nameCell = 1,
                                 emailCell = 2,
                                             phoneCell = 3,
                                                         couponCodeCell = 4,
                                                                          lastCellIndex
}

enum OrderViewTableDeliveryCells: Int {
  case DeliveryCell = 0,
                      nameCell,
                      emailCell,
                      phoneCell,
                      couponCodeCell,
                      addressCell,
                      address1Cell,
                      zipCell,
                      cityCell,
                      lastCellIndex
}

enum OtherEnum {
  case Val1
  case Val2
  case Val3
}

String interpolation is not recognized when the variable contains a _:

Find a way to get code-completion working with completion-at-point to enable auto-completion using company-mode.

Hi,

string interpolation with a dot in it isn't recognized:

Regards,
CK

SMIE pretty much aims to end the practice of every package rolling out custom indentation logic. You can see ruby-mode in Emacs's trunk for a good example of SMIE usage.

When having an question mark or exclamation mark in the expression, swift-mode fails to detect string interpolation:

Replace with (set (make-local-variable ...) ...). This is compatible with older emacsen and will allow removal of the reimplementation of setq-local.

As mentioned in #37, default offset for multi-line dot expressions can be sometimes too deep, because it defaults to be aligned with assignment operator (=). I personally like such indentation, but as @ckruse mentioned, he would prefer different style of indentation. I would be great to make this offset customisable (similar to swift-indent-switch-case-offset).

If there is a keyword such as override, it idents correctly

Identifiers in destructuring binds should be font locked. As an example, both x and y should be highlighted as identifiers, but in the current implementation, only x will be.

let x = foo
let (y,_) = bar

Summary

Please allow the user's tab-width preference (when present) to automatically override swift's default value.

Background

I am officially agnostic on indentation settings.

For much of my code, I happen to prefer soft tabs (spaces), of width 2. For most major modes, I can simply (setq-default tab-width 2) near the beginning of my ~/.emacs, and just about every mode obeys this preference.

For some finnicky modes, I can write a hook to forcibly assign the local tab-width definition to 2.

However, swift-mode is even more finnicky, due to many internal functions referring to swift-indent-offset rather than tab-width.

Mitigation

Currently, I have to override both variables in order to indent how I like:

(add-hook 'swift-mode-hook
          (lambda ()
            (setq-local tab-width 2)
            (defvar swift-indent-offset)
            (setq-local swift-indent-offset 2)))

System

$ specs cask:swift-mode emacs os
Specs:

specs 0.12
https://github.com/mcandre/specs#readme

find $HOME/.emacs.d/.cask -name '*swift-mode*' | head -n 1
/Users/andrew/.emacs.d/.cask/24.3.1/elpa/swift-mode-20141107.300

emacs --version
GNU Emacs 24.3.1
Copyright (C) 2013 Free Software Foundation, Inc.
GNU Emacs comes with ABSOLUTELY NO WARRANTY.
You may redistribute copies of Emacs
under the terms of the GNU General Public License.
For more information about these matters, see the file named COPYING.

system_profiler SPSoftwareDataType | grep 'System Version'
      System Version: OS X 10.10.1 (14B25)

When chaining method calls and inserting a line break, the indention breaks. With the following code:

let json_ary = NSJSONSerialization
.JSONObjectWithData(data, options: nil,
                    error: &json_err) as NSArray

I expect it to get indented like this:

let json_ary = NSJSONSerialization
  .JSONObjectWithData(data, options: nil,
                      error: &json_err) as NSArray

I keep getting this error only when using swift mode. I opened up a fresh install of emacs and only installed swift-mode and I get the same problem. This happens after the class declaration. Basically, I can create a class without issues but as soon as I finish typing func I get the warning and indentation, etc. stops working correctly.

electric-indent-mode will be enabled by default in Emacs 24.4. It'd be nice if switf-mode supported it.

As reported by @tak0 in #76 declaration attributes add unnecessary offset to the expressions:

@Foo public class Foo {
         a
     }

All case statements are currently aligned to the same level as the enclosing block. This is appropriate for switch statements but not for enum cases.

Hey Chris,

I merged your swift-mode this week and it's working a lot beter! Awesome work!

I'm only still having problems with idention. I've pasted some example code here:
https://gist.github.com/roxlu/3c899602069a7b471cae#file-newslocationviewcontroller-swift-L59-L60

Notice how the closure indention breaks. For some indention issues I found work-arounds but not
for this one.

Thanks

something wrong when i used Implicitly Unwrapped Optional Type:

    var manager:User   
    var name:String
    var cars:Array<RentItem>!
                   var users:Dictionary<String, User>!
                                        var carscount:Dictionary<String, Int>!
                                                                 var orders:Dictionary<Int, Order>

Currently, interpolation contexts in strings do not use code font-locking. In the following,

"foo \(bar + baz)"

everything inside the parens should be font-locked as code.

The mode currently lacks an indentation function. Swift uses a rigid block structure, so this shouldn't be too hard.

Other block-structured languages like C or Ruby might make good references for implementation.

Whenever I open a Swift file I get this error:

File mode specification error: (void-variable flycheck-swift-sdk-path)

I have to comment the eval-after-load block to avoid this error message and make Emacs usable again.

Commented lines are not being font locked correctly. They retain their existing font locking, rather than having the comment face applied.

E.g. #if, #elseif, #else, #endif

With the latest changes I get the following error whenever I open a Swift file:

Error: (wrong-type-argument stringp ("/var/folders/x2/rr8_tk0169n9w8_lmjv6rg300000gn/T/flycheck63731PnK/AppDelegate.swift"))

The exact folder differs, but the message is always the same.

• Replace usage of -flatten with append
• Delete package requirements in header

Research whether the compiler can perform type checking without code generation, then make a flycheck checker to provide syntax checking.

Would you mind submitting this to melpa so the rest of us can play and stay up to date easier? It really only takes submitting a formula to https://github.com/milkypostman/melpa

I can help if you'd like.

Anything defined with the func keyword is currently categorised as a function, even when it is really a method (i.e. declared inside a class).

This resulted in swift-mode using an indent of 8 spaces.

When attempting to set the variable via customize, I got the following error when expanding an item

widget-apply: Symbol's function definition is void: nil

Hi,

when writing a case statement it gets indented like this:

    switch(x) {
    case 1:
      doing()
      default:
      return
    }

It should be indented like the rest of the case statements:

    switch(x) {
    case 1:
      doing()
    default:
      return
    }

Hi Chris, sorry to contact you through an issue, but I can't find your contact info.

I was wondering if there is a way to set the idention levels because currently my code
jumps outside the view of my editors. I've pasted a snippet of my code which shows
the indention that I want to change:

https://gist.githubusercontent.com/roxlu/8498420d0b5524675e3c/raw/27a18777e5adabc76c5eaf2cb0bc658f08e65c07/ViewController.swift

Thanks for this awesome swift-mode!

Hi,

when working with regular expressions I noticed that breaking after a logical or indents really weird:

    let options = NSRegularExpressionOptions.CaseInsensitive |
                                             NSRegularExpressionOptions.DotMatchesLineSeparators

It should indent like this:

    let options = NSRegularExpressionOptions.CaseInsensitive |
                  NSRegularExpressionOptions.DotMatchesLineSeparators

or alternatively like this:

    let options = NSRegularExpressionOptions.CaseInsensitive |
                    NSRegularExpressionOptions.DotMatchesLineSeparators

I like the latter ;-)

Hi,

a ternary operator is a common thing in return statements, and often they contain line breaks. A ternary operator should therefore be indented:

instead of this (current behaviour):

return order!.deliver ?
OrderViewTableDeliveryCells.lastCellIndex.rawValue :
OrderViewTableTakeAwayCells.LastCellIndex.rawValue

I'd like to get this:

return order!.deliver ?
  OrderViewTableDeliveryCells.lastCellIndex.rawValue :
  OrderViewTableTakeAwayCells.LastCellIndex.rawValue

It's extremely uncommon for major modes to be split into several files. I'd suggest simply merging swift-indent into swift-mode.

The following statement gets indented wrong:

for item in order {
  moc
  .deleteObject(item)
}

It should indent the method call one level more deep. When leaving out the for loop indention works:

moc
  .deleteObject(item)

As reported by @taku0 in #76. This case can be handled better:

let foo = [
    bar:
    baz, // I want an extra indentation for this line
    bar:
    baz, // and this line
]