swinton / screenshot-website Goto Github PK

As described in this post¹, node12 is being deprecated in favor of node16:

We plan to migrate all actions to run on Node16 by Summer 2023. We will monitor the progress of the migration and listen to the community for how things are going before we define a final date.
To raise awareness of the upcoming change, we are adding a warning into workflows which contain Actions running on Node 12. This will come into effect starting on September 27th.

Reviewing the changelogs of other GitHub Actions like checkout² or cache[^3], the transition to node16 corresponded to a major release.

I suggest we follow the same pattern and release v2

I'm not sure which of the new changes might have caused this, but as of the latest commit, when I try to run even the basic usage (one screenshot, one resolution, on ubuntu-latest) the action never completes. I don't get any error, it's just stuck on the screenshot step indefinitely -- I canceled it after 2 hours.

Hi all,
it is more a feature request. Is it possible to add multiple URLs/sources in one action?

Thanks,
Sven

I'm using this action to create fullscreen screenshots of a website, that loads after some seconds. Therefore I use the delay and full-screen parameter. Since today (example run) there is a warning displayed (as annotation):

Unexpected input 'delay', valid inputs are ['source', 'destination']

I don't know if something changed at GitHub to now detect non-specified arguments.

Is there a way to get rid of the warning?

@swinton Thanks for putting together this streamlined GitHub Action 🙏 💯

Would you consider adding other maintainers to help integrate outstanding pull requests and performing general maintenance ?

In the meantime, you will find the following pull requests:

• #35
• #36

Request to add an option to emulate preference of dark color scheme (prefers-color-scheme).

Running just the basic usage works.

When I tried using the first advanced usage example, with the different OSes, I got the following errors--

On Windows:
Error: Failed to launch the browser process! spawn C:\Program Files (x86)\Google\Chrome\Application\chrome.exe ENOENT

On Mac:
Error: The operation was canceled.

On Ubuntu:
Error: A task was canceled.

(To be clear, I didn't cancel those myself, and the error doesn't seem to provide any more info on why they were canceled.)

Incidentally, using the width variables with a single OS does work, although the width variable generates a warning. Attempting it with both width and OS variables (as in the second advanced usage example) fails on the same OS errors.

I was wondering how to best create stable releases of this GitHub Action going forward?

Given that development on this project is just picking up speed again, this may not be the most important topic right now. Still I wanted to put it in writing, so that we don't forget about it.

Worthwhile goals would be

1. not to break workflows of people by introducing breaking changes
2. allowing as many people as possible to benefit from improvements, without them having to update their workflow

Now I noticed that the documentation currently suggest to use the v1.x string:

- name: Screenshot Website
  uses: swinton/[email protected]
  with:
    source: https://github.com/swinton/screenshot-website
    destination: screenshot.png
    full-page: true

That might be a bit misleading, at least it was for me. Based on the v1.x string I assumed:

• this points to releases of this project (while it actually is a branch)
• when using this, I will automatically get all new releases of the v1 major version. However this does not automatically work but only if for every new release the v1.x branch is updated as well. This means extra burden for the maintainers.

Suggested Release Strategy

I don't know many users this GHA has, so the level of effort that should be put into this is certainly up for debate.

FYI I am basing my assumptions on how GHA version works on ¹ and ².

Now how could we version/release this GHA going forward:

1. make essential fixes to keep the v1.x working for a while (e.g. upgrade to node16 plus the actions/core upgrades that are already done). then update the v1.x branch with these fixes, and create new packaged releases in parallel as desired (e.g. v1.1.0 and v1.2.0)
2. the above should be the last upgrade to the v1.x branch (to save the maintainers extra burden)
3. update the documentation to specify v1 instead of v1.x allowing new users to automatically benefit from new releases of the 1-major version

Alternative

An alternative to this might be to not update the v1.x at all, so that it will break at some point (not sure when that will be).

That might motivate users of this GHA to read the documentation again, and notice the new releases. For this to work we would have to make it super obvious for them which change they have to make to get the latest version.

Thoughts?

I want to set as destination folder the current working folder.

I can't find the way to save the screenshot as artifact AND in the repository. Is it possible ? Maybe it's a dumb question but my Action fails everytime I try to update my repo with a screenshot. Thanks !

Hi,

I wanted to ask if you know if it's possible to combine this action with the default Netlify setup.

Netlify hosts a preview of the current build, that's linked in every new PR. Now I want to have screenshots from this preview on multiple screen sizes. Do you know if that's possible?

Thanks,
Luka :)