Moving the shim detection to outside of the bindings about angular-placeholder HOT 5 CLOSED

@fidian Hi,
I just move to top if (needsShim) { line - you need placeholder shim only for IE8-9
but in chrome you directive currently also work, just check you example https://jsfiddle.net/y78ohbuw/1/embedded/result/ in chrome 2 bottom fields has both placeholder and text

from angular-placeholder.

One of the points of the placeholder module is to toggle a class that also allows for easier styling. If I move the if up that high, I eliminate the toggles for the class.

from angular-placeholder.

@fidian , why you need this class toggling for browsers that support placeholder ?
I thought this is kind like shim for placeholder support

from angular-placeholder.

Without the shim in newer browsers you are able to style the text. The CSS selector is per-browser, which is irritating.

In older browsers you can not style the placeholder text with a CSS selector. Thus if I use the shim, I also want to make it possible to style the placeholder text.

To achieve the utmost in simplicity for the user, the placeholder class is added and removed. That way there is a single, uniform way of styling the input.

from angular-placeholder.

Closing issue because the shim provides two benefits and the proposed change negates one of those benefits.

from angular-placeholder.