Change NPM main file about angular-placeholder HOT 6 CLOSED

The point is being able to do

angular.module('myApp', [
  require('angular-placeholder')
]);

from angular-placeholder.

Is this a pattern that Angular libraries typically follow? Is there Webpack documentation on this approach?

I ask because I don't use Webpack and this works great with Browserify as-is. Also, if I change the main entry to index.js with the content you suggested, none of the code would be exported.

Wouldn't the exact same effect be accomplished if I had module.exports = "taiPlaceholder"; as the last line in lib/tai-placeholder.js?

from angular-placeholder.

it seems that all angular official modules follow this pattern.

The code actually does not need to be exported, out just needs to be executed to register the module inside angular.

You can indeed make the change in the current main file but don't forget to check that module.exports actually exists (for bower and "old-school" users)

from angular-placeholder.

On the other hand I don't know Browserify will react the the change. But if you already use things like angular-animate or angular-cookies it shouldn't be a problem.

from angular-placeholder.

This appears to have no problems whatsoever for me and it helps you out. I've added a test to confirm the functionality and everything appears to be working as expected. I've released 1.1.0 in the hopes that it works for you. Let me know if I didn't do it right.

from angular-placeholder.

Thank you, works perfectly.

from angular-placeholder.