Placeholder does not play well with required in 1.3 and ng-required in 1.2 about angular-placeholder HOT 7 OPEN

We've experienced the same issue.

Because the placeholder text is being set on the element's val, the required directive sees it as a view value. So all our required inputs with placeholders are being set as valid when they aren't.
https://github.com/angular/angular.js/blob/v1.3.15/src/ng/directive/validators.js#L12

from angular-placeholder.

I ended up writing a directive that overrides the angular 'required' directive and adds a situation where if the placeholder attribute is equal the viewValue (element.val()) it marks the input as invalid.

https://gist.github.com/CullenShane/ebe103df0790a0d86262

from angular-placeholder.

I've changed the code in the issue-5 branch and I don't use the value in the scope any longer. Angular appears to use the scope value as the source of truth, thankfully, and so maybe this problem is resolved? I've tried the updated code in the fiddles provided and have seen the correct results.

from angular-placeholder.

I assume the previous comment was meant for #5 ?

from angular-placeholder.

No. It applies to this issue. As I mentioned, I don't use scope any longer. This issue cropped up because I did use scope a tiny amount. I also tested the issue-5 branch against the two fiddles mentioned at the start of this issue and I believe the code I added will solve both problems at once.

from angular-placeholder.

Ah, I understand. I will try that branch tonight and get back to you.

from angular-placeholder.

@fidian I have tried the issue-5 branch, and it does correct the styles issue, it does not correct the validation issue.

The issue is only present on pristine forms. Before the user types anything into the form, it should be invalid because input is required.

I've updated the jsfiddle provided earlier to demonstrate the difference in behavior of vanilla vs with this project included. https://jsfiddle.net/y78ohbuw/1/embedded/result/

from angular-placeholder.