tgxn / backup Goto Github PK

This is just to let me know theres a few things i need to complete, and split into a couple more handler classes (modularization).

Ill put a changelog here when im done.

Should this be removed, as i do not see why anyone would want this, and it also makes the deleteOldBackups() not very accurate.

if (settings.getBooleanProperty("singlebackup")) {

I will leave a comment in the code referring to this issue.

Title, I'm using CommandBook 1.6 for the bans in combination with Backup 1.8.

I'd love to have a way to disable broadcast on the server and just log to a file in the plugin folder (e.g. backup.log).

Thanks! :)

placeholder to keep this unfinished milestone open

1.8.3-dev through the current build 5
CB 1337 through 1559
Latest config:
http://pastebin.com/iV3GNPFc

I have 5 folders: plugins and 4 worlds. The main world folder always leaves an empty folder behind after zipping the file. To be specific, inside my rolocraft02 folder are all the normal zips along with an empty folder for each zip. This behavior only seems to happen with automated backups and not with a manual /backup.

• Inspired by xZises suggestion:

- http://forums.bukkit.org/threads/inactive-admn-backup-1-6-a-simple-backup-plugin-818.9871/page-16#post-711084

1 - Backup Task every 15 min

2 - Backup Task every 2 h

This would mean that the 8th Backup is your 2h backup or in your example your 12th backup is the 3h backup.

Even if you do a 12min or 7 min backup you will have a calculateable hour backup somewhere along the way ;)

Anyhow ... a good idea i could think of an configureable hourly backup that would temporarily disable an overlapping repeated backup task that runs every n minute.

Feature request would be "hourly backup vs repeated backup" ... i hope i have described it well...

Its kinda the same principle as normal backup tasks like "Father Son" ... Each Sunday full backup, til then incremental backups ... Full backups would be kept but inbetween it would be deleted as soon as we have another sunday backup.

Now if we use time as an index and trigger the garbage collector ...

Conzept:

(( Our Server is never used. First fixed backup is scheduled to run at 00:00:00 o'clock ))

1. Configured a repeated hourly backup every 2 h

2. Configured a backup task that runs every 15/30 min

• Keep the last 96/48 backups of task 2) (1440 minutes -> one day) until .....
• Keep the last backup of task 1) and the first of 1) so you will most likely have a "near day started" and a "near day ended" backup file (real time).

This routine would be repeated every day so you have a started and ended day backup for lets say 5 days.

It is most likely that you would need this plugin only for "wtf everything is broken"-backups or in case of map corruption.

For specific region restorations or griefing stuff i personally think that everything above this functionality is too much for this little plugin and that there should be another plugin used like BigBrother or LogBlock because restoring specific regions per full backup or per user isn't efficient in my opinion =)

Backup 1.8.3-dev on Bukkit 1337:

00:26:54 [INFO] java.lang.NullPointerException
00:26:54 [INFO]         at net.tgxn.bukkit.backup.threading.BackupTask.cleanFold
er(BackupTask.java:381)
00:26:54 [INFO]         at net.tgxn.bukkit.backup.threading.BackupTask.deleteOld
Backups(BackupTask.java:364)
00:26:54 [INFO]         at net.tgxn.bukkit.backup.threading.BackupTask.backup(Ba
ckupTask.java:300)
00:26:54 [INFO]         at net.tgxn.bukkit.backup.threading.BackupTask.run(Backu
pTask.java:87)
00:26:54 [INFO]         at org.bukkit.craftbukkit.scheduler.CraftWorker.run(Craf
tWorker.java:34)
00:26:54 [INFO]         at java.lang.Thread.run(Unknown Source)
00:26:54 [INFO] java.lang.NullPointerException
00:26:54 [INFO]         at net.tgxn.bukkit.backup.threading.BackupTask.cleanFold
er(BackupTask.java:381)
00:26:54 [INFO]         at net.tgxn.bukkit.backup.threading.BackupTask.deleteOld
Backups(BackupTask.java:364)
00:26:54 [INFO]         at net.tgxn.bukkit.backup.threading.BackupTask.backup(Ba
ckupTask.java:300)
00:26:54 [INFO]         at net.tgxn.bukkit.backup.threading.BackupTask.run(Backu
pTask.java:87)
00:26:54 [INFO]         at org.bukkit.craftbukkit.scheduler.CraftWorker.run(Craf
tWorker.java:34)
00:26:54 [INFO]         at java.lang.Thread.run(Unknown Source)

timer is broken again - average 20-50 players on server
http://clip2net.com/s/1lKHV

btw. could u make broadcast messages (on backup) being visible for everyone? Currently only ops can see them

As of bukkit forum post http://forums.bukkit.org/threads/inactive-admn-backup-1-6-a-simple-backup-plugin-818.9871/page-11#post-384316 v1.6 is not deleting old backups.

UpdateConfig
:: getConfigVersion()
:: convertNodes()
:: enum updateVersions("1.8", "1.8.3")
:::: If not in list (no changes done) only update version string
:::: if in list getConfigVersion() and perform from -> to update

1.8.4 has an issue when it backs up when no players are online even when the setting is turned off.

Fix in 1.8.4-1 tommorow.

Make no Backup if only Op's on the server?

Change permissions for bukkit default perms support - Should be fairly simple.

Great plugin. Just started running a server again and this is something I was definitely missing last time.

Permissions don't seem to be working with PermissionsBukkit. It works fine when I make myself OP. Running 1.8.1 on RB #1240 with PermissionsBukkit 1.2k.

http://forums.bukkit.org/goto/post?id=734613#post-734613

When backups are being performed, the logs, both In-Game and Console, display lines multiple times.

• This seems to happen only in the RB build of bukkit and not the dev build, so it is most likely somethign to do with bukkit itself.

I just installed Backup in my server, which is running PermissionsEx, and I found that users could not be promoted to any group that gives people the * node. What it does is it basically negates the * node, so that group can't do ANYTHING, even chat. Opping them fixes it, but anyone who's an op gets the * node anyway. When deopped is goes back to negating the * node. Please fix it, as my limited experience with Backup has been fantastic as far as backup scripts go.
Please reply to [email protected].

Thanks!

see header

Hi, I always get following error very very often:

00:40:55 [SEVERE] [Backup] Failed to list backup directory.

Would be nice if it possible to remove them.

Plugin/Server data:

>version Backup
00:50:46 [INFO] Backup version 1.8.4-dev
00:50:46 [INFO] CraftBukkit server Backup plugin.
00:50:46 [INFO] Authors: Meldanor, gamerx and lycano
>version
00:50:48 [INFO] This server is running Craftbukkit version git-Bukkit-1.8.1-R4-7
7-ge86a355-b1550jnks (MC: 1.0.1) (Implementing API version 1.0.0-R1-SNAPSHOT)

Fabian

As the titel tells. An option to exclude a sub-folder from the backup-routine would be nice.

I do run a server with BukkitHTTPD as do not relly need a full webserver. But inside the folder is a huge folder containing the rendered world from minecraft-overviewer (>500MB). I do not want it to backuped as it takes a lot of time!
Currently i can only exlude the whole BukkitHTTPD folder if i got the options right. But in the folder are also player stats which i really like to be included.

Hope for positive messages from you!

Obviously with a better implementation.

As per demand to be WorldEdit- Compatable.

This will be in 1.8.3.

Sorry guys, you only know how much you miss something until its gone.

Brainstorming expected .... (some features may already exist)

Focus: Backup related

• Simple usage
• Fire and Forget
• what shall this plugin backup?
  -- world folder (includes players)
  -- plugins folder
  -- configureable option to decide what to backup
• Ingame command system
• Menu driven and searchable
• ...

Create wiki pages after this milestone is complete / target is clear

Hi,
when I start the server with the version 1.8.4 of Backup I receive these errors:

2011-12-17 16:21:05 [SEVERE] Error occurred while enabling Backup v1.8.4 (Is it up to date?): null
java.lang.NullPointerException
at java.io.Writer.(Writer.java:88)
at java.io.BufferedWriter.(BufferedWriter.java:101)
at java.io.BufferedWriter.(BufferedWriter.java:88)
at net.tgxn.bukkit.backup.utils.LogUtils.logLineToFile(LogUtils.java:92)
at net.tgxn.bukkit.backup.utils.LogUtils.sendLog(LogUtils.java:151)
at net.tgxn.bukkit.backup.utils.LogUtils.sendLog(LogUtils.java:116)
at net.tgxn.bukkit.backup.BackupMain.setupPermissions(BackupMain.java:131)
at net.tgxn.bukkit.backup.BackupMain.onEnable(BackupMain.java:74)
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:188)
at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:968)
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:280)
at org.bukkit.craftbukkit.CraftServer.loadPlugin(CraftServer.java:186)
at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:169)
at net.minecraft.server.MinecraftServer.t(MinecraftServer.java:348)
at net.minecraft.server.MinecraftServer.a(MinecraftServer.java:335)
at net.minecraft.server.MinecraftServer.init(MinecraftServer.java:165)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:399)
at net.minecraft.server.ThreadServerApplication.run(SourceFile:457)

detailed description and behavior needed.

Hi,
when I've update to the version 1.8.3 now it create a backup every second!
How can I fix it? (for the moment I've downgraded to the version 1.8.1)
Regards.

A feature that would be nice, but is not urgent: Delete old backups when the backup directory reaches a certain size, rather than a certain amount of backups. I use Dropbox to keep copies of my world in the cloud, in case my whole server explodes. It would be nice to have a plugin that automatically keeps my account under quota.

Can you make an option so that the plugin backups still go to a separate folder called plugins but the world map saves are not sorted by folders and are all in one place. Also this requires an extra date string for the map name.

This allows for less typing when using worldedit to restore griefed areas since I dont have to type the folders name.

It would look something like this:

/plugins
world_12-05_18-57.zip
world_12-06_18-57.zip
world_nether_12-05_18-57.zip
world_nether_12-06_18-57.zip

Just a thought.

And do you also support the extra zero in dates and times?

For example date 12-05 can also be 12-5 to make it shorter. Are you supporting that?

Thanks

When ZIP'ing is enabled, the folder that is to be zipped should be in a temp file so it can be excluded from applications such as Dropbox.

Did a fresh install of the new build because I wanted to see if it fixed a problem I was having. In addition to the problem still persisting, the new build also throws the following error.

CB 1559 Backup 5

17:42:35 [INFO] [Backup] Started Backup!
17:42:35 [INFO] CONSOLE: Forcing save..
17:42:35 [INFO] CONSOLE: Save complete.
17:42:35 [INFO] CONSOLE: Disabling level saving..
17:42:38 [SEVERE] [Backup] Failed to ZIP Backup: IO Exception.
17:42:38 [SEVERE] java.lang.NullPointerException
17:42:38 [SEVERE]       at net.tgxn.bukkit.backup.utils.DebugUtils.debugLog(DebugUtils.java:31)
17:42:38 [SEVERE]       at net.tgxn.bukkit.backup.utils.DebugUtils.debugLog(DebugUtils.java:19)
17:42:38 [SEVERE]       at net.tgxn.bukkit.backup.threading.BackupTask.doZIP(BackupTask.java:316)
17:42:38 [SEVERE]       at net.tgxn.bukkit.backup.threading.BackupTask.backupWorlds(BackupTask.java:192)
17:42:38 [SEVERE]       at net.tgxn.bukkit.backup.threading.BackupTask.doBackup(BackupTask.java:131)
17:42:38 [SEVERE]       at net.tgxn.bukkit.backup.threading.BackupTask.run(BackupTask.java:75)
17:42:38 [SEVERE]       at org.bukkit.craftbukkit.scheduler.CraftWorker.run(CraftWorker.java:34)
17:42:38 [SEVERE]       at java.lang.Thread.run(Unknown Source)

we need to change the Project name in order to release the plugin someday because Backup is blocked by the original author.
Also i would suggest changing the Github Repo name also.

I would suggest BackupPlusPlus (Backup++)

If you comply leave me a message i will refactor the package then and push it to dev.

What do you mean by "SQL databases"?

For Servers this is easy as long as the driver is known. If the Database is a file like h2sql then this can be tricky cause we may already have the file backed up when backing up the plugins dir (normally the database is stored in the plugins plugin folder).

im leaving this open as a reminder so we dont forget to change this as soon as possible

I get this in console all the time what does it mean?
[Server] INFO [Backup] was not last player to leave.

Basically i don't want a backup to happen if all the online players are admins to save space. So what i want is don't make a backup if all players since last backup have permission backup.exempt for example.

Hi! I have Backup 1.8.3 and it works great. However, it backups the server every time a player disconnects, which is rather annoying. How can i fix this issue?

Thanks
Donut Seller

1. reload: Reload the plugin itself for what?
2. list: list directory contens with ability to filter output?
3. last: show last 5 (configureable) done backups?
4. next: print out next backup scheduled?
5. log: chatlog export/filter?

Hi,
i use bukkit 1566 with Backup v1.8.4-dev, but at startup:

2011-12-08 09:16:18 [SEVERE] Error occurred while enabling Backup v1.8.4-dev (Is it up to date?): null
java.lang.NullPointerException
at java.io.Writer.(Writer.java:71)
at java.io.BufferedWriter.(BufferedWriter.java:83)
at java.io.BufferedWriter.(BufferedWriter.java:70)
at net.tgxn.bukkit.backup.utils.LogUtils.logLineToFile(LogUtils.java:92)
at net.tgxn.bukkit.backup.utils.LogUtils.sendLog(LogUtils.java:151)
at net.tgxn.bukkit.backup.utils.LogUtils.sendLog(LogUtils.java:116)
at net.tgxn.bukkit.backup.BackupMain.setupPermissions(BackupMain.java:131)
at net.tgxn.bukkit.backup.BackupMain.onEnable(BackupMain.java:74)
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:188)
at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:957)
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:280)
at org.bukkit.craftbukkit.CraftServer.loadPlugin(CraftServer.java:186)
at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:169)
at net.minecraft.server.MinecraftServer.t(MinecraftServer.java:342)
at net.minecraft.server.MinecraftServer.a(MinecraftServer.java:329)
at net.minecraft.server.MinecraftServer.init(MinecraftServer.java:165)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:393)
at net.minecraft.server.ThreadServerApplication.run(SourceFile:457)

and stop:

2011-12-08 09:29:23 [SEVERE] Error occurred while disabling Backup v1.8.4-dev (Is it up to date?): null
java.lang.NullPointerException
at java.io.Writer.(Writer.java:71)
at java.io.BufferedWriter.(BufferedWriter.java:83)
at java.io.BufferedWriter.(BufferedWriter.java:70)
at net.tgxn.bukkit.backup.utils.LogUtils.logLineToFile(LogUtils.java:92)
at net.tgxn.bukkit.backup.utils.LogUtils.sendLog(LogUtils.java:151)
at net.tgxn.bukkit.backup.utils.LogUtils.sendLog(LogUtils.java:125)
at net.tgxn.bukkit.backup.BackupMain.onDisable(BackupMain.java:113)
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:190)
at org.bukkit.plugin.java.JavaPluginLoader.disablePlugin(JavaPluginLoader.java:978)
at org.bukkit.plugin.SimplePluginManager.disablePlugin(SimplePluginManager.java:296)
at org.bukkit.plugin.SimplePluginManager.disablePlugins(SimplePluginManager.java:289)
at org.bukkit.craftbukkit.CraftServer.disablePlugins(CraftServer.java:181)
at net.minecraft.server.MinecraftServer.stop(MinecraftServer.java:370)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:449)
at net.minecraft.server.ThreadServerApplication.run(SourceFile:457)

Since this change to bukkit:
Bukkit/Bukkit@7306aa8

The ConsoleCommandSender can no longer be constructed, therefore it needs to be attained using server.getConsoleSender()

This generates an issue, as we cannot get the ConsoleCommandSender when using the new, dev builds of bukkit (> 857)

More information is in this commit:
0009e5f

Backup is occurring after every player leaves.

How do I turn off backup notification? I updated and suddenly everyone on my server gets the notice. backup.notify perhaps?

As per:
http://forums.bukkit.org/threads/admn-backup-1-8-1-a-simple-backup-plugin-1240.39927/#post-728220

Should be done right after "Refactoring Stage 1" Milestone is completed

Do you mean "filter server.log for chat messages and output to file?"

if yes possible filter shall be: Per user, during period

AS the title suggests

body

LEASE have this able to hide the text from the console, as that is the only thing I see while scrolling through. Thanks!

skipplugins should be dual purpose.

TODO:

Rename: 'skipplugins' To: 'pluginlist'.

Config: 'backupplugins'
If true, 'pluginlist' list plugings to exclude.
If false, 'pluginlist' list plugings to backup.

As of:
http://forums.bukkit.org/threads/admn-backup-v1-8-2-a-simple-backup-plugin-1317.39927/page-2#post-754110

i have a .sh that comes pretty handy on the read side (i make copys to all the diferent places i need and grab them respectivly with php). Would it be possible for this plugin to execute such .sh instead of the default backup?

I tried the plugin and everything was pretty awesome until i tried to use the .zips to restore griefed stuff and ou my, worldedit gave me an error when using the .zip made my your plugin so maybe have a look at that. Sorry i cant remeber the error.

It was something like "Worldedit didnt find the map from that zip or folder" If I turn off the split maps and just make folders then it works but i still would like to have compression and save space

Thank you

Done during Refactoring.... ability to increase or decrease log level

17.12 09:01:02 [Server] INFO at net.minecraft.server.ThreadServerApplication.run(SourceFile:457)
17.12 09:01:02 [Server] INFO at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:399)
17.12 09:01:02 [Server] INFO at net.minecraft.server.MinecraftServer.init(MinecraftServer.java:165)
17.12 09:01:02 [Server] INFO at net.minecraft.server.MinecraftServer.a(MinecraftServer.java:335)
17.12 09:01:02 [Server] INFO at net.minecraft.server.MinecraftServer.t(MinecraftServer.java:348)
17.12 09:01:02 [Server] INFO at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:169)
17.12 09:01:02 [Server] INFO at org.bukkit.craftbukkit.CraftServer.loadPlugin(CraftServer.java:186)
17.12 09:01:02 [Server] INFO at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:280)
17.12 09:01:02 [Server] INFO at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:968)
17.12 09:01:02 [Server] INFO at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:188)
17.12 09:01:02 [Server] INFO at net.tgxn.bukkit.backup.BackupMain.onEnable(BackupMain.java:74)
17.12 09:01:02 [Server] INFO at net.tgxn.bukkit.backup.BackupMain.setupPermissions(BackupMain.java:131)
17.12 09:01:02 [Server] INFO at net.tgxn.bukkit.backup.utils.LogUtils.sendLog(LogUtils.java:116)
17.12 09:01:02 [Server] INFO at net.tgxn.bukkit.backup.utils.LogUtils.sendLog(LogUtils.java:151)
17.12 09:01:02 [Server] INFO at net.tgxn.bukkit.backup.utils.LogUtils.logLineToFile(LogUtils.java:92)
17.12 09:01:02 [Server] INFO at java.io.BufferedWriter.(Unknown Source)
17.12 09:01:02 [Server] INFO at java.io.BufferedWriter.(Unknown Source)
17.12 09:01:02 [Server] INFO at java.io.Writer.(Unknown Source)
17.12 09:01:02 [Server] INFO java.lang.NullPointerException
17.12 09:01:02 [Server] SEVERE Error occurred while enabling Backup v1.8.4 (Is it up to date?): null

Bacause it's Deprecated.

See YamlConfiguration