Would be helpful to run a component (aka subtree thingy) in a <code class="notranslate

I agree with <a class="user-mention notranslate" data-hovercard-type="user" data-hover

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

safe way to do then(component) about flowerflip HOT 5 CLOSED

d4tocchini commented on July 27, 2024

safe way to do then(component)

from flowerflip.

Comments (5)

cbchouinard commented on July 27, 2024

Would this require a kind of deferred object?

from flowerflip.

bergie commented on July 27, 2024

I think it is generally safer to do composites with components. This way you have a more expressive way to tell what you want to happen, e.g. maybe, some, all

from flowerflip.

cbchouinard commented on July 27, 2024

I agree with @d4tocchini. This could be a way to divide complexe design system and I think we'll have situation where there's only one subtree to execute so its not really a composite.

Furthermore, this a little bit confusing because the following actually works:

   t = Root()
    t.deliver 10
    .then 'then0', (c, d) ->
      d * 2
    .then 'then12', (c, d) ->
        sub = c.continue 'subtree_c'
        sub.deliver d
        sub.then 'subthen0', (c, d) ->
          d / 2
        .then 'subthen1', (c, d) ->
          d * 4
        .else 'subelse', (c, d) ->
          d
    .then 'then1', (c, d) ->
      d * 2
    .else 'else1', (c, d) ->
      d * 4
    .finally (c, d) ->
      chai.expect(d).to.eql 80
      done()

Throwing an error also works.

t = Root()
    t.deliver 10
    .then 'then0', (c, d) ->
      d * 2
    .then 'then12', (c, d) ->
        sub = c.continue 'subtree_c'
        sub.deliver d
        sub.then 'subthen0', (c, d) ->
          d / 2
        .then 'subthen1', (c, d) ->
          throw new Error 'dont feel like doing it'
        .else 'subelse', (c, d) ->
          throw new Error 'me neither'
    .then 'then1', (c, d) ->
      d * 2
    .else 'else1', (c, d) ->
      80
    .finally (c, d) ->
      chai.expect(d).to.eql 80
      done()

Its only when aborting a choice that it gets lost :)

from flowerflip.

d4tocchini commented on July 27, 2024

@bergie, we can run components from a then, the issue is really just a side-effect of abort bubbling too far up, we shouldn't plan our API around that

from flowerflip.

bergie commented on July 27, 2024

Aborts work better now, so closing

from flowerflip.

Recommend Projects