Giter VIP home page Giter VIP logo

carrotshop's Introduction

carrotshop's People

Contributors

johnfriedrich avatar randombyte-developer avatar theokah avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

carrotshop's Issues

Signs cannot read under $1

Hi,

So if I setup a sign with 0.01 the plugin will say it will be $1
I believe its for both sell and buy shop.
Possible to fix it so that people can sell or buy things under 1?

thanks in advance!

Chest security issue

Buyer can open chest to remove items without paying for them, or choose to click the sign to buy

Sign dupe

If you create a shop and get a friend to break the block the shop sign rests on, it will drop a sign and leave the shop sign up. Simply have your friend place another block and break it again and repeat.

Not that serious, but felt worth reporting. Maybe have the shop plugin protect both the sign & block it rests on

Carrot Shop report provides nothing...

spongeforge-1.12.2-2705-7.1.0-BETA-3417
CarrotShop-1.17-S7.0-MC1.12.2
FoolCraft 3 modpack

Upon trying to run /carrotshop report it shows nothing but this error in the console:

17:06:48 [Error] [carrotshop]: ERROR: Server returned HTTP response code: 400 for URL: https://carrotshop-ffb97.firebaseio.com/shop.json.
17:06:48 [Error] [carrotshop]: Bad Request.

Also with /carrotshop serverreport:

17:07:50 [Error] [carrotshop]: ERROR: Server returned HTTP response code: 400 for URL: https://carrotshop-ffb97.firebaseio.com/shop.json.
17:07:50 [Error] [carrotshop]: Bad Request.

Thank you

Where is stored information of chest?

Hi, I had a little problem with my server and my mods. An update of aether mod and orbis API affect somethings I do a /fml confirm. But, since I did this, the shops of my players don't works. So where is stored the files of the list of shops? I whould copy this file of my backup.

Thank you!

Configurable prefix in front of all messages

To make it easier for players to determine from what Plugin/Feature a message comes from, I suggest to add a prefix defined in language config in front of all messages.
I could default to "" but admins could set it to "Shop: " or similiar

[Bug with GP] On player sold blocks

as we know, GriefPrevention has a protection to prevent strangers build block in a personal claim, that appears if a stranger place a block, GP cancel it and return the block to him.

The bug is if the customer doesn't have claims permission to place blocks when he sell block with shifting mode(sneak), the sold block action (right interact the sign) would be regard as place event by GP, so GP prevent placing event and give block back to the customer while doesn't cancel the sell event. so customer will earn money by none block paid.

Startup Crash

spongeforge-1.12.2-2705-7.1.0-BETA-3374
CarrotShop-1.17-S7.0-MC1.12.2
forge-1.12.2-14.23.4.2738-universal

I sometimes get this crash on startup, it does not always happen so it is difficult to reproduce.

---- Minecraft Crash Report ----

WARNING: coremods are present:
  SpongeCoremod (spongeforge-1.12.2-2705-7.1.0-BETA-3374.jar)
Contact their authors BEFORE contacting forge

// Sorry :(

Time: 8/5/18 11:03 PM
Description: Watching Server

java.lang.Error: ServerHangWatchdog detected that a single server tick took 60.00 seconds (should be max 0.05)
	at org.spongepowered.common.event.tracking.phase.tick.TickPhase$Tick.<clinit>(TickPhase.java:39)
	at net.minecraft.world.WorldServer.func_180495_p(WorldServer.java:3310)
	at net.minecraft.tileentity.TileEntity.func_70296_d(TileEntity.java:157)
	at org.spongepowered.common.data.processor.data.tileentity.TileEntitySignDataProcessor.set(TileEntitySignDataProcessor.java:81)
	at org.spongepowered.common.data.processor.data.tileentity.TileEntitySignDataProcessor.set(TileEntitySignDataProcessor.java:54)
	at org.spongepowered.common.data.processor.common.AbstractSingleDataSingleTargetProcessor.set(AbstractSingleDataSingleTargetProcessor.java:88)
	at org.spongepowered.common.data.util.DataProcessorDelegate.set(DataProcessorDelegate.java:179)
	at net.minecraft.tileentity.TileEntity.offer(TileEntity.java:768)
	at net.minecraft.tileentity.TileEntity.offer(TileEntity.java:644)
	at org.spongepowered.api.data.value.mutable.CompositeValueStore.offer(CompositeValueStore.java:228)
	at com.carrot.carrotshop.shop.Shop.setFirstLineColor(Shop.java:192)
	at com.carrot.carrotshop.shop.Shop.setOK(Shop.java:111)
	at com.carrot.carrotshop.shop.Shop.update(Shop.java:67)
	at com.carrot.carrotshop.ShopsData.pushShop(ShopsData.java:188)
	at com.carrot.carrotshop.ShopsData.load(ShopsData.java:85)
	at com.carrot.carrotshop.CarrotShop.onStart(CarrotShop.java:73)
	at org.spongepowered.common.event.listener.GameStartedServerEventListener_CarrotShop_onStart15.handle(Unknown Source)
	at org.spongepowered.common.event.RegisteredListener.handle(RegisteredListener.java:95)
	at org.spongepowered.mod.event.SpongeModEventManager.post(SpongeModEventManager.java:383)
	at org.spongepowered.mod.event.SpongeModEventManager.extendedPost(SpongeModEventManager.java:443)
	at org.spongepowered.mod.event.SpongeModEventManager.post(SpongeModEventManager.java:404)
	at org.spongepowered.common.SpongeImpl.postEvent(SpongeImpl.java:231)
	at org.spongepowered.mod.SpongeMod.onStateEvent(SpongeMod.java:271)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:91)
	at com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:150)
	at com.google.common.eventbus.Subscriber$1.run(Subscriber.java:76)
	at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:399)
	at com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:71)
	at com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:116)
	at com.google.common.eventbus.EventBus.post(EventBus.java:217)
	at net.minecraftforge.fml.common.LoadController.sendEventToModContainer(LoadController.java:218)
	at net.minecraftforge.fml.common.LoadController.propogateStateMessage(LoadController.java:196)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:91)
	at com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:150)
	at com.google.common.eventbus.Subscriber$1.run(Subscriber.java:76)
	at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:399)
	at com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:71)
	at com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:116)
	at com.google.common.eventbus.EventBus.post(EventBus.java:217)
	at net.minecraftforge.fml.common.LoadController.redirect$onPost$zza000(LoadController.java:560)
	at net.minecraftforge.fml.common.LoadController.distributeStateMessage(LoadController.java:135)
	at net.minecraftforge.fml.common.Loader.serverStarted(Loader.java:807)
	at net.minecraftforge.fml.common.FMLCommonHandler.handleServerStarted(FMLCommonHandler.java:301)
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:488)
	at java.lang.Thread.run(Thread.java:748)


A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Thread: Server Watchdog
Stacktrace:
	at org.spongepowered.common.event.tracking.phase.tick.TickPhase$Tick.<clinit>(TickPhase.java:39)
	at net.minecraft.world.WorldServer.func_180495_p(WorldServer.java:3310)
	at net.minecraft.tileentity.TileEntity.func_70296_d(TileEntity.java:157)
	at org.spongepowered.common.data.processor.data.tileentity.TileEntitySignDataProcessor.set(TileEntitySignDataProcessor.java:81)
	at org.spongepowered.common.data.processor.data.tileentity.TileEntitySignDataProcessor.set(TileEntitySignDataProcessor.java:54)
	at org.spongepowered.common.data.processor.common.AbstractSingleDataSingleTargetProcessor.set(AbstractSingleDataSingleTargetProcessor.java:88)
	at org.spongepowered.common.data.util.DataProcessorDelegate.set(DataProcessorDelegate.java:179)
	at net.minecraft.tileentity.TileEntity.offer(TileEntity.java:768)
	at net.minecraft.tileentity.TileEntity.offer(TileEntity.java:644)
	at org.spongepowered.api.data.value.mutable.CompositeValueStore.offer(CompositeValueStore.java:228)
	at com.carrot.carrotshop.shop.Shop.setFirstLineColor(Shop.java:192)
	at com.carrot.carrotshop.shop.Shop.setOK(Shop.java:111)
	at com.carrot.carrotshop.shop.Shop.update(Shop.java:67)
	at com.carrot.carrotshop.ShopsData.pushShop(ShopsData.java:188)
	at com.carrot.carrotshop.ShopsData.load(ShopsData.java:85)
	at com.carrot.carrotshop.CarrotShop.onStart(CarrotShop.java:73)
	at org.spongepowered.common.event.listener.GameStartedServerEventListener_CarrotShop_onStart15.handle(Unknown Source)
	at org.spongepowered.common.event.RegisteredListener.handle(RegisteredListener.java:95)
	at org.spongepowered.mod.event.SpongeModEventManager.post(SpongeModEventManager.java:383)
	at org.spongepowered.mod.event.SpongeModEventManager.extendedPost(SpongeModEventManager.java:443)
	at org.spongepowered.mod.event.SpongeModEventManager.post(SpongeModEventManager.java:404)
	at org.spongepowered.common.SpongeImpl.postEvent(SpongeImpl.java:231)
	at org.spongepowered.mod.SpongeMod.onStateEvent(SpongeMod.java:271)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:91)
	at com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:150)
	at com.google.common.eventbus.Subscriber$1.run(Subscriber.java:76)
	at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:399)
	at com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:71)
	at com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:116)
	at com.google.common.eventbus.EventBus.post(EventBus.java:217)
	at net.minecraftforge.fml.common.LoadController.sendEventToModContainer(LoadController.java:218)
	at net.minecraftforge.fml.common.LoadController.propogateStateMessage(LoadController.java:196)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:91)
	at com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:150)
	at com.google.common.eventbus.Subscriber$1.run(Subscriber.java:76)
	at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:399)
	at com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:71)
	at com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:116)
	at com.google.common.eventbus.EventBus.post(EventBus.java:217)
	at net.minecraftforge.fml.common.LoadController.redirect$onPost$zza000(LoadController.java:560)

No on is able to create simple [Buy] shop

On our server no one except those with the * permission are able to make normal [Buy] shops. They can make [Sell] and [Trade] but not [Buy]. I tried giving them the "carrotshop.create.buy" permission but they still can't do it. One of our Admins even gave themselves carrotshop.* and they can create every other shop but not [Buy].

Isell

Hello,

i have the carrot shop plugin and luckyperms and griefprevention

As an admin i can create signs and use all of them. Normal user can use the ibuy sign however they cant use the isell sign. When right clicking on isell nothing happens. Admins are able to isell

IT worked now it doesnt

this plugin did work for me then out of no where when I click on the sign it doesnt give me anything, it says i purchased the item but my balance is the same so is my invatory it didnt give me anything, please help I tryed using diffrent Carrot shop verzions but it still didnt work !please!

[Suggestion] A few things for the Report

First of all, the Report function is freaking AWESOME, I don't use caps often, so you see how much I like it. I have a thing for stats, so this is really starting to tick all the boxes.

But a few suggestions for it (You probably already have plans for these):

  • Page numbers.
  • Totals (Transactions/ total cash/ total items).
  • Symbols instead of words for amounts ($ instead of Dollars, would clear up some space), if applicable of course.
  • Player list (A list of players which bought/ sold items to you).

Also should you be able to click on the details magnifying glasses? Because I can not.

I know you're busy but wanted to leave this here for when you have the time :)

And thanks for remaking SignShops and putting it on steroids, it's like my dream come true xD

  • Alice
    DragonTechMC

Command Access to Buy/Sell?

Love your plugin it's great!
We have a request, we'd really like for players to be able to access the global player shops by player/Items through commands. No need to teleport to player/shops to buy/sell.
f.e. commands like: (added the " cs " for CarrotShop - custom command)

/csbuy clay   (would list in chat; name of seller, amount in stock and price)
/cssell clay  (would list in chat; name of buyer, amount buyer wants and price)
1. Player clicks on the seller/buyer name to buy/sell from.
2. Asks buyer/seller for the amount to buy/sell.
3. Buyer/seller inputs amount in chat and Profit!
/cslist <player>  (would list all items player is selling/buying, amount in stock and price)
Then same process as above to buy/sell.

Would this be something you'd be interested in adding? Makes server management and player interaction simpler, faster and more enjoyable. We'd love to see this added to our servers soon.

Thank you for your great work.

Seller will lost items while buyer does not have enough money!

I found a bug when a seller use a sell shop to sell some items,if the buyer does not have enough money,sellers will lost thier item whitout paid!
check ur codes at sell.java,i think there are mistakes in judgment sequence,look at this:

for (Inventory item : itemsTemplate.slots()) {
			if (item.peek().isPresent()) {
				Optional<ItemStack> template = getTemplate(inv, item.peek().get());
				if (template.isPresent()) {
					itemsName.append(Text.of(TextColors.YELLOW, " ", item.peek().get().getTranslation().get(), " x", item.peek().get().getQuantity()));
					Optional<ItemStack> items = inv.query(template.get()).poll(item.peek().get().getQuantity());
					if (items.isPresent()) {
						invChest.offer(items.get());
					} else {
						return false;
					}
				}
			}
		}

		UniqueAccount sellerAccount = CarrotShop.getEcoService().getOrCreateAccount(player.getUniqueId()).get();
		UniqueAccount buyerAccount = CarrotShop.getEcoService().getOrCreateAccount(getOwner()).get();
		TransactionResult result = buyerAccount.transfer(sellerAccount, CarrotShop.getEcoService().getDefaultCurrency(), BigDecimal.valueOf(price), Cause.source(this).build());
		if (result.getResult() != ResultType.SUCCESS) {
			player.sendMessage(Text.of(TextColors.DARK_RED, "Seller don't have enough money!"));
			return false;
		}


(Copy form github you have relesed:CarrotShop/src/main/java/com/carrot/carrotshop/shop/Sell.java)

is that the seller's money should be checked before have the items operation?

Unable to setup iTrade sign

Hi,

I'm trying to setup an iTrade sign, I'm following these steps:

  1. Place down 2 chests
  2. Put contents to trade for and get in their respective chest
  3. Put a sign that hast [iTrade] on line 1
  4. Punch both chests with redstone, then the sign
  5. Get an error saying that iTrade signs require 2 chests.

Am I doing this wrong? I looked on the wiki and it said nothing specifically about Trade signs, so not sure how to proceed.

Ability to list all items for sale

Hello, i think it would be a neat idea to be able to run a command that lists all items for sale from a player/area(maybe) or for sale across the entire server?

[Feature] Tax for creating a shop

Hey there!
I was just wondering, if there could be an option to set a "tax" for new created shops (or just tax for every pairing via Redstone).

Buy Option Not working API 7

Hi I am Using this Plugin with
Total Economy 1.7.1

I set up the shops properly but when someone tries to buy something it just asks them if they want to buy it but wont actually let them.

Selling seems to work fine but Buying is currently my issues, am I doing something wrong?

Also Is there a way you can add instructions on the actual help command and not just a link to the wiki..

Dynamic iBuy/iSell Scaling

You would need to track purchase rate/time(m,h,d) to get a base value to work on scaling prices on iBuy/iSell signs dynamically.

The higher the purchase rate an hour(10/hour) each 1 increment value equals a configurable percentage the sign price will either decrease (-10/hour or increase (10/hour) from their previous value.

This would be a advanced feature but opens the door to so many new market strategies for player shops working against Admin Shop pricing.

Shop can't handle stacks correctly

If you set up a shop where people can buy 5 stones for 1 dollar and the shop does not have stacks of 5 stones it says the shop is empty. So this means the shop has been set that people can buy 5 stones for 1 dollar and the shop has multiple stacks of 64 stones and someone wants to buy it, the shop will tell you it is empty (because it does not have a stack of 5 stones). The same thing happens for a shop where you can sell things.

Can't buy stuff.

Hello, I just got sponge and this plugin along with a few others. When I click on the sign it pops up 'Would you like to buy' but I'm not sure how to actually purchase things?
PS: This could possibly be because I am having issues with my economy plugin currently.
shopissue

"bad price"

When setting up a iBuy or iSell sign once I punch the sign with redstone it responds in chat with a red message saying "bad price". I've tried multiple ways of setting the price "7" "$7" "$7 each" ect, is there something i'm doing wrong? I'm currently using the economy plugin TotalEconomy.

Also I noticed one question on the plugin was what happened to the tutorial pictures, It would really help a lot to have a step by step guide of pictures.

[Sponge]: Could not pass InteractBlockEvent$Secondary$MainHand$Impl to Plugin{id=carrotshop, name=CarrotShop, version=1.15

09.11 23:06:26 [Server] Server thread/ERROR [Sponge]: Could not pass InteractBlockEvent$Secondary$MainHand$Impl to Plugin{id=carrotshop, name=CarrotShop, version=1.15, description=A SignShop-like shop plugin for Sponge, url=https://github.com/TheoKah/CarrotShop, authors=[Carrot], source=/mods/CarrotShop-1.15.jar}
09.11 23:06:26 [Server] INFO java.lang.NoSuchMethodError: org.spongepowered.api.event.cause.Cause.source(Ljava/lang/Object;)Lorg/spongepowered/api/event/cause/Cause$Builder;
09.11 23:06:26 [Server] INFO at com.carrot.carrotshop.shop.Buy.trigger(Buy.java:122) ~[Buy.class:?]
09.11 23:06:26 [Server] INFO at com.carrot.carrotshop.listener.PlayerClickListener.lambda$onPlayerRightClick$1(PlayerClickListener.java:39) ~[PlayerClickListener.class:?]
09.11 23:06:26 [Server] INFO at java.util.ArrayList.forEach(ArrayList.java:1249) ~[?:1.8.0_111]
09.11 23:06:26 [Server] INFO at com.carrot.carrotshop.listener.PlayerClickListener.onPlayerRightClick(PlayerClickListener.java:37) ~[PlayerClickListener.class:?]
09.11 23:06:26 [Server] INFO at org.spongepowered.common.event.listener.MainHandListener_PlayerClickListener_onPlayerRightClick18.handle(Unknown Source) ~[?:?]
09.11 23:06:26 [Server] INFO at org.spongepowered.common.event.RegisteredListener.handle(RegisteredListener.java:95) ~[RegisteredListener.class:1.12.2-2529-7.0.0-BETA-2730]
09.11 23:06:26 [Server] INFO at org.spongepowered.mod.event.SpongeModEventManager.post(SpongeModEventManager.java:316) [SpongeModEventManager.class:1.12.2-2529-7.0.0-BETA-2730]
09.11 23:06:26 [Server] INFO at org.spongepowered.mod.event.SpongeModEventManager.post(SpongeModEventManager.java:282) [SpongeModEventManager.class:1.12.2-2529-7.0.0-BETA-2730]
09.11 23:06:26 [Server] INFO at org.spongepowered.mod.event.SpongeModEventManager.post(SpongeModEventManager.java:345) [SpongeModEventManager.class:1.12.2-2529-7.0.0-BETA-2730]
09.11 23:06:26 [Server] INFO at org.spongepowered.mod.event.SpongeModEventManager.post(SpongeModEventManager.java:333) [SpongeModEventManager.class:1.12.2-2529-7.0.0-BETA-2730]
09.11 23:06:26 [Server] INFO at org.spongepowered.common.SpongeImpl.postEvent(SpongeImpl.java:198) [SpongeImpl.class:1.12.2-2529-7.0.0-BETA-2730]
09.11 23:06:26 [Server] INFO at org.spongepowered.common.event.SpongeCommonEventFactory.callInteractBlockEventSecondary(SpongeCommonEventFactory.java:602) [SpongeCommonEventFactory.class:1.12.2-2529-7.0.0-BETA-2730]
09.11 23:06:26 [Server] INFO at org.spongepowered.common.event.SpongeCommonEventFactory.callInteractBlockEventSecondary(SpongeCommonEventFactory.java:581) [SpongeCommonEventFactory.class:1.12.2-2529-7.0.0-BETA-2730]
09.11 23:06:26 [Server] INFO at net.minecraft.server.management.PlayerInteractionManager.func_187251_a(PlayerInteractionManager.java:1183) [or.class:?]
09.11 23:06:26 [Server] INFO at net.minecraft.network.NetHandlerPlayServer.redirect$onProcessRightClickBlock$zhk000(NetHandlerPlayServer.java:2376) [pa.class:?]
09.11 23:06:26 [Server] INFO at net.minecraft.network.NetHandlerPlayServer.func_184337_a(NetHandlerPlayServer.java:739) [pa.class:?]
09.11 23:06:26 [Server] INFO at net.minecraft.network.play.client.CPacketPlayerTryUseItemOnBlock.func_148833_a(SourceFile:55) [ma.class:?]
09.11 23:06:26 [Server] INFO at net.minecraft.network.play.client.CPacketPlayerTryUseItemOnBlock.func_148833_a(SourceFile:11) [ma.class:?]
09.11 23:06:26 [Server] INFO at org.spongepowered.common.network.PacketUtil.onProcessPacket(PacketUtil.java:151) [PacketUtil.class:1.12.2-2529-7.0.0-BETA-2730]
09.11 23:06:26 [Server] INFO at net.minecraft.network.PacketThreadUtil$1.redirect$onProcessPacket$zkd000(SourceFile:539) [hv$1.class:?]
09.11 23:06:26 [Server] INFO at net.minecraft.network.PacketThreadUtil$1.run(SourceFile:13) [hv$1.class:?]
09.11 23:06:26 [Server] INFO at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_111]
09.11 23:06:26 [Server] INFO at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_111]
09.11 23:06:26 [Server] INFO at net.minecraft.util.Util.func_181617_a(SourceFile:46) [h.class:?]
09.11 23:06:26 [Server] INFO at org.spongepowered.common.SpongeImplHooks.onUtilRunTask(SpongeImplHooks.java:272) [SpongeImplHooks.class:1.12.2-2529-7.0.0-BETA-2730]
09.11 23:06:26 [Server] INFO at net.minecraft.server.MinecraftServer.redirect$onRun$zif000(MinecraftServer.java:4003) [MinecraftServer.class:?]
09.11 23:06:26 [Server] INFO at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:721) [MinecraftServer.class:?]
09.11 23:06:26 [Server] INFO at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:396) [nz.class:?]
09.11 23:06:26 [Server] INFO at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:666) [MinecraftServer.class:?]
09.11 23:06:26 [Server] INFO at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:524) [MinecraftServer.class:?]
09.11 23:06:26 [Server] INFO at java.lang.Thread.run(Thread.java:745) [?:1.8.0_111]

Offhand infinite money glitch

players are able to "sell" without losing the item they are holding on the off-hand.
Place Diamond on the off hand, keep right click the sign and sign will pay you money even if the diamond on the off hand will not get consumed.

1.6 is great but flaw with design...

So you have added and fixed all the issues so far.. It wasn't until I added it that I realized people can steal from anyone. I have a world called shops, this is where the perms say they can make the shops. any player can go here and place a buy sign with a purchase price of 1 dollar (on the fourth line) then go to any world and select anyone's chest even if it is on a grief prevention claim then tp back to the sign and steal everything from the chest for 1 dollar. Can you make it so the chest must be placed by the same person that made the sign or so that the chest must be within X amount of blocks of the sign in the same world, or even the chest must be below the wall sign?

Shop Signs reset with every reboot

I recently moved my shop to a new world and I am able to create sign shops in the world but as soon as the server restarts all signs in that world just reset.

Carrotshop Version: CarrotShop-1.17-S7.0-MC1.12.2
Sponge Version: spongeforge-1.12.2-2611-7.1.0-BETA-2931
Error log: https://pastebin.com/JnqbygdD

Note: Signs still function in other worlds on the same server

ignore item lore or name issues

when i sell or buy a item
i want use itemname or lore to to the difference goods
but plugin only Use itemtype to the difference between goods
can u support that feature?

[Request] Mod Chests

I was hoping you might be able to add compatibility for Quark and Iron Chests.

Quark chests have OreDict but Iron Chests don't.

Item Registry + Ore Dict Names
Quark's Chests
quark:custom_chest(:0-8)
ore:chestWood
ore:chest

Iron Chests
ironchest:BlockIronChest(:0-8)

It's okay if it's not possible or too hard, but would be a good addition.

iSell Problem

I don't know if it's just me or not but I don't see anywhere anything about a permission node to be able to sell to this type of shop. Is this just me being stupid or is this a problem with the plugin? I can sell just fine when I have full permissions to every plugin but when I go to the default rank to test it I can no longer sell the items.

Taxes

Tax system on shops would be awesome and the ability to funnel the tax money into a eco account.

Reports for others.

I have the permissions set for it but I can't figure out how to make reports for others and i don't see anything on the wiki for the command, just the permission. I'm using CarrotShop-1.15-S7.0-MC1.12.2

Not working after restart.

I just filled a shop with your sign plugin, taking an hour of work, and I restart the server, and moded items do not working anymore. We tested everything and it all worked beforehand.

What do I do?

Thanks,

ManningSquared.

once translated into German^^

                                              German
                                         language.conf

"CMD_CONFIG_CURRENCY"="Standart Währung ist %name% (%id)"
"CMD_CONFIG_RELOAD"="Config neu geladen"
"CMD_CONFIG_RELOAD_FILE"="Konnte die Konfigurationsdatei nicht laden oder erstellen"
"CMD_IMPORT_ADMINSHOP_ERROR_FILE"="Die AdminShop Shop-Datendatei kann nicht gefunden oder geöffnet werden"
"CMD_IMPORT_ADMINSHOP_ERROR_LOAD"="Fehler beim Laden der AdminShop Shop-Datendatei"
"CMD_IMPORT_ADMINSHOP_ERROR_LOAD_ITEM"="Fehler beim Laden des AdminShop-Shop-Datenelements"
"CMD_IMPORT_USAGE"="Sie benötigen einen der folgenden Parameter:"
"CMD_SPAM"="Shop-Nutzungsbericht: %status%"
"CONSOLE_ERROR_GENERIC"="Fehler: %error%"
"CONSOLE_ERROR_LOAD"="Beim Laden von CarrotShops sind Fehler aufgetreten"
"CONSOLE_ERROR_LOGS"="Speichern von Protokollen für den Shop %owner% nicht möglich, ausgelöst durch %source%: %error%"
"CONSOLE_ERROR_PLAYER"="Muss ein Spieler sein"
"CURRENCY_SERVER"="Shop-Währung entsprechend der Serverkonfiguration"
"CURRENCY_VALUE"="Shopwährung eingestellt auf %name%"
"HELP_DESC_CMD_CONFIG"="Change or reload config of the plugin"
"HELP_DESC_CMD_CONFIG_CURRENCY"="Get/Set the default currency"
"HELP_DESC_CMD_CONFIG_RELOAD"="Reload the language file"
"HELP_DESC_CMD_IMPORT"="Import shop data from another plugin"
"HELP_DESC_CMD_MAIN"="Hauptbefehl CarrotShop"
"HELP_DESC_CMD_OREPORT"="Generiert einen CarrotShop-Bericht für einen anderen Spieler"
"HELP_DESC_CMD_REPORT"="Generiert einen CarrotShop-Bericht"
"HELP_DESC_CMD_SPAM"="Shopnachricht umschalten, wenn jemand Ihren Shop verwendet"
"HELP_DESC_CMD_SREPORT"="Generiert einen CarrotShop-Bericht für iSigns"
"HELP_DESC_CMD_WIKI"="Zeigt einen Link zum Shop-Wiki an"
"HELP_HEADER_CMD_CONFIG"="/carrotshop config"
"HELP_HEADER_CMD_MAIN"="/carrotshop"
"LOCATION_REMOVED"="Standort des Elements entfernt"
"LOCATION_STORED"="Speicherort des Artikels"
"PRICE_DEFAULT"="%value% %currencyFullPlural%"
"PRICE_ONE"="%value% %currencyFull%"
"PRICE_TRANSLATION_HINTS"="Akzeptierte Platzhalter für PRICE_*: %value% %currencyFull% %currencyFullPlural% %currencySymbol%"
"PRICE_ZERO"=nothing
"REPORT_ERROR_DATA"="Es wurden keine Daten zum Generieren eines Berichts gefunden"
"REPORT_ERROR_OPERM"="Sie haben keine Berechtigung, Berichte für andere Spieler zu erstellen"
"REPORT_ERROR_PERM"="Sie haben keine Berechtigung zum Erstellen von Berichten"
"REPORT_PREPARE"="Der Bericht wird vorbereitet ..."
"REPORT_READY"="Bericht ist fertig: %url%"
"SHOP_BANK"="Dein Kontostand: %bank%"
"SHOP_BANK_HELP"="Klicken Sie mit der rechten Maustaste, um Ihr Guthaben zu sehen"
"SHOP_CHEST"="%type% Schild erfordert eine Truhe"
"SHOP_CHEST2"="%type% Schild erfordert zwei Truhe"
"SHOP_CHEST_EMPTY"="Truhe kann nicht leer sein"
"SHOP_COST"="Sie haben nicht genug Geld, um den Shop zu erstellen. Ein %type% Shop kostet %cost%"
"SHOP_CURRENCY"="Dieses Schild verwendet die Standardwährung: %name%"
"SHOP_CURRENCY_LOOP"="Klicken Sie mit der linken Maustaste auf das Schild, um eine andere Währung zu verwenden"
"SHOP_DEVICEOFF"="Gerät deaktiviert für %price%"
"SHOP_DEVICEOFF_HELP"="Deaktivieren für %price%?"
"SHOP_DEVICEOFF_HELP_NOECON"="Deaktivieren?"
"SHOP_DEVICEOFF_NOECON"="Gerät deaktiviert"
"SHOP_DEVICEON"="Gerät aktiviert für %price%"
"SHOP_DEVICEON_HELP"="aktivieren für %price%?"
"SHOP_DEVICEON_HELP_NOECON"="Aktivieren?"
"SHOP_DEVICEON_NOECON"="Gerät aktiviert"
"SHOP_DEVICE_OTHER"="%player% benutzt dein [%type%] Zeichen für %price%"
"SHOP_DEVICE_OTHER_NOECON"="%player% benutzt dein [%type%] Zeichen"
"SHOP_DEVICE_OTHER_TAX"="%player% benutzt dein [%type%] Zeichen für %price%. Mit %tax%% tax bekommst du %tprice%"
"SHOP_DONE"="Sie haben ein Shop [%type%] eingerichtet:"
"SHOP_DONE_COST"="Sie haben ein Shop [%type%] eingerichtet für %cost%:"
"SHOP_EMPTY"="Dieser Shop ist leer!"
"SHOP_EMPTYHAND"="Sie dürfen nur Geschäfte mit leeren Händen verwenden"
"SHOP_ERROR_MONEY"="Kann Ihnen das Geld nicht geben!"
"SHOP_FORMAT_BUY"="Kaufe %items% für %price%?"
"SHOP_FORMAT_SELL"="Verkaufe %items% für %price%?"
"SHOP_FORMAT_TRADE"="Tausche %items% und bekomme %items%?"
"SHOP_FULL"="Dieser Shop ist voll!"
"SHOP_HEAL"="Du hast für %price% geheilt"
"SHOP_HEAL_HELP"="Heilen für %price%?"
"SHOP_HEAL_HELP_NOECON"="Heilen?"
"SHOP_HEAL_NOECON"="Geheilt"
"SHOP_ITEMS"="Sie haben die Artikel nicht!"
"SHOP_LEVER"="%type% Schilder erfordern einen Hebel"
"SHOP_MONEY"="Sie haben nicht genug Geld!"
"SHOP_OMONEY"="Ladenbesitzer hat nicht genug Geld!"
"SHOP_OVERRIDE"="Dieser Shop würde einen Shop überschreiben, den Sie nicht besitzen. Abbrechen."
"SHOP_PERM"="Du hast keine Perms, um eine [%type%] Shop zu bauen"
"SHOP_PRICE"="falscher Preis"
"SHOP_RECAP_BUY"="Du kauftest %items% für %price%"
"SHOP_RECAP_OBUY"="%player% kaufte %items% für %price% von dir"
"SHOP_RECAP_OBUY_TAX"="%player% kaufte %items% für %price% von dir. Mit %tax%% tax bekommst du %tprice%"
"SHOP_RECAP_OSELL"="%player% verkaufte %items% für %price% an dich"
"SHOP_RECAP_OSELL_TAX"="%player% verkaufte %items% für %price% an dich. Mit %tax%% tax bekommst du %tprice%"
"SHOP_RECAP_OTRADE"="%player% tauschte %items% für %items%"
"SHOP_RECAP_SELL"="Du hast %items% verkauft für %price%"
"SHOP_RECAP_TRADE"="Du hast %items% getauscht gegen %items%"
"SHOP_SCHRODINGER"="Dieser Shop ist entweder voll oder leer!"
"SHOP_TOGGLE"="Das Gerät wurde 2 Sekunden lang umgeschaltet %price%"
"SHOP_TOGGLE_HELP"="Umschalten für %price%?"
"SHOP_TOGGLE_HELP_NOECON"="Umschalten?"
"SHOP_TOGGLE_NOECON"="Gerät wurde 2 Sekunden lang umgeschaltet"
"SHOP_USED"="Jemand hat in Ihrer Abwesenheit Ihre Geschäftsschilder benutzt. Benutz %cmd% für mehr Informationen"
"STATUS_OFF"=OFF
"STATUS_ON"=ON
"WIKI_LINK"="Link zum Wiki: %url%"
"WIKI_URL"="https://github.com/TheoKah/CarrotShop/wiki/User-Guide"

Option to make shops without chests

As the title says, I was wondering if it would be possible to have admin sign shops where no chest is needed? If it's a feature already I can't seem to find it.
Thanks for reading

Shop doesn't differentiate between item ID 5:0 and 5:1

You can do this for all items that have a sub ID. stone (id: 1:0) and andesite (id: 1:6), either can be sold to a shop that was created with only one of those. Same with potions and enchanted books and every other item that has a sub ID. The items stay different in the chest. I could sell eff 1 enchanted book to a shop that is buying silk touch books. If i did this and opened the chest I would see 2 different books, 1 eff 1 and 1 silk.

I'm using Sponge Vanilla API 5 build 385, and total economy and a bunch more but I don't think those affect this.

Upcoming Signs

I plan to add a lot of signs to SignShop. Feel free to comment and suggest things

TODO:

  • DeviceOn: linked to a lever to turn it on
  • DeviceOff: linked to a lever to turn it off
  • Toggle: linked to a lever to turn in on, then off a few seconds later
  • Bank: display balance
  • Heal: Heal the player at a cost
  • Command: execute a command on the server

Others can open CarrotShop chests

Others can open and close my CarrotShop chests, as well as insert and remove items from them (But they still cannot break the sign.)

I'm on SpongeForge 1.12-2443-7.0.0-BETA-2498. I've tested this with only Forge, Sponge and CarrotShop 1.9 loaded.

Cannot remove sign

I have created server shop sign [iBuy] and i want to remove it but its going away.
removed with gun powder or worldedit make it visually gone but if I place sign or block where it was, it is still there. trying to break block will say dirt for 1 coin? and block will not break unless gunpowder or worldedit. server did restart but its still there.
edit: gunpowder was from voxel i think?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.