trinitycore / minimanager Goto Github PK

IE:
level = 80
and
has item id = 1000

it sends you to the same page.

On PHP8,PHP8.1, the post gets made, but throws an exception in forum_do_add_topic()

 POST /forum.php?action=do_add_topic - Uncaught TypeError: mysqli_free_result(): Argument #1 ($result) must be of type mysqli_result, bool given in ~minimanager/libs/db_lib/mysqli.php:121
Stack trace:
#0 ~minimanager/libs/db_lib/mysqli.php(121): mysqli_free_result()
#1 ~minimanager/forum.php(851): SQL->close()
#2 ~minimanager/forum.php(1190): forum_do_add_topic()

Slew of things to do here, so going to start with a naive list of the files in classic MM since they are separated out by their functionality. We can clean it up later as things get done.

Ordered alphabetically and not by priority.

Basic functionality

• ahstats
• backup
• char_achieve
• char_edit
• char_extra
• char_list
• char_mail
• char_pets
• char_rep
• char_spell
• char_talent
• command
• creature
• edit
• error
• events
• game_object
• guildbank
• honor
• index - landing page / quick view stats
• instances
• IP2Location??
• IRC ? Discord ?
• mail_on
• map
• message
• motd
• register
• run_patch
• spelld
• tele
• ticket
• user

Bonus functionality

• Themes - Malachite
• Themes - RGB
• Themes - Sulfure
• Themes - Universe

Language translations

• english
• german

Bonus translations... need volunteers later

• outdated/croatian
• outdated/czech
• outdated/french
• outdated/italian
• outdated/mandarin
• outdated/norwegian
• outdated/persian
• outdated/portuguese
• outdated/russian
• outdated/spanish
• outdated/turkish

IE:

1. Spell disabled for players

2. Spell disabled for creatures

3. Spell disabled for players
   Spell disabled for creatures

4. Spell disabled for pets

https://trinitycore.atlassian.net/wiki/spaces/tc/pages/2130172/disables

browse join / leave guild logs
also guild bank logs.

the 1st on left arrow the 2nd on 2nd arrow.

https://i.imgur.com/4CSneMb.png

IE:

"Gm level"
"failed login"
"by online"

on 1st column
<=> on 2nd column

Also add "Characters" (on account)

that.

• Show gold when searching by 'Has gold'

go 2nd or consecutive pages, you will find empty listing.

it only shows part of them, maybe wow 2.4.3 thing
also, allow to show dual talents.

allow to zoom map
allow to fill browser window

on the accounts list, add ip of the account.
on the ip list the afected accounts.
show country of ip.

imho those must be hidden.

since item level cut of retail 3.3.5a itemlevels are show incorrectly because we use wowhead

ie < 2
(< needs to be renamed to >)

Unable to login or create new accounts since recent update.

In 288669f some new SQL updates were added.

SQL/update/2020_08_11_mmfpm_changes.sql - I applied it to database.

When I try to log in now I get stuck on the following:

I assume when I ran the update it of course deleted my mm_account table so cant login.

So now I try to create a new one. Cant create same one as before because it says "already exists". Creating a new one gets stuck on (After accepting Terms of service):

Otherwise the site appears normal and updates up time, players, etc fine - just cant login or create account.

I've uninstalled and reinstalled a couple of times but it hasn't changed anything.

Anyone else experienced this?

https://i.imgur.com/HaXidVP.png

vs

https://i.imgur.com/gXW3ykK.png

TrinityCore/WoWSimpleRegistration@b800347

Cant Login to the Website after Trinitycore kick out the SHA Pass.

Its a new one now and it would be nice when you can fix it :)

"Core/Authserver: Removal of sha_pass_hash, compatibility fields, and ……everything that uses them"

how about allow sort accounts / characters by country

that.
https://gist.github.com/Aokromes/11948fd14a0d7f6bb646702fa7483630

TrinityCore/TrinityCore@8e0365d

that.

https://i.imgur.com/WHSpiJv.png

simply that xd

the same has browse characters but limited to guild

maybe here https://i.imgur.com/MozETD2.png

by characters and by guilds

This column does not appear in the base tables for TrinityCore at least as of 73121770

Project should probably include proper migrations to handle any external database requirements, or move toward making no modifications to the server databases (auth, world, character)

add account and ip of sender
allow to search other accounts on same ip

add guild name on the list of characters
add witch of the character is online

here
https://i.imgur.com/WQgkP72.png

that.

The Site Top100 shows Pages but no Chars, last checkout.
See: https://ogrimmar.mooo.com/top100.PNG

• Looks like there's a redirect loop happening
• fixing the redirect loop still doesn't fix other elements of the map like uptime, player location, etc

if you go to the inventory of one char and click on account you get "No Value Passed" and returned to accounts list.

This should probably just be an error page, since it's unlikely the user needs to log into a different account. More than anything it just gives the impression that user isn't actually logged in.

If it's absolutely necessary to be able to log into a potentially more privileged account, maybe provide a link to logout / log back in with a different account instead. But providing the form isn't an ideal user experience.

https://gist.github.com/Aokromes/f5f8d1cc028d03dc7b97d993d737b53b

allow to search items by:

min / max use level like on client.
min / max item level.
type (armor, weapon, consumable, etc).
quality.
allow to search include multiple of the things before.

Querying for guild name accounts for at 1 additional query per character listed. Another query "to disalow lower lvl gm to view accounts of other gms" accounts for an additional query per character, making a total of 75+ queries for a list of 25. At scale, that's 300 queries on a page of 100, 600 queries on a page of 200, etc.

The cause is that these queries are being executed inside the for loop building the rows for each character. So the initial query should probably be improved / data eager loaded to include the additional data via join.

This should significantly improve the overall performance of that particular page, especially in cases where someone sets pagination limits to 100+.

by partial name or by id.

I have no mmftc database,how can i donwload?
I use a trinitycore someone compileed ，I can't compile the service! so there was no database for minimanager, who can tell me where is it,where can download?

how about allow search accounts by country?

ie < 70

atm when you check emails of some character if one email contains multiple items are show separate, maybe a drop down can be added in case email contains multiple items.

Aokromes's idea:

• Add an option to search abandoned/completed quest in quest_tracker table

maybe a drop down can be added on the right side of char_quest to show on what part of the quest chain one character is.

https://i.imgur.com/gpPpa7K.png

add guild name on it
add if a friend is mutual friend.

that.
somewhere at char.php?id=1

this.

Probably need to gracefully handle security-agnostic URL prefix, since it's unlikely someone is going to go to the trouble of securing their local vhost, even with a self-signed cert.

since ip2nation is abandoned we need to replace it to another, i sugest to use ip2location, it comes with free version for country.