Giter VIP home page Giter VIP logo

mack's Issues

Nested bulleted lists are not rendered to blocks

  • Given
markdownToBlocks(`
- asdf
  - asdf2`)
  • Actual
Array [
  Object {
    "text": Object {
      "text": "โ€ข asdf",
      "type": "mrkdwn",
    },
    "type": "section",
  },
]
  • Expected
Array [
  Object {
    "text": Object {
      "text": "โ€ข asdf
    โ€ข asdf2",
      "type": "mrkdwn",
    },
    "type": "section",
  },
]

is this still work?

I tested this package with examples,
But an error occured as below.

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'lexer')
    at markdownToBlocks (index.ts:27:1)
export async function markdownToBlocks(
  body: string,
  options: ParsingOptions = {}
): Promise<KnownBlock[]> {
  const tokens = marked.lexer(body); // error line

  return parseBlocks(tokens, options);
}

Blockquote

I tried using the package in my component which uses React Quill. I am converting the HTML to markdown in my code to be passed down to this package. Generate markdown seems to be correct..
Among the formats /toolbar that i am using, only the blockquote for single line doesn't work. Rest of things work nicely!

function parseBlockquote(element: marked.Tokens.Blockquote): KnownBlock[] { return element.tokens .filter( (child): child is marked.Tokens.Paragraph => child.type === 'paragraph' ) .flatMap(p => parseParagraph(p).map(block => { if (isSectionBlock(block) && block.text?.text) { block.text.text = block.text.text .split('\n') .map(line => '> ' + line) .join('\n'); } return block; }) ); }

this fix works when i tried to fork the repo but then some other formats like bold/italic/strike fails..
Is it possible to fix the blockquote format in your repo?

Improve markdown lexer pipeline

The current implementation to resolve the raw markdown into a markdown AST is not that efficient currently, since we convert to and from HTML during the process. This can probably be improved so that only one lexing / tokenizing is needed.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.