Comments (7)
LuckyTurtleDev
commented on June 10, 2024
1
@Lukas1818 is that now fixed or are you getting still an crash/error?
No, I did not get a crash anymore.
While I had make the PR, I had already check this.
from unknown-horizons.
LinuxDonald
commented on June 10, 2024
@jmdejong @artism90 could you both look at this and on the Fife Engine pr too please?
from unknown-horizons.
jmdejong
commented on June 10, 2024
I have not yet tried it, but looking at the python documentation it should be safe just to remove this argument from horizons/util/loaders/jsondecoder.py line 40
from unknown-horizons.
LuckyTurtleDev
commented on June 10, 2024
I have not yet tried it, but looking at the python documentation it should be safe just to remove this argument from
horizons/util/loaders/jsondecoder.pyline 40
I tested it and the game start now. But if I start a new single player game, I get a new error now:
$ unknown-horizons
[ALSOFT] (EE) Failed to set real-time priority for thread: Operation not permitted (1)
[ALSOFT] (EE) Failed to set real-time priority for thread: Operation not permitted (1)
Traceback (most recent call last):
File "/usr/lib/python3.9/site-packages/fife/extensions/fife_timer.py", line 125, in updateEvent
self._callback()
File "/usr/lib/python3.9/site-packages/fife/extensions/pychan/tools.py", line 94, in real_callback
callback(*args,**kwargs)
File "/usr/lib/python3.9/site-packages/fife/extensions/pychan/events.py", line 194, in delayed_f
f( event )
File "/usr/lib/python3.9/site-packages/fife/extensions/pychan/events.py", line 374, in captured_f
tools.applyOnlySuitable(self_ref().callbacks[group_name][event_name],event=event,widget=self_ref().widget_ref())
File "/usr/lib/python3.9/site-packages/fife/extensions/pychan/tools.py", line 71, in applyOnlySuitable
return func(*args,**kwargs)
File "/usr/lib/python3.9/site-packages/horizons/gui/modules/singleplayermenu.py", line 119, in act
self._mode.act(player_name, player_color)
File "/usr/lib/python3.9/site-packages/horizons/gui/modules/singleplayermenu.py", line 223, in act
horizons.main.start_singleplayer(options)
File "/usr/lib/python3.9/site-packages/horizons/main.py", line 321, in start_singleplayer
preloader.wait_for_finish()
File "/usr/lib/python3.9/site-packages/horizons/util/preloader.py", line 82, in wait_for_finish
if self.isAlive():
AttributeError: 'PreloadingThread' object has no attribute 'isAlive'
Unknown Horizons exited uncleanly via SIGINT
The isAlive() function is also deprecated and was change to is_alive().
The isAlive() method of threading.Thread has been removed. It was deprecated since Python 3.8. Use is_alive() instead. (Contributed by Dong-hee Na in bpo-37804.)
If I also change this, I can play the game.
from unknown-horizons.
LinuxDonald
commented on June 10, 2024
@jmdejong could you maybe an look on this needed changes and commit them please?
from unknown-horizons.
LinuxDonald
commented on June 10, 2024
@Lukas1818 is that now fixed or are you getting still an crash/error?
from unknown-horizons.
jmdejong
commented on June 10, 2024
I encountered the same error (about the 'encoding' arg) when I tried to run it and that was fixed with the PR
from unknown-horizons.
Related Issues (20)
- Incorrect tobacco-related tooltips HOT 2
- Incorrect weaver's hut tooltip
- Weird size proportion sheep vs cattle HOT 6
- Forum is broken HOT 13
- Can you please release your game in AppImage format? HOT 3
- Removed Package function in setup.py HOT 2
- Put this repository into archive mode
- Game not starting in Ubuntu 18.04 HOT 35
- Crash when selecting only one swordman HOT 6
- pytest_namespace removed from pytest since 4.0
- Mac: black screen when starting game HOT 1
- Can't start HOT 1
- please ignore/delete/close
- Crash On Windows 10 HOT 2
- iniciar o jogo HOT 6
- How to get pyenet for playing multiplayer? HOT 3
- Could not find a matching screen mode for the values given! HOT 1
- ImportError: cannot import name 'fife' from 'fife' HOT 1
- Building with setuptools >= 66 fails with `InvalidVersion` HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from unknown-horizons.