vichargrave / tcpsockets Goto Github PK

Hey,
we just discovered that in the TCPConnector::connect method is an issue with open file descriptors. If there is an error with the attempt to connect, the opened file descriptor is not being closed again. On multiple connection attempts at short time, there will be too many opened file descriptors and the call results in a bad file descriptor error.

Our proposal as a fix would be to exchange the code in line 105 with

if (result == -1) {
    close(sd);
    return NULL;
}

Edit: Of course the same is valid for the TCPConnector::connect method without the timeout parameter

Hi, i want send large file to server (image file 786kb). While i sending file with Java socket, the server (your c++ server) unexpectedly closes. I can send only 4kb. What is the solution for this? Sorry my very very bad English. Thanks...

In TCPConnector::connect() line 122, socket descriptor is not closed leading to resource leak. This issue may be related to #1.