[BUG] GE-Proton7-42 is displayed with the name "." when installed to Steam (Flatpak) about protonplus HOT 46 CLOSED

Would you be able to tell me what's in this directory?
~/.var/app/com.valvesoftware.Steam/.steam/steam/compatibilitytools.d/

from protonplus.

Here you go:

$ ls ~/.var/app/com.valvesoftware.Steam/.steam/steam/compatibilitytools.d/
GE-Proton7-42

from protonplus.

I will try to fix that for v0.3.1, but since I cannot reproduce on a vanilla VM of Fedora 37 and on my machine it may take time.

from protonplus.

I can reproduce this with my protonplus AUR package.

from protonplus.

Is it only doing that with Steam (Flatpak) for both of you?

from protonplus.

@Vysp3r I didn't test the Flatpak. I'm building from source with Meson with my AUR package.

from protonplus.

I meant like does this happen with every launcher or only Steam (Flatpak)

from protonplus.

I have the Manjaro steam package installed, not the Flatpak version.

The Lutris and Lutris DXVK versions are displayed correctly.

from protonplus.

Alright, I'll check that tomorrow.

from protonplus.

I think I may have found the problem, but I'm really not sure. Would you guys be inclined to test it from source on your system since I can't reproduce? I will create a branch just for this issue until you guys says it's resolved.

from protonplus.

Sure.

from protonplus.

If you click on the info button for the tool that shows up as a dot, what path does it returns?

from protonplus.

For Steam (Flatpak) the path is hard coded so there shouldn't be any problem. The normal steam has multiples path possible so that's something else, but other then that it should be working. I thought it could be something with Flatpak permissions, but since @yochananmarqos is building from source and not using Flatpak, it means that's not the problem here.

from protonplus.

Is this what you want:

from protonplus.

Yep, thanks

from protonplus.

So just to make sure, whatever tool you install for Steam it always renames it to a dot?

from protonplus.

I installed Boxtron now as a test and it was named "..":

from protonplus.

Okay, but for you does Lutris and Lutris DXVK works correctly too like @yochananmarqos or not?

from protonplus.

I don't use Lutris, so I'm not sure. Apparently I still have it installed.

from protonplus.

Issue is reproducible with Lutris:

from protonplus.

Okay, so it's more random then I thought since it's working for @yochananmarqos

from protonplus.

I'll take a look into that right now

from protonplus.

I got my application to crash after installing tools multiple times in a row. The naming was weird too after 3 installation. I might be on to something.

from protonplus.

Issue is reproducible with Lutris:

Since you can see other installed tools correctly, I guess it's not the way my program shows the tools that's the problem, but the thing that download and extract a downloaded tool.

from protonplus.

Would you guys be able to install this version and tell me if that version works to install new tools. https://github.com/Vysp3r/ProtonPlus/releases/download/v0.1.9/com.vysp3r.ProtonPlus.flatpak

from protonplus.

It would be nice if you guys could test this possible fix too! LINK TO BRANCH

from protonplus.

Which one should I test? I would also like to note that this bug potentially can result in data loss. I tried removing the "." tool, and this resulted in all tools being removed from the Lutris launcher, not just the one I requested to remove.

from protonplus.

@Vysp3r No, that does not make any difference. Anyway, the issue isn't with tool installation--it's with detection.

Proton GE is not detected at all, no matter if it already exists or if downloaded with this program.

Lutris and Lutris DXVK versions are detected.

The paths are all correct.

GE Proton path:
~/.local/share/Steam/compatibilitytools.d/GE-ProtonX-XX

Lutris WINE path:
~/.local/share/lutris/runners/wine/lutris-X.X-X-x86_64

Lutris DXVK path:
~/.local/share/lutris/runtime/dxvk/vX.XXX

All show as .. no matter what.

from protonplus.

Which one should I test? I would also like to note that this bug potentially can result in data loss. I tried removing the "." tool, and this resulted in all tools being removed from the Lutris launcher, not just the one I requested to remove.

That's normal because it deletes with the tool name. So if the tool name is a dot well it will delete everything since a dot is the current directory. We need to fix that ASAP then to avoid any data loss tho.

from protonplus.

Which one should I test? I would also like to note that this bug potentially can result in data loss. I tried removing the "." tool, and this resulted in all tools being removed from the Lutris launcher, not just the one I requested to remove.

That's normal because it deletes with the tool name. So if the tool name is a dot well it will delete everything since a dot is the current directory

Yeah, I get that. But I don't think it's very good behaviour. Like, say someone deliberately names their tool "." for whatever reason

from protonplus.

Which one should I test? I would also like to note that this bug potentially can result in data loss. I tried removing the "." tool, and this resulted in all tools being removed from the Lutris launcher, not just the one I requested to remove.

That's normal because it deletes with the tool name. So if the tool name is a dot well it will delete everything since a dot is the current directory

Yeah, I get that. But I don't think it's very good behaviour.

I can always add a verification to make sure that if a tool is named dot or a special char like that you cannot delete it. That can be done really easily.

from protonplus.

I added that to my to-do list, I will include that for the next update.

from protonplus.

@yochananmarqos I updated this branch again, could you please try it. I removed the part that renames the folder just to see if it's that. If it's not it means it's either the downloader or the extractor.

from protonplus.

No difference.

Just in case you hadn't noticed, I had edited my last post.

from protonplus.

Oh then I think it's the way I list the tools, it may think that . and .. is a tool. I have a filter on that, but maybe it's not reliable. I'll take a look into that.

from protonplus.

@yochananmarqos I updated this branch again, could you please try it. I added a filter on '.' and '..' to prevent them showing up.

from protonplus.

Well, now the .. doesn't show up. Other than that, there is no difference.

FYI, I also have lutris GE Proton present, but it isn't detected.

~/.local/share/lutris/runners/wine/lutris-GE-ProtonX-XX-x86_64

from protonplus.

Okay so Lutris doesn't show everything there's suppose to be?

from protonplus.

Sure, but that's only part of the problem. GE-Proton isn't being detected as installed no matter if it's the Steam or Lutris version.

from protonplus.

Okay, but if you go check where the tools are installed, do you see them? Like do you see a folder named . with the stuff from Proton-GE or there's a folder named Proton-GE7-41 or whatever, but my program just does not see it?

from protonplus.

Yes. I've already mentioned that multiple times.

from protonplus.

@yochananmarqos I updated this branch again, could you please try it.

from protonplus.

Yes, that did the trick! Thanks. I'd say tag a new release.

from protonplus.

Yep, I just have another pending issue which I want to fix first before the next update.

from protonplus.

...and while we're at it: #39 😉

from protonplus.

Closing since fixed in bca7516

from protonplus.