[BUG]Critical error. The application crashes during startup about protonplus HOT 116 CLOSED

Created a clean Fedora 37 virtual machine and my daily drivers Fedora 37, Debian testing/bookworm and Manjaro, still have the same crash with 0.3.1 (Flatpak).

~$ flatpak run com.vysp3r.ProtonPlus 

(protonplus:2): GLib-GIO-CRITICAL **: 23:51:27.389: g_list_store_append: assertion 'g_type_is_a (G_OBJECT_TYPE (item), store->item_type)' failed

(protonplus:2): GLib-GObject-WARNING **: 23:51:27.391: ../gobject/gtype.c:3210: invalid class pointer '0x556313c1ec20'

Builded the branch associated with this issue using flatpak builder, and now it work on the Fedora 37 virtual machine and all my daily drivers.

But the *.tar.gz file don't auto prune and I can't delete the compatibility tool if I click to delete.

~$ flatpak run com.vysp3r.ProtonPlus
Trash portal failed on /home/wgimenes/.var/app/com.vysp3r.ProtonPlus/config/preferences.json
Error opening file “/home/wgimenes/.var/app/com.vysp3r.ProtonPlus/config/preferences.json”: File exists
Trash portal failed on /home/wgimenes/.var/app/com.valvesoftware.Steam/data/Steam/compatibilitytools.d/GE-Proton7-42.tar.gz
Trash portal failed on /home/wgimenes/.var/app/com.valvesoftware.Steam/data/Steam/compatibilitytools.d/GE-Proton7-42

~/.var/app/com.valvesoftware.Steam/data/Steam/compatibilitytools.d$ ls -l
total 405004
drwxrwxr-x 1 wgimenes wgimenes       306 dez  2 20:22 GE-Proton7-42
-rw-r--r-- 1 wgimenes wgimenes 414720148 dez  2 21:14 GE-Proton7-42.tar.gz

from protonplus.

Even the Flatpak version does that?

from protonplus.

Alright, I'll look into that since we now know the source of the problem.

from protonplus.

That was just for entering the visual code block mode which enables syntax highlighting and keeps tabs and spacing and such

from protonplus.

And could you tell me if you put a break point at line 63 in /src/Models/Launcher.vala what does the value of test equals? Use the branch from this issue for that. https://github.com/Vysp3r/ProtonPlus/tree/37-bugcritical-error-the-application-crashes-during-startup

Is this what I needed to see?

from protonplus.

The part where it crashes is a simple one and should not in any way crash like that.
So it must be something with the parameter of the function that crashes.

from protonplus.

Here's mine for reference.

from protonplus.

I did a git pull and launched, it seems everything remained the same. The value has not changed.

from protonplus.

We have very different time zones, so I have to go to bed soon. If you can come up with something, I'll look at it in 10 hours.

from protonplus.

I disabled something to test if it's that that makes you crash. Test when you can :)

from protonplus.

It must be something else again, but what is the question. I really don't know anymore.

from protonplus.

Alright that may help then. I'll give that a try.

from protonplus.

At first, the flathub version did not start. Only then I tried to build the application myself. It doesn't work in both cases

from protonplus.

Since I can't reproduce on my system your problem would you be inclined to use the debug feature of GNOME Builder so we can pin point the cause of the problem?

from protonplus.

Yes, I can

from protonplus.

I think I know which part may be the problem, but just to make sure I will give you a few break points to place and you just have to tell me if you can reach them.

from protonplus.

Okay, I'm waiting

from protonplus.

Can it reach /src/Windows/Home.vala line 78?
Can it reach /src/Views/Tools.vala line 108?

from protonplus.

Did I do the right thing?

from protonplus.

I mean it's suppose to land one of the two lines I gave you.

from protonplus.

Does the application crash after continuing that line?

from protonplus.

When I select one or both breakpoints from below and run with the debugger, this IModel file opens. Do I need to do something else?

from protonplus.

Oh yeah press the little Play button in the middle left of the picture to continue debugging

from protonplus.

If it does nothing it means it crashed before reaching the breakpoint. From what I'm reading in the console, it looks like it did crash otherwise I don't know why it would stop there if you haven't put any breakpoint.

from protonplus.

Program terminated with signal SIGSEGV, Segmentation fault.
The program no longer exists.

Yes, it crashes immediately after clicking on play

from protonplus.

I tried installing Proton Plus from flathub on a VM. First I used Fedora 37, then Manjaro Gnome. And in both distributions, version 0.3.0 does not run. When running through the terminal, the same two errors appear that I gave at the beginning of the issue.

Maybe this information will help somehow

from protonplus.

I don't understand how we can get different result, it's annoying

from protonplus.

Can it reach /src/Views/Tools.vala line 33?
Can it reach /src/Views/Tools.vala line 100?

from protonplus.

Yes, it reaches in both cases.

from protonplus.

Okay great, now I know which part isn't working!

from protonplus.

Just to be extra sure, can it reach /src/Views/Tools.vala line 101?

from protonplus.

No, it does not reach 101 line. The IModel file opens, as in the screenshot above. Looks like you're right

from protonplus.

i was about to make an issue but it seems this already being solved ^-^

from protonplus.

Would you guys be able to tell me what's in /home/vysp3r/.var/app/com.vysp3r.ProtonPlus/config/preferences.json

from protonplus.

(i'm on silverblue btw but i guess we already established that)

from protonplus.

wait lol i posted that without thinking, it doesn't exist

from protonplus.

Are you using the Flatpak version or from source?

from protonplus.

i'm using the flatpak version

from protonplus.

imma go eat, I'll ask more question after

from protonplus.

Where do Flatpak saves it's stuff then if it's not in ~/.var

from protonplus.

mb, sorry for the trouble. i deleted the folder and reinstalled the flatpak. the config is now back and contains this:

{
	"style" : "system",
	"rememberLastLauncher" : true,
	"lastLauncher" : ""
}```

from protonplus.

Why do you have ```
Having those there could maybe result in a crash

from protonplus.

Can it reach /src/Models/Launcher.vala line 55?
Can it reach /src/Models/Launcher.vala line 62?

from protonplus.

for some reason, a breakpoint is not set at 55. At first it looks like in the screenshot, and after starting the debugger, I just have nothing in the "breakpoints" section
it reaches 62.

from protonplus.

{
	"style" : "system",
	"rememberLastLauncher" : true,
	"lastLauncher" : ""
}

it's in preferences.json

from protonplus.

It does not make sense that it reaches line 62 in Launcher.vala, but does not reach 101 in Tools.vala. Can you test again to make sure it does not reach /src/Views/Tools.vala line 101?

from protonplus.

And could you tell me if you put a break point at line 63 in /src/Models/Launcher.vala what does the value of test equals? Use the branch from this issue for that. https://github.com/Vysp3r/ProtonPlus/tree/37-bugcritical-error-the-application-crashes-during-startup

from protonplus.

Does not reach 62 and 101

from protonplus.

Ain't gonna lie I'm a bit lost on why that happens.

from protonplus.

And could you tell me if you put a break point at line 63 in /src/Models/Launcher.vala what does the value of test equals? Use the branch from this issue for that. https://github.com/Vysp3r/ProtonPlus/tree/37-bugcritical-error-the-application-crashes-during-startup

Is this what I needed to see?

Oh shit I think I found it. Look at the value of launchers in the pic you sent me. It says error blablabla.

from protonplus.

Could you send me the full text because I can't read it all in your pic.

from protonplus.

I don't know how to copy it. sorry about the picture

from protonplus.

No worries I just wanted to see the full thing.

from protonplus.

Can you test the branch I sent you. I added a possible fix.

from protonplus.

Yes. The app is working now!

from protonplus.

But. Folders from the home directory are now visible in the list.

from protonplus.

What the heck. There must be something wrong with the permissions then.

from protonplus.

Tell me if the crash still happens in 0.3.1 then. It should be available on Flatpak or else build from source from the main branch.

from protonplus.

I still have the same crash with 0.3.1 (Flatpak).

(protonplus:2): GLib-GIO-CRITICAL **: 00:03:30.587: g_list_store_append: assertion 'g_type_is_a (G_OBJECT_TYPE (item), store->item_type)' failed

(protonplus:2): GLib-GObject-WARNING **: 00:03:30.589: ../gobject/gtype.c:3210: invalid class pointer '0x55ecaf7f6b80'

from protonplus.

You can now test the branch associated with this issue. I've tried something that may fix this issue.

from protonplus.

You can now test the branch associated with this issue. I've tried something that may fix this issue.

The application starts, the list is fixed. For some reason, the Proton installation has been freezes for several minutes at the "loading" stage with zero progress. No errors seem to be output to the terminal. I mean, it looks like the download doesn't start at all

By the way, unlike @wehagy, I have no problem removing compatibility tools

from protonplus.

For the delete, I use this. It says that it may not be available on all filesystems. I'll use File.Delete instead which is always supported. I wanted to use the trash method in case my program delete something it wasn't supposed to. That should be an easy fix, but maybe create a different issue for that since it's not related.

from protonplus.

Does your problem happens for every launcher or only a specific one? @smotim

from protonplus.

@wehagy do you happen to have 'GTK_USE_PORTAL=1' in your /etc/environment?

from protonplus.

Does your problem happens for every launcher or only a specific one? @smotim

every

from protonplus.

@smotim would you send me a picture with the path of one of the launcher and verify that those path are correct too on your side. Like that:

from protonplus.

I can. Maybe I explained it badly. That's where the problem comes in. It says "loading" and nothing happens for a long time.

from protonplus.

But does something finally happen or it's just broken? And it's downloading, not loading ;)

from protonplus.

Yes, it is downloading. I just translated it back from Russian incorrectly.:) As a result, nothing happens, that's why I wrote about it.

from protonplus.

Does it extract the downloaded tool too?

from protonplus.

Is that what you mean?

from protonplus.

When you click install, it firsts download a .tar.xz or something like that then it extract it to a folder with the tool name and version. My question is when you install a tool, does it shows up in a folder extracted.

from protonplus.

No, a new folder is not being created. These two are left over from the previous version (0.2.3)

from protonplus.

@wehagy do you happen to have 'GTK_USE_PORTAL=1' in your /etc/environment?

The file /etc/environment on my debian and manjaro systems are empty, tried to set up and the two systems freeze on logon.
Created a new issue #43 to track this bug.

from protonplus.

@smotim can you tell me the values of url and path when you put a breakpoint on /src/Utils/Web.vala line 20. Use the branch associated to this issue.

from protonplus.

@smotim can you tell me the values of url and path when you put a breakpoint on /src/Utils/Web.vala line 20. Use the branch associated to this issue.

from protonplus.

Hmmmmm, the url and the path looks good.

from protonplus.

Can it reach /src/Utils/Web.vala line 26?

from protonplus.

Can it reach /src/Utils/Web.vala line 26?

Yes, it can reach

from protonplus.

So the download starts, but it doesn't at the same time? Because if it can reach that, the download started. Do you see a file appear in the directory when you click install or just nothing at all?

from protonplus.

Nothing appears

from protonplus.

Is the download working for anyone? @wehagy @im-viriv

from protonplus.

I just really don't know anymore what could be the problem. If it reaches the end of that function it should work. Otherwise there would be an error or something.

from protonplus.

Is the download working for anyone? @wehagy @im-viriv

Can i check in the public release? Or should I compile the branch?

from protonplus.

You would have to compile the branch.

from protonplus.

Is the download working for anyone? @wehagy @im-viriv

Download and extraction is working for me.

from protonplus.

I just noticed this in the output of the application. This translates to 'Action not supported'. This message won't help you understand the source of the problem?

from protonplus.

Could you tell me when that output shows up. If you could tell me the exact line that would be perfect.

from protonplus.

Right at the moment of clicking on the "install" button. And how can I find out a specific line?

from protonplus.

Put a breakpoint in /src/Windows/Installer.vala line 94 and click on the button highlighted in the picture until the error message appears and tell me in what file and on what line it was.

from protonplus.

It seems like this. Did I take the right screenshot?

from protonplus.

I pressed this button. The message "Action is not supported" appeared at the same moment when this empty file was opened

from protonplus.

after line 96, this file opens instead of going to 97

from protonplus.

It's impossible that your computer can't enter the Timeout, it's supposed to work on every computer.

from protonplus.

Yeah. And up to 0.3.0 version everything worked fine. I will use proton qt up for now. Maybe it will also be repaired by accident? :)
Thank you for spending so much time on my problem

from protonplus.

So 0.3.0 works but not up? Or everything under 0.3.0?

from protonplus.

Because if so I can check the difference between the latest working version for you and the latest and check what may have messed up ProtonPlus on your end.

from protonplus.

I created the last issue when I used the 0.2.0 version. Everything worked well in it, except what I wrote about in the issue. And in versions 3.0 and 3.1 there are new errors from this issue

from protonplus.

previously, there were only minor problems with the frontend(which you successfully fixed). since version 3.0, there have been problems with the basic functionality.

from protonplus.

I'll try again to find the problem :)

from protonplus.