Giter VIP home page Giter VIP logo

Comments (10)

Vysp3r avatar Vysp3r commented on July 30, 2024

Yeah, it was already in my todo list ahah. Shouldn't be too long to add.

from protonplus.

wehagy avatar wehagy commented on July 30, 2024

Nice, I think you can use that issue to track this 😅

from protonplus.

Vysp3r avatar Vysp3r commented on July 30, 2024

The new download method was tested and is working properly. I will implement that in the next update with a way to cancel the download at the same time.

from protonplus.

wehagy avatar wehagy commented on July 30, 2024

I think it's going to be a small but good fix.

from protonplus.

Vysp3r avatar Vysp3r commented on July 30, 2024

I was able to make that when you exit the window, it deletes the files so that nothing is left behind. I will not add a pop up asking to make sure you want to exit for now since it would require a rewrite of something and I wish to get the next update out before doing that.

from protonplus.

Vysp3r avatar Vysp3r commented on July 30, 2024

I still miss the pop up to add like I said earlier, but the files should no longer appear if you close the window during an installation. Here's the commit in case you're interested 7fd6d15.

I will leave this issue open since it's not fully done.

from protonplus.

wehagy avatar wehagy commented on July 30, 2024

I dunno if this is expected for now, but if I'm downloading and close the window, the message Cancelled! appears, and I can't download without closing and opening the app, the files is removed. If I click to close the window on extraction, the same happens, but not all the files is removed, but I think it's because of the #43 and unrelated.

from protonplus.

Vysp3r avatar Vysp3r commented on July 30, 2024

Yeah, it's probably due to that issue indeed. I'll test on my end a bit more to make sure there's really no problem with that tho.

from protonplus.

Vysp3r avatar Vysp3r commented on July 30, 2024

I will work on this this week.

from protonplus.

Vysp3r avatar Vysp3r commented on July 30, 2024

My friend fixed it in #84. It will be available in the next update. I will now close this issue.

from protonplus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.