wintermute0110 / plugin.program.ael.dev Goto Github PK

What is needed to reenable retroarch?

I was hoping to use this plugin with SPMC 17 on Android but cannot find a reason it was disabled.

Have any plans to submit this to the official Kodi repo?

Hi.
Not sure if this is the place to go for this, but since the Kodi forums are down I'm coming here.
I finally found a way to launch amiga games through kodi using gamebase. But the issue I'm having is that AEL is moving the quotes I put into the launch string and thereby messing up the launch command.

Have a look, this is what I enter into application arguments: db=GameBase_Amiga fn="$rombase$"
what comes out is this: db=GameBase_Amiga "fn=(ROMNAME)"
(ROMNAME) is the correct filename, I just replaced it here.

As you can see he moves the " from after = to infront of fn.
And this messes up the command line obviously.

I really hope you can have a quick look at this and fix it.

Hi! Thanks for your great work. Have come across an issue, though...

When scraping "Wii Sports", I get "Wii Sports and Wii Sports Resort" instead. Looks like the api function (http://thegamesdb.net/api/GetGamesList.php?name=Wii%20Sports) does not return "Wii Sports". To get "Wii Sports", I need (http://thegamesdb.net/api/GetGame.php?exactname=Wii%20Sports). Is it possible to have "exact matching" as an option? Thanks.

I can set up a LNK launcher and perform a scan of my .lnk files which all show up fine as per this guide: https://forum.kodi.tv/showthread.php?tid=287826&pid=2606823#pid2606823

However when I launch a lnk file it gives me an error which I can't make sense
For context my .lnk files are windows application shortcuts.

Here is my error log produced by simply logging into KODI and going straight to lnk to launch:

21:17:37.818 T:8028 ERROR: XFILE::CDirectory::GetDirectory - Error getting
21:17:39.265 T:8988 ERROR: Previous line repeats 2 times.
21:17:39.265 T:8988 ERROR: AEL DEBUG: ---------- Called AEL Main::run_plugin() constructor ----------
21:17:39.265 T:8988 ERROR: AEL DEBUG: sys.platform "win32"
21:17:39.265 T:8988 ERROR: AEL DEBUG: Python version "2.7.13 (default, Jul 13 2017, 20:56:54) [MSC v.1900 32 bit (Intel)]"
21:17:39.265 T:8988 ERROR: AEL DEBUG: a_version "0.9.9-alpha"
21:17:39.265 T:8988 ERROR: AEL DEBUG: sys.argv[0] "plugin://plugin.program.advanced.emulator.launcher/"
21:17:39.265 T:8988 ERROR: AEL DEBUG: sys.argv[1] "1"
21:17:39.265 T:8988 ERROR: AEL DEBUG: sys.argv[2] ""
21:17:39.265 T:8988 ERROR: AEL DEBUG: JSON {"id" : 1, "jsonrpc" : "2.0", "method" : "Application.GetProperties", "params" : {"properties" : ["name", "version"]} }
21:17:39.265 T:8988 ERROR: AEL DEBUG: Response {"id":1,"jsonrpc":"2.0","result":{"name":"Kodi","version":{"major":17,"minor":5,"revision":"20171023-5bd45ab","tag":"stable"}}}
21:17:39.265 T:8988 ERROR: AEL DEBUG: JSON {"id" : 1, "jsonrpc" : "2.0", "method" : "Settings.GetSettingValue", "params" : {"setting" : "lookandfeel.skin"} }
21:17:39.265 T:8988 ERROR: AEL DEBUG: Response {"id":1,"jsonrpc":"2.0","result":{"value":"skin.estuary"}}
21:17:39.265 T:8988 ERROR: AEL DEBUG: JSON RPC time 0.000 ms
21:17:39.275 T:8988 ERROR: AEL VERB : fs_load_catfile() Loading special://profile/addon_data\plugin.program.advanced.emulator.launcher\categories.xml
21:17:39.282 T:8988 ERROR: AEL DEBUG: command = "SHOW_ADDON_ROOT"
21:17:39.282 T:8988 ERROR: AEL DEBUG: Advanced Emulator Launcher run_concurrent() BEGIN
21:17:39.282 T:8988 ERROR: AEL DEBUG: _misc_set_AEL_Content() Setting Window(10000) property "AEL_Content" = "launchers"
21:17:39.414 T:8988 ERROR: AEL DEBUG: Advanced Emulator Launcher run_concurrent() END
21:17:39.414 T:8988 ERROR: AEL DEBUG: Advanced Emulator Launcher run_plugin() exit
21:17:43.431 T:7228 ERROR: AEL DEBUG: ---------- Called AEL Main::run_plugin() constructor ----------
21:17:43.431 T:7228 ERROR: AEL DEBUG: sys.platform "win32"
21:17:43.432 T:7228 ERROR: AEL DEBUG: Python version "2.7.13 (default, Jul 13 2017, 20:56:54) [MSC v.1900 32 bit (Intel)]"
21:17:43.432 T:7228 ERROR: AEL DEBUG: a_version "0.9.9-alpha"
21:17:43.432 T:7228 ERROR: AEL DEBUG: sys.argv[0] "plugin://plugin.program.advanced.emulator.launcher/"
21:17:43.432 T:7228 ERROR: AEL DEBUG: sys.argv[1] "2"
21:17:43.432 T:7228 ERROR: AEL DEBUG: sys.argv[2] "?catID=root_category&com=SHOW_ROMS&launID=12bf9d8b47042d1f4b4c1149f551a426"
21:17:43.432 T:7228 ERROR: AEL DEBUG: JSON {"id" : 1, "jsonrpc" : "2.0", "method" : "Application.GetProperties", "params" : {"properties" : ["name", "version"]} }
21:17:43.432 T:7228 ERROR: AEL DEBUG: Response {"id":1,"jsonrpc":"2.0","result":{"name":"Kodi","version":{"major":17,"minor":5,"revision":"20171023-5bd45ab","tag":"stable"}}}
21:17:43.432 T:7228 ERROR: AEL DEBUG: JSON {"id" : 1, "jsonrpc" : "2.0", "method" : "Settings.GetSettingValue", "params" : {"setting" : "lookandfeel.skin"} }
21:17:43.432 T:7228 ERROR: AEL DEBUG: Response {"id":1,"jsonrpc":"2.0","result":{"value":"skin.estuary"}}
21:17:43.432 T:7228 ERROR: AEL DEBUG: JSON RPC time 0.000 ms
21:17:43.441 T:7228 ERROR: AEL VERB : fs_load_catfile() Loading special://profile/addon_data\plugin.program.advanced.emulator.launcher\categories.xml
21:17:43.449 T:7228 ERROR: AEL DEBUG: command = "SHOW_ROMS"
21:17:43.449 T:7228 ERROR: AEL DEBUG: Advanced Emulator Launcher run_concurrent() BEGIN
21:17:43.449 T:7228 ERROR: AEL DEBUG: _misc_set_AEL_Content() Setting Window(10000) property "AEL_Content" = "roms"
21:17:43.449 T:7228 ERROR: AEL DEBUG: romsetfactory.create(): categoryID=root_category
21:17:43.449 T:7228 ERROR: AEL DEBUG: romsetfactory.create(): launcherID=12bf9d8b47042d1f4b4c1149f551a426
21:17:43.449 T:7228 ERROR: AEL INFO : RomSetFactory() loading standard romset...
21:17:43.449 T:7228 ERROR: AEL INFO : StandardRomSet() Loading ROMs in Launcher ...
21:17:43.449 T:7228 ERROR: AEL VERB : StandardRomSet.loadRoms() FILE special://profile/addon_data\plugin.program.advanced.emulator.launcher\db_ROMs\roms_root_category_Test_12bf9d.json
21:17:43.449 T:7228 ERROR: AEL DEBUG: romsetfactory.create(): categoryID=vcat_pclone
21:17:43.449 T:7228 ERROR: AEL DEBUG: romsetfactory.create(): launcherID=12bf9d8b47042d1f4b4c1149f551a426
21:17:43.449 T:7228 ERROR: AEL INFO : RomSetFactory() loading standard romset...
21:17:43.450 T:7228 ERROR: AEL INFO : StandardRomSet() Loading ROMs in Launcher ...
21:17:43.450 T:7228 ERROR: AEL VERB : StandardRomSet.loadRoms() FILE special://profile/addon_data\plugin.program.advanced.emulator.launcher\db_ROMs\roms_root_category_Test_12bf9d.json
21:17:43.450 T:7228 ERROR: AEL VERB : fs_load_Favourites_JSON() File special://profile/addon_data\plugin.program.advanced.emulator.launcher\favourites.json
21:17:43.616 T:7228 ERROR: AEL DEBUG: Loading seconds 0.00100016593933
21:17:43.616 T:7228 ERROR: AEL DEBUG: Rendering seconds 0.165999889374
21:17:43.616 T:7228 ERROR: AEL DEBUG: Advanced Emulator Launcher run_concurrent() END
21:17:43.616 T:7228 ERROR: AEL DEBUG: Advanced Emulator Launcher run_plugin() exit
21:17:45.134 T:5444 ERROR: AEL DEBUG: ---------- Called AEL Main::run_plugin() constructor ----------
21:17:45.134 T:5444 ERROR: AEL DEBUG: sys.platform "win32"
21:17:45.134 T:5444 ERROR: AEL DEBUG: Python version "2.7.13 (default, Jul 13 2017, 20:56:54) [MSC v.1900 32 bit (Intel)]"
21:17:45.134 T:5444 ERROR: AEL DEBUG: a_version "0.9.9-alpha"
21:17:45.134 T:5444 ERROR: AEL DEBUG: sys.argv[0] "plugin://plugin.program.advanced.emulator.launcher/"
21:17:45.134 T:5444 ERROR: AEL DEBUG: sys.argv[1] "-1"
21:17:45.134 T:5444 ERROR: AEL DEBUG: sys.argv[2] "?com=LAUNCH_ROM&catID=root_category&launID=12bf9d8b47042d1f4b4c1149f551a426&romID=d32cbad1e269d0d73053f1396f955650"
21:17:45.135 T:5444 ERROR: AEL DEBUG: JSON {"id" : 1, "jsonrpc" : "2.0", "method" : "Application.GetProperties", "params" : {"properties" : ["name", "version"]} }
21:17:45.135 T:5444 ERROR: AEL DEBUG: Response {"id":1,"jsonrpc":"2.0","result":{"name":"Kodi","version":{"major":17,"minor":5,"revision":"20171023-5bd45ab","tag":"stable"}}}
21:17:45.135 T:5444 ERROR: AEL DEBUG: JSON {"id" : 1, "jsonrpc" : "2.0", "method" : "Settings.GetSettingValue", "params" : {"setting" : "lookandfeel.skin"} }
21:17:45.135 T:5444 ERROR: AEL DEBUG: Response {"id":1,"jsonrpc":"2.0","result":{"value":"skin.estuary"}}
21:17:45.135 T:5444 ERROR: AEL DEBUG: JSON RPC time 0.000 ms
21:17:45.144 T:5444 ERROR: AEL VERB : fs_load_catfile() Loading special://profile/addon_data\plugin.program.advanced.emulator.launcher\categories.xml
21:17:45.155 T:5444 ERROR: AEL DEBUG: command = "LAUNCH_ROM"
21:17:45.156 T:5444 ERROR: AEL DEBUG: SingleInstance::enter() Lock not in use. Setting lock
21:17:45.156 T:5444 ERROR: AEL DEBUG: Advanced Emulator Launcher run_protected() BEGIN
21:17:45.156 T:5444 ERROR: AEL INFO : _command_run_rom() Launching ROM in Launcher ...
21:17:45.156 T:5444 ERROR: AEL DEBUG: romsetfactory.create(): categoryID=root_category
21:17:45.156 T:5444 ERROR: AEL DEBUG: romsetfactory.create(): launcherID=12bf9d8b47042d1f4b4c1149f551a426
21:17:45.156 T:5444 ERROR: AEL INFO : RomSetFactory() loading standard romset...
21:17:45.156 T:5444 ERROR: AEL INFO : StandardRomSet() Loading ROMs in Launcher ...
21:17:45.156 T:5444 ERROR: AEL VERB : StandardRomSet.loadRoms() FILE special://profile/addon_data\plugin.program.advanced.emulator.launcher\db_ROMs\roms_root_category_Test_12bf9d.json
21:17:46.677 T:5444 ERROR: AEL DEBUG: Advanced Emulator Launcher run_protected() END
21:17:46.677 T:5444 ERROR: AEL DEBUG: SingleInstance::exit() Releasing lock
21:17:46.677 T:5444 ERROR: AEL DEBUG: Advanced Emulator Launcher run_plugin() exit

Ran into an issues when trying to add roms to a launcher.
Kodi v16 Jarvis
Windows 7

I applied the most recent fix for the trailers. I have 2 machines. My family HTPC. And my main PC rig.

I do all of my kodi/AEL testing on the PC rig b4 I move over to the HTPC.

If you need to me record another video let me know.
Thanks.

15:42:36 T:19496  NOTICE: AEL INFO : Launcher is empty. No dead ROM check.
15:42:36 T:19496  NOTICE: AEL INFO : Scanning files in F:\Users\New Super Mario Bros. Wii (USA)\
15:42:36 T:19496  NOTICE: AEL INFO : Recursive scan activated
15:42:36 T:19496  NOTICE: AEL INFO : Found 2 files
15:42:36 T:19496   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <type 'exceptions.ValueError'>
                                            Error Contents: Invalid mode ('rtb')
                                            Traceback (most recent call last):
                                              File "C:\Users\Monki\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher-master\addon.py", line 45, in <module>
                                                plugin.run_plugin()
                                              File "C:\Users\Monki\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher-master\resources\main.py", line 234, in run_plugin
                                                self._command_add_roms(args['launID'][0])
                                              File "C:\Users\Monki\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher-master\resources\main.py", line 1227, in _command_add_roms
                                                self._roms_import_roms(launcher)
                                              File "C:\Users\Monki\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher-master\resources\main.py", line 3601, in _roms_import_roms
                                                romdata     = self._roms_process_scanned_ROM(launcherID, ROM)
                                              File "C:\Users\Monki\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher-master\resources\main.py", line 3714, in _roms_process_scanned_ROM
                                                nfo_dic = fs_load_NFO_file_scanner(nfo_file_path)
                                              File "C:\Users\Monki\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher-master\resources\disk_IO.py", line 1061, in fs_load_NFO_file_scanner
                                                file = codecs.open(nfo_file_path, 'rt', 'utf-8')
                                              File "F:\Program Files (x86)\Kodi\system\python\Lib\codecs.py", line 878, in open
                                                file = __builtin__.open(filename, mode, buffering)
                                            ValueError: Invalid mode ('rtb')
                                            -->End of Python script error report<--

Hi with latest git AEL launcher with commandline option in arguments line failed.
For example with pcsx2
with this
<args>&quot;%rom%&quot;</args>

it work
if I had option like this

<args>--nogui &quot;%rom%&quot;</args>

il failed.
Same problem with retroarch.

Currently, kodi still runs in background when an emulator runs. This costs unnecessary CPU cycles. Sth like

kill -STOP kodi_pid
run_emulator
kill -CONT kodi_pid

should already do the trick.

windows 7
jarvis kodi
release version of AEL

adding this here as well at the linked release page.

18:38:46 T:67556   ERROR: XFILE::CDirectory::GetDirectory - Error getting /extrafanart/
18:38:46 T:69988   ERROR: XFILE::CDirectory::GetDirectory - Error getting D:\Arcade\\\extrathumb\
18:38:46 T:69988   ERROR: Previous line repeats 6 times.
18:38:46 T:69988   ERROR: XFILE::CDirectory::GetDirectory - Error getting /extrafanart/
18:38:46 T:67556   ERROR: CImageLoader::DoWork - Direct texture file loading failed for resource://resource.images.studios.white/
18:38:46 T:67556   ERROR: XFILE::CDirectory::GetDirectory - Error getting /extrafanart/
18:38:46 T:68104   ERROR: Previous line repeats 11 times.
18:38:46 T:68104   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <type 'exceptions.KeyError'>
                                            Error Contents: ('7afbbc7475e255a5974383cc9366249e',)
                                            Traceback (most recent call last):
                                              File "C:\Users\hteapeac\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher\addon.py", line 47, in <module>
                                                plugin.run_plugin()
                                              File "C:\Users\hteapeac\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher\resources\main.py", line 204, in run_plugin
                                                self._command_render_launchers(args['catID'][0])
                                              File "C:\Users\hteapeac\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher\resources\main.py", line 2034, in _command_render_launchers
                                                category_name = self.categories[categoryID]['m_name']
                                            KeyError: ('7afbbc7475e255a5974383cc9366249e',)
                                            -->End of Python script error report<--
18:38:46 T:63932   ERROR: XFILE::CDirectory::GetDirectory - Error getting plugin://plugin.program.advanced.emulator.launcher/?catID=7afbbc7475e255a5974383cc9366249e&com=SHOW_LAUNCHERS
18:38:46 T:63932   ERROR: CGUIMediaWindow::GetDirectory(plugin://plugin.program.advanced.emulator.launcher/?catID=7afbbc7475e255a5974383cc9366249e&com=SHOW_LAUNCHERS) failed
18:38:46 T:69988   ERROR: XFILE::CDirectory::GetDirectory - Error getting D:\Arcade\\K: (SLUS_00067)\extrafanart\
18:38:50 T:70152 WARNING: VIDEO::CVideoInfoScanner::Process directory 'smb://FREENAS/media1/Media/Completed/TVShows/Shameless (US)/' does not exist - skipping scan.
18:38:50 T:70152  NOTICE: VideoInfoScanner: Finished scan. Scanning for video info took 00:14
18:41:03 T:67396   ERROR: XFILE::CDirectory::GetDirectory - Error getting D:\Arcade\\Advanced Emulator Launcher\extrafanart\
18:41:05 T:69416   ERROR: XFILE::CDirectory::GetDirectory - Error getting D:\Arcade\\{ROM Collections}\extrafanart\
18:41:06 T:69896   ERROR: XFILE::CDirectory::GetDirectory - Error getting D:\Arcade\\<Favourites>\extrafanart\
18:41:07 T:69896   ERROR: XFILE::CDirectory::GetDirectory - Error getting D:\Arcade\\Emulators\extrafanart\
18:41:17 T:69896   ERROR: XFILE::CDirectory::GetDirectory - Error getting D:\Arcade\\Nintendo\extrafanart\
18:41:18 T:67396   ERROR: XFILE::CDirectory::GetDirectory - Error getting D:\Arcade\\..\extrafanart\
18:41:21 T:69896   ERROR: XFILE::CDirectory::GetDirectory - Error getting D:\Arcade\\Nintendo\extrafanart\
18:41:35 T:70552   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <type 'exceptions.NameError'>
                                            Error Contents: global name 'rom_asset_list' is not defined
                                            Traceback (most recent call last):
                                              File "C:\Users\hteapeac\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher\addon.py", line 47, in <module>
                                                plugin.run_plugin()
                                              File "C:\Users\hteapeac\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher\resources\main.py", line 228, in run_plugin
                                                self._command_add_roms(args['launID'][0])
                                              File "C:\Users\hteapeac\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher\resources\main.py", line 1486, in _command_add_roms
                                                self._roms_add_new_rom(launcher)
                                              File "C:\Users\hteapeac\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher\resources\main.py", line 4493, in _roms_add_new_rom
                                                self.enabled_asset_list = [False] * len(rom_asset_list)
                                            NameError: global name 'rom_asset_list' is not defined
                                            -->End of Python script error report<--

Hi, AEL failed to start rom with this error

19:17:12 T:140030172088064   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <type 'exceptions.NameError'>
                                            Error Contents: global name 'VLAUNCHER_FAV_ID' is not defined
                                            Traceback (most recent call last):
                                              File "/home/mac/.kodi/addons/plugin.program.advanced.emulator.launcher/addon.py", line 47, in <module>
                                                plugin.run_plugin()
                                              File "/home/mac/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 226, in run_plugin
                                                self._command_run_rom(args['catID'][0], args['launID'][0], args['romID'][0])
                                              File "/home/mac/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 3671, in _command_run_rom
                                                if launcherID == VLAUNCHER_FAV_ID:
                                            NameError: global name 'VLAUNCHER_FAV_ID' is not defined
                                            -->End of Python script error report<--

No problem to start standalone programs.

Hello

I tried your add-on on my new remix mini pc (RCB don't work on that device). Your add on seems to the work , but i have an other problem. installed app (and emulators) seems to be installed on the root part of my storage, (that device can't be root), it is also impossible to move that app to sd card.
It seems to be impossible to link emulators directly.

I tried a move the app to sd solution => impossible due to that OS

emulators are detected as android app on kodi programs page..... there is no logic in that situation.

Could you add an autodetect function for emulator ? That could solve the problem for many users

Hi again. I think I have discovered another bug...

When scanning ROMs and "Asset scan policy" set to "Local Files", local files are not pulled in. I seem to have isolated the problem down to line 240 in utils.py:

file_path = rootPath + filename_noext + '.' + ext

The file-path that is generated from the above line gives: "rootPath/filename_noext/./ext" rather than "rootPath/filename_noext.ext". This correction seems to work:

file_path = rootPath.join(filename_noext + '.' + ext)

Hi, and thanks for this great addon.

I can't get the scrapper to work. They all throw error messages.
For example, AEL/metadata/scrap from TheGamesDB can correctly find my Witcher 3 standalone shortcut and recognize it as witcher 3, but selecting any items in the list (for example : The Witcher 3 : wild hunt - PC) results in an error.

Here is the log entry :

22:06:30.329 T:7964 ERROR: AEL ERROR: SingleInstance::exit() Unhandled excepcion in protected code
22:06:30.339 T:7964 ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <type 'exceptions.KeyError'>
Error Contents: u'studio'
Traceback (most recent call last):
File "C:\Users\Simon\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher\addon.py", line 39, in
main.Main().run_plugin()
File "C:\Users\Simon\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher\resources\main.py", line 270, in run_plugin
self.run_protected(command, args)
File "C:\Users\Simon\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher\resources\main.py", line 358, in run_protected
self._command_edit_launcher(args['catID'][0], args['launID'][0])
File "C:\Users\Simon\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher\resources\main.py", line 1265, in _command_edit_launcher
if not self._gui_scrap_launcher_metadata(launcherID, scraper_obj): return
File "C:\Users\Simon\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher\resources\main.py", line 9371, in _gui_scrap_launcher_metadata
self.launchers[launcherID]['m_studio'] = gamedata['studio']
KeyError: u'studio'
-->End of Python script error report<--

I already tried with a fresh install of 0.9.7. Any other ideas ?

Hi just noticed that there is no platform in the query sent to gamedb wich introduce a lot of false result.
When the platform is set in the launcher it would be better to add it to the query. For example here :

18:14:17 T:140340707178240   ERROR: AEL DEBUG: Scraper_TheGamesDB::get_search search_string        "Albert Odyssey   Legend of Eldean"
18:14:17 T:140340707178240   ERROR: AEL DEBUG: Scraper_TheGamesDB::get_search rom_base_noext       "Albert Odyssey - Legend of Eldean (USA) (RE)"
18:14:17 T:140340707178240   ERROR: AEL DEBUG: Scraper_TheGamesDB::get_search AEL platform         "Sega Saturn"
18:14:17 T:140340707178240   ERROR: AEL DEBUG: Scraper_TheGamesDB::get_search TheGamesDB platform  ""
18:14:17 T:140340707178240   ERROR: AEL DEBUG: net_get_URL_text() Reading URL "http://thegamesdb.net/api/GetGamesList.php?name=Albert+Odyssey+++Legend+of+Eldean&platform="

If the query is change to
"http://thegamesdb.net/api/GetGamesList.php?name=Albert+Odyssey+++Legend+of+Eldean&platform=Sega+Saturn"

the result are way better

Im using the Sexy Cirrus skin currently.
Using Jarvis.
most recent version of AEL this issue was noticed.
Did not happen with previous version.

I have the option for "play trailer, in Window" on.
when i move to a file. after 1 or 2 secs. the trailer (ive selected) auto starts to play. If i move to a new rom file. the trailer stops playing. and if that newly selected rom has a trailer that will start to play..
The issue is: Previously when i would ESC or BACKSPACE to go back a step. the trailer would stop playing.

it doesnt anymore.

It stops playing when i launch the emulator though. just it keeps playing when i go back a step is kodi.

Installed the latest version today, now i can no longer add new rom using online scraper, here's the error :

18:04:06 T:140340406695680   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <type 'exceptions.NameError'>
                                            Error Contents: global name 'local_title' is not defined
                                            Traceback (most recent call last):
                                              File "/home/mac/.kodi/addons/plugin.program.advanced.emulator.launcher/addon.py", line 45, in <module>
                                                plugin.run_plugin()
                                              File "/home/mac/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 217, in run_plugin
                                                self._command_add_roms(args['launID'][0])
                                              File "/home/mac/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 1448, in _command_add_roms
                                                self._roms_import_roms(launcher)
                                              File "/home/mac/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 4399, in _roms_import_roms
                                                romdata     = self._roms_process_scanned_ROM(launcherID, ROM)
                                              File "/home/mac/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 4611, in _roms_process_scanned_ROM
                                                selected_title     = self._roms_process_asset_policy_2(ASSET_TITLE, local_title, ROM, launcher)
                                            NameError: global name 'local_title' is not defined
                                            -->End of Python script error report<--

Edit : did a little more testing

-gamedb metadata scraper work, but with some roms it failed with this error

23:53:35 T:140391097542400   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <type 'exceptions.NameError'>
                                            Error Contents: global name 'VLAUNCHER_FAV_ID' is not defined
                                            Traceback (most recent call last):
                                              File "/home/mac/.kodi/addons/plugin.program.advanced.emulator.launcher/addon.py", line 45, in <module>
                                                plugin.run_plugin()
                                              File "/home/mac/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 220, in run_plugin
                                                self._command_edit_rom(args['catID'][0], args['launID'][0], args['romID'][0])
                                              File "/home/mac/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 1498, in _command_edit_rom
                                                if not self._gui_scrap_rom_metadata(roms, romID, launcherID): return
                                              File "/home/mac/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 4987, in _gui_scrap_rom_metadata
                                                if launcherID == VLAUNCHER_FAV_ID:
                                            NameError: global name 'VLAUNCHER_FAV_ID' is not defined
                                            -->End of Python script error report<--

-gamedb asset scraper failed
-gamefaq metadata scraper failed
-gamefaq asset scraper failed

Could you add the option to use multiple emulator per launcher. similar to how the additional argument work: when you select a rom it will ask you which launcher you want to use. I.e if i set the 2 emulators as retroarch hatari and standalone hatari it will ask me which one to launch the rom with. This will allow me to play rom that do not work in the retroarch cores.(i ussualy prefer using retroarch cores when possible because of shaders and easy controller set up.) As well as easily launch different emulators as the mood arises such as the 3dnes emulator, sometimes i want to try a rom in that emulator.

Any chance for a “launch only once” feature? So, if you DoubleClick only one instance of an application is launched. For kids or clumsy adults. Now several clicks or gamepad presses can open serval instances.

With the latest git version the alternative argument I set arent used anymore

Thought I just as well could create an issue instead of continueing in the pull request thread :)
But yeah, I found the quotes issue what I was talking about before. Here you see the case which gives some issues.

00:48:56 T:2048035048 NOTICE: AEL VERB : fs_load_ROM_XML_file() Loading XML file /storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/userdata/addon_data/plugin.program.advanced.emulator.launcher/roms_Emulators_Megadrive_e0251.xml
00:48:58 T:2048035048 NOTICE: AEL INFO : _command_run_rom() application = "/system/xbin/su"
00:48:58 T:2048035048 NOTICE: AEL INFO : _command_run_rom() apppath = "/system/xbin"
00:48:58 T:2048035048 NOTICE: AEL INFO : _command_run_rom() romfile = "/sdcard/Shares/Media6/Roms/Sega - Mega Drive - Genesis/Zool - Ninja of the 'Nth' Dimension/Zool - Ninja of the 'Nth' Dimension (USA).md"
00:48:58 T:2048035048 NOTICE: AEL INFO : _command_run_rom() rompath = "/sdcard/Shares/Media6/Roms/Sega - Mega Drive - Genesis/Zool - Ninja of the 'Nth' Dimension"
00:48:58 T:2048035048 NOTICE: AEL INFO : _command_run_rom() rombasename = "Zool - Ninja of the 'Nth' Dimension (USA).md"
00:48:58 T:2048035048 NOTICE: AEL INFO : _command_run_rom() arguments = "-c 'am start -a android.intent.action.MAIN -c android.intent.category.LAUNCHER -e ROM "/sdcard/Shares/Media6/Roms/Sega - Mega Drive - Genesis/Zool - Ninja of the 'Nth' Dimension/Zool - Ninja of the 'Nth' Dimension (USA).md" -e LIBRETRO /data/data/com.retroarch/cores/genesis_plus_gx_libretro_android.so -n com.retroarch/.browser.retroactivity.RetroActivityFuture'"

Because on Android you can use the root su to start the emulator and you give it arguments like "-c 'am ... " you might get in trouble if the romfile already has quotes (like "..Ninja of the 'Nth' Dimension..").

I fixed this in the old AL for my case with some escaping. I already created a hotfix branch with the fix under https://github.com/chrisism/plugin.program.advanced.emulator.launcher/tree/hotfix/quote_escaping_with_arguments
But before we possibly merge it, I was thinking if the simple escaping might give issues in situations that its not needed. This fix works in my case because I already use quotes around it for the arguments. But how would it work on a system with a launcher that doesn't quote its arguments when launching a rom with quotes? So this should be tested before the fix can be merged. Don't want to break it on other systems.

In X the joystick input doesn't get intercepted so the screen blanks during play.

It would be nice if the xset workaround was built into this launcher.

https://unix.stackexchange.com/questions/214803/how-to-prevent-dpms-screensaver-from-activating-when-gamepad-used

Hi when I launch steam big picture from advanced emulator launcher kodi exit the fullscreen even if I set the minimize kodi option to off.

I've been trying to set up AEL, but ran into a problem. How would I set up retroarch? I can't find the retroarch program to launch games. Retroplayer doesn't work for me and no games run.

Hi some rom path cannot be added for example if I set this path for my rom
~/Téléchargements/torrent/No-Intro/Nintendo - Nintendo 64/

I got this error

23:28:07 T:140391131113216   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <type 'exceptions.UnicodeDecodeError'>
                                            Error Contents: 'ascii' codec can't decode byte 0xc3 in position 11: ordinal not in range(128)
                                            Traceback (most recent call last):
                                              File "/home/mac/.kodi/addons/plugin.program.advanced.emulator.launcher/addon.py", line 45, in <module>
                                                plugin.run_plugin()
                                              File "/home/mac/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 197, in run_plugin
                                                self._command_add_new_launcher(args['catID'][0])
                                              File "/home/mac/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 743, in _command_add_new_launcher
                                                fs_write_catfile(CATEGORIES_FILE_PATH, self.categories, self.launchers)
                                              File "/home/mac/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/disk_IO.py", line 295, in fs_write_catfile
                                                str_list.append(XML_text('rompath', launcher['rompath']))
                                              File "/home/mac/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/disk_IO.py", line 209, in XML_text
                                                line = '  <{0}>{1}</{2}>\n'.format(tag_name.encode('utf-8'), tag_text.encode('utf-8'), tag_name.encode('utf-8'))
                                            UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 11: ordinal not in range(128)
                                            -->End of Python script error report<--

I have my NES rom collection in zip files (one per rom), and I also have my NES launcher configured to accept "nes|zip" for extensions. However, when I attempt to launch a rom using kodi's retroplayer, my only options are Hatari, FB Alpha, FB Alpha 2012, and Caprice32. If I unzip the rom so it has an nes extension, then I get the usual slew of Nintendo emulators, and I can choose Nestopia.

Hello,

I just tried to scrape covers online from mobygames and ran into an error. It seems the html code of the result page changed somehow and the handed url to urllib2 is empty. I do not know how the mobygames page worked before so I have no Idea if something changed.

Scraping with e.g. thegamedb works fine.

Tested in 0.97 and 0.98a, master branch gives some other error but I assumed that was work in progress for something else.

See the Log attached below.

ERROR: AEL INFO : _roms_import_roms() Starting ROM scanner ...
ERROR: AEL INFO : Launcher name "dolphin (Wii)"
ERROR: AEL INFO : launcher ID   "6659c57952b6a431b6cab4ed9bacd353"
ERROR: AEL INFO : ROM path  "/share/games/Console Games/Nintendo - Wii/"
ERROR: AEL INFO : ROM exts  "wbfs|iso"
ERROR: AEL INFO : Multidisc True
ERROR: AEL INFO : Platform  "Nintendo Wii"
ERROR: AEL INFO : Report file OP "special://profile/addon_data/plugin.program.advanced.emulator.launcher/reports/roms_root_category_dolphin_(Wii)_6659c5_report.txt"
ERROR: AEL INFO : Report file  P "/home/user/.kodi/userdata/addon_data/plugin.program.advanced.emulator.launcher/reports/roms_root_category_dolphin_(Wii)_6659c5_report.txt"
ERROR: AEL INFO : Launcher ROM database contain 0 items
ERROR: AEL INFO : Checking for unset artwork directories ...
ERROR: AEL INFO : Checking for duplicated artwork directories ...
ERROR: AEL INFO : No duplicated asset dirs found
ERROR: AEL INFO : Scanning and caching files in asset directories ...
DEBUG: DialogProgress::Open called
DEBUG: ------ Window Init (DialogConfirm.xml) ------
ERROR: AEL INFO : Removing dead ROMs ...
ERROR: AEL INFO : Launcher is empty. No dead ROM check.
DEBUG: DialogProgress::Open called (already running)!
DEBUG: ------ Window Init (DialogConfirm.xml) ------
ERROR: AEL INFO : Scanning files in /share/games/Console Games/Nintendo - Wii/
ERROR: AEL INFO : Recursive scan activated
ERROR: AEL INFO : File scanner found 63 files
DEBUG: DialogProgress::Open called (already running)!
DEBUG: ------ Window Init (DialogConfirm.xml) ------
ERROR: AEL INFO : ROM does not belong to a multidisc set.
ERROR: AEL ERROR: _roms_scrap_asset() Caching selected game "Dawn of Discovery / Nintendo Wii"
ERROR: AEL ERROR: _roms_scrap_asset() Scraper object ID 139837827862968 (name MobyGames)
ERROR: AEL ERROR: SingleInstance::__exit__() Unhandled excepcion in protected code
ERROR: EXCEPTION Thrown (PythonToCppException) : 

-->Python callback/script returned the following error<--- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
   Error Type: <type 'exceptions.ValueError'>
   Error Contents: unknown url type: 
   Traceback (most recent call last):
     File "/home/user/.kodi/addons/plugin.program.advanced.emulator.launcher/addon.py", line 39, in <module> main.Main().run_plugin()
     File "/home/user/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 270, in run_plugin self.run_protected(command, args)
     File "/home/user/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 363, in run_protected self._command_add_roms(args['launID'][0])
     File "/home/user/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 2401, in _command_add_roms self._roms_import_roms(launcher)
     File "/home/user/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 8809, in _roms_import_roms romdata = self._roms_process_scanned_ROM(launcherID, ROM)
     File "/home/user/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 9071, in _roms_process_scanned_ROM local_asset_list[i], ROM, launcher)
     File "/home/user/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 9252, in _roms_scrap_asset net_download_img(image_url, image_path)
     File "/home/user/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/net_IO.py", line 82, in net_download_img f.write(urllib2.urlopen(req).read())
     File "/usr/lib/python2.7/urllib2.py", line 154, in urlopen
return opener.open(url, data, timeout)
     File "/usr/lib/python2.7/urllib2.py", line 421, in open
protocol = req.get_type()
     File "/usr/lib/python2.7/urllib2.py", line 283, in get_type
   raise ValueError, "unknown url type: %s" % self.__original
   ValueError: unknown url type: 
-->End of Python script error report<--

19:29:50.638 T:139840363166080   DEBUG: ------ Window Init (DialogNotification.xml) ------
19:29:50.639 INFO: Python script stopped
19:29:50.639DEBUG: Thread LanguageInvoker 139838384019200 terminating
19:29:50.640 T:139840363166080   DEBUG: ------ Window Deinit (DialogConfirm.xml) ------
19:29:56.194 T:139840363166080   DEBUG: ------ Window Deinit (DialogNotification.xml) ------

Edit: TheGamesDB just seems to work for 0.98a as I stumbled accross Issue #52 ...

HI! Looks like I am stress testing your great work!
When scanning ROMs with "Metadata Scan Policy" set to "NFO Files" and "Add ROMs -> Scan for New ROMS" generates an error...

11:37:09 T:140658618652416 ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<-- - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS! Error Type: <type 'exceptions.AttributeError'> Error Contents: FileName instance has no attribute 'path_noext' Traceback (most recent call last): File "/home/ramesh/.kodi/addons/plugin.program.advanced.emulator.launcher/addon.py", line 42, in <module> plugin.run_plugin() File "/home/ramesh/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 243, in run_plugin self._command_add_roms(args['launID'][0]) File "/home/ramesh/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 1789, in _command_add_roms self._roms_import_roms(launcher) File "/home/ramesh/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 6446, in _roms_import_roms romdata = self._roms_process_scanned_ROM(launcherID, ROM) File "/home/ramesh/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 6554, in _roms_process_scanned_ROM nfo_file_path = FileName(ROM.path_noext + ".nfo") AttributeError: FileName instance has no attribute 'path_noext' -->End of Python script error report<--

Error is not generated if "Add ROMs -> Manually Add ROM". The ROM is added but the .nfo file is not read. Looking at your code in main.py line 6234, this appears to be expected behaviour and the metadata is meant to be added manually?

I think the first error is due to line 6563 in main.py:
nfo_file_path = FileName(ROM.path_noext + ".nfo")

Should be:
nfo_file_path = FileName(ROM.getPath_noext() + ".nfo")

Corrects the first error - All the ROMS are added and .nfo files are read with "Add ROMs -> Scan for New ROMS" but the second observation remains with "Add ROMs -> Manually Add ROM". The ROM is added but the .nfo file is not read. I presume this is expected.

Hello,

it is the first time I use AEL, but I cannot get rid of this error. After scraping, I select the correct game (so it does find the game in the database) but then it gives the error below.

https://pastebin.com/E3CsQxPX

Let me know what it can be.

Davide

Google translator:
Hi,
When I try add roms to emulators MAME and PC Engine, there is an error message. Previously, I re-installed the KODI system and moved old (and working) categories.xml to the directory: plugin.program.advanced.emulator.launcher
I also tried importing the AEL_config.xml file.

MAME report:

  Launcher name "Arcade/MAME"
  launcher ID   "209e51c3bca2fd5c3283433c6705b9d3"
  ROM path      "/var/media/PATYK-32GB/rom/mame/advancemame1.2/rom/"
  ROM ext       "zip"
  Platform      "MAME"
Loading launcher ROMs ...
  0 ROMs currently in database
Removing dead ROMs ...
Scanning files ...
  Directory /var/media/PATYK-32GB/rom/mame/advancemame1.2/rom/
  Found 45 files
Processing files ...
>>> /var/media/PATYK-32GB/rom/mame/advancemame1.2/rom/1941.zip
  Expected 'zip' extension detected
  ROM does not belong to a multidisc set.
  File not in launcher ROM list. Processing it ...

How to fix it?

Thank you for your help.

RPi3, Kodi 17.3, AEL 0.9.6, Gamestarter/RetroArch 8.164.4

EDIT
Once again I changed the categories.xml file to old one, and this time all emulators and roms are working.

Me and a couple of friends have a FTP server with a few ROMs, however AEL is not able to launch the ROMs from the server. It seems to only work via SMB.
Would you be able to implement support for FTP?

Hi commit 0d927b6 introduce a new error when adding rom :

18:00:56 T:140080316393216   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <type 'exceptions.TypeError'>
                                            Error Contents: write() argument 1 must be unicode, not str
                                            Traceback (most recent call last):
                                              File "/home/mac/.kodi/addons/plugin.program.advanced.emulator.launcher/addon.py", line 47, in <module>
                                                plugin.run_plugin()
                                              File "/home/mac/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 218, in run_plugin
                                                self._command_add_roms(args['launID'][0])
                                              File "/home/mac/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 1447, in _command_add_roms
                                                self._roms_import_roms(launcher)
                                              File "/home/mac/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 4431, in _roms_import_roms
                                                fs_write_ROMs(ROMS_DIR, selectedLauncher['roms_base_noext'], roms, selectedLauncher)
                                              File "/home/mac/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/disk_IO.py", line 421, in fs_write_ROMs
                                                fs_write_ROMs_JSON(roms_dir, roms_base_noext, roms, launcher)
                                              File "/home/mac/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/disk_IO.py", line 638, in fs_write_ROMs_JSON
                                                file.write(json_unicode.encode('utf-8'))
                                            TypeError: write() argument 1 must be unicode, not str
                                            -->End of Python script error report<--

Hi on advanced launcher it was the only scraper to properly scrape info for mame rom. Are you planning to reintroduce it in AEL ?

How can I fix the problem of no sound on linux when I launch an emulated game??

Using AL, I use a script to suspend kodi and launch a game; and I modify "launcher_plugin.py" file (~/.kodi/addons/plugin.program.advanced.launcher-master/resources/lib) in order to get both KODI and Advanced Launcher working with ALSA driver... but I cant find a solution for AEL

Really dont know if this is an issue per se... but for me it really is D:

Great addon BTW

Was removed in latest build.
Currently when I enter into AEL. the 3 options that I have are:

[Rom collections] (cant remove)
Favorites (cant remove)
Emulators (my folder with all my emulators)

I would LOVE to have the ability to add the folder "Emulators" back to Favorites.
So that I may add that Favorites link to my homepage. So I can launch directly there, without having to select "Emulators" 1st.

Its like having an Index.Html page with a link saying "click here to enter" that directs you to home.html
Extra step Id like to skip

Thank you

Apparently description, year and rating have been mislabeled (wrong tag) in the GameDBInfo of Sega MegaDrive.
See https://github.com/Wintermute0110/plugin.program.advanced.emulator.launcher/blob/master/GameDBInfo/Sega%20MegaDrive.xml

Example:
https://github.com/Wintermute0110/plugin.program.advanced.emulator.launcher/blob/master/GameDBInfo/Sega%20MegaDrive.xml#L10-L12

This causes the year to show up in kodi instead of the description.

Hi,

Getting the following error when trying to create a standalone launcher

23:12:54.893 T:140498625390336   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <type 'exceptions.KeyError'>
                                            Error Contents: 'assets_path'
                                            Traceback (most recent call last):
                                              File "/var/lib/kodi/.kodi/addons/plugin.program.advanced.emulator.launcher/addon.py", line 39, in <module>
                                                main.Main().run_plugin()
                                              File "/var/lib/kodi/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 305, in run_plugin
                                                self.run_protected(command, args)
                                              File "/var/lib/kodi/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 389, in run_protected
                                                self._command_add_new_launcher(args['catID'][0])
                                              File "/var/lib/kodi/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 988, in _command_add_new_launcher
                                                builder.createLauncher(categoryID, self.launchers, self.categories, self.settings, CATEGORIES_FILE_PATH)
                                              File "/var/lib/kodi/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/launcher_builder.py", line 168, in createLauncher
                                                assets_init_asset_dir(FileNameFactory.create(launcher['assets_path']), launcher)
                                            KeyError: 'assets_path'
                                            -->End of Python script error report<--

Hello whenever action I choose for this option the media continue to play.

Hi,

WIN10 64bit
KODI from win store 17.6

When I want to add an ROM to collection I get an error. I press "C" on a ROM then select "Add ROM to Collection" and after that error.

I thin k this is the right part, but I alos attached the LOG file.

15:05:26.630 T:1648 ERROR: AEL ERROR: SingleInstance::exit() Unhandled excepcion in protected code
15:05:26.635 T:1648 ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <type 'exceptions.KeyError'>
Error Contents: u'launcherID'
Traceback (most recent call last):
File "C:\Users\brand\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher\addon.py", line 39, in
main.Main().run_plugin()
File "C:\Users\brand\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher\resources\main.py", line 289, in run_plugin
self.run_protected(command, args)
File "C:\Users\brand\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher\resources\main.py", line 396, in run_protected
self._command_add_ROM_to_collection(args['catID'][0], args['launID'][0], args['romID'][0])
File "C:\Users\brand\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher\resources\main.py", line 5561, in _command_add_ROM_to_collection
virtualLauncherID = rom['launcherID']
KeyError: u'launcherID'
-->End of Python script error report<--
kodi.log

It seems that setting the "show batch command window" does not work for a .cmd file.
I like to disable the window, but it doesn't have impact.
When I make it a .bat file, it does reflect the setting.
However, when using .bat file, my rom parameter is not properly handled because my rom is located on a share that starts with \\. The .bat file handles this as \ what results in my rom not being found.
However, changing the .bat to .cmd does handle the rom path correctly.

Could you also make the property work for .cmd files?

Hi,

Sorry for opening an "issue" here; however, I'm not a Python developer and I was really just doing a tiny bit of hacking this evening to see if I could modify the AEL to work with RetroPlayer. I saw you mention on the Kodi.tv forums that you weren't sure how it works and, since I'm not a member there, I thought I'd share. I really don't consider myself competent enough to build this out and open a PR (this was literally my first time mucking with Python); but, I thought these things might be helpful.

I'm including a snippet below of what I did. Obviously, I was just hacking around; but, this does successfully launch a ROM from AEL into RetroPlayer.

One important note: it seems that RetroPlayer itself cannot introspect ZIP files by default (or maybe it's a configuration that I didn't mess with). I'm sure there's a way to have the add-on do it; however, in the interim, I simply extracted a few ROMS for testing The below code will launch and ask for which emulator to use and then launch the game in the selection. If the ROM is still zipped, you'll get the wrong options for emulators.

Basically, I replaced the 3 lines under "Execute External Application" with the below.

bc_romfile = os.path.basename(ROMFileName.getPath())
bc_listitem = xbmcgui.ListItem(bc_romfile, "0", "", "")
bc_parameters = {'Platform': 'Test Platform', 'Title': 'Test Game', 'URL': 'testurl'}
bc_listitem.setInfo( type='game', infoLabels=bc_parameters)
xbmc.Player().play(ROMFileName.getPath(), bc_listitem)

Hope this is helpful in integrating your addon with RetroPlayer. It seems like a match made in heaven! Thanks for the hard work!

Hi just upgraded to latest version i got an error when I try to create a standalone launcher

23:13:16 T:140391131113216   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <type 'exceptions.KeyError'>
                                            Error Contents: ('launchers_thumb_dir',)
                                            Traceback (most recent call last):
                                              File "/home/mac/.kodi/addons/plugin.program.advanced.emulator.launcher/addon.py", line 45, in <module>
                                                plugin.run_plugin()
                                              File "/home/mac/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 197, in run_plugin
                                                self._command_add_new_launcher(args['catID'][0])
                                              File "/home/mac/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 720, in _command_add_new_launcher
                                                thumb_path  = self.settings['launchers_thumb_dir']
                                            KeyError: ('launchers_thumb_dir',)
                                            -->End of Python script error report<--

Hi,

I'm running ArchLinux and Kodi from within fluxbox. I created a really simple launcher which just starts retroarch. When controlling retroarch with a gamepad it will also invisibly control kodi which still runs in background - possibly starting movies etc. Note that fixing issue #58 would automatically fix this bug, too.

Is it possible for you to add the ability to have multiple rom locations?
Thank you for your hard work and i love this addon!

20:06:03.956 T:2232 ERROR: XFILE::CDirectory::GetDirectory - Error getting plugin://plugin.program.advanced.emulator.launcher/?catID=a34da3225f7c4d50662dd6d5ea9383de&com=SHOW_ROMS&launID=693daf14ff92c7f6e9b5801f18fa4bb1
20:06:03.956 T:2232 ERROR: CGUIMediaWindow::GetDirectory(plugin://plugin.program.advanced.emulator.launcher/?catID=a34da3225f7c4d50662dd6d5ea9383de&com=SHOW_ROMS&launID=693daf14ff92c7f6e9b5801f18fa4bb1) failed
20:06:06.288 T:1340 ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <type 'exceptions.KeyError'>
Error Contents: (u'disks',)
Traceback (most recent call last):
File "C:\Users\kodi\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher\addon.py", line 42, in
plugin.run_plugin()
File "C:\Users\kodi\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher\resources\main.py", line 271, in run_plugin
self._command_render_roms(args['catID'][0], args['launID'][0])
File "C:\Users\kodi\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher\resources\main.py", line 3200, in _command_render_roms
self._gui_render_rom_row(categoryID, launcherID, roms[key], key in roms_fav_set, False)
File "C:\Users\kodi\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher\resources\main.py", line 3379, in _gui_render_rom_row
if rom['disks']: AEL_MultiDisc_bool_value = AEL_MULTIDISC_BOOL_VALUE_TRUE
KeyError: (u'disks',)
-->End of Python script error report<--
20:06:06.317 T:2232 ERROR: XFILE::CDirectory::GetDirectory - Error getting plugin://plugin.program.advanced.emulator.launcher/?catID=a34da3225f7c4d50662dd6d5ea9383de&com=SHOW_ROMS&launID=6bee77bd591d0a04d21bbf5fc92f961d
20:06:06.317 T:2232 ERROR: CGUIMediaWindow::GetDirectory(plugin://plugin.program.advanced.emulator.launcher/?catID=a34da3225f7c4d50662dd6d5ea9383de&com=SHOW_ROMS&launID=6bee77bd591d0a04d21bbf5fc92f961d) failed

in the file resources/settings.xml

section beginning line 67

<setting id="separator" type="lsep" label="ROM tags"/> <setting label="Display ROM in Favourites tag" type="bool" id="display_rom_in_fav" default="true" /> <setting label="Display ROM audit tag" type="bool" id="display_nointro_stat" default="true" /> <setting label="Display ROM in Favourites tag" type="bool" id="display_fav_status" default="true" />

the label for line 70 (display_fav_status) is a duplicate of line 68 (display_rom_in_fav)
I propose updating the line 70 (display_fav_status) label for clarity.

display_fav_status only seems to add: (OK) to the rom title / description within 'favorites'
In the event the rom is no longer available, does (OK) change to alert the user?

when attempting to add ROMs for the first time I am getting this error:

11:27:01 T:10860 ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <type 'exceptions.NameError'>
Error Contents: global name 'local_title' is not defined
Traceback (most recent call last):
File "C:\Users\jader\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher\addon.py", line 47, in
plugin.run_plugin()
File "C:\Users\jader\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher\resources\main.py", line 218, in run_plugin
self._command_add_roms(args['launID'][0])
File "C:\Users\jader\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher\resources\main.py", line 1447, in _command_add_roms
self._roms_import_roms(launcher)
File "C:\Users\jader\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher\resources\main.py", line 4386, in _roms_import_roms
romdata = self._roms_process_scanned_ROM(launcherID, ROM)
File "C:\Users\jader\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher\resources\main.py", line 4598, in _roms_process_scanned_ROM
selected_title = self._roms_process_asset_policy_2(ASSET_TITLE, local_title, ROM, launcher)
NameError: global name 'local_title' is not defined
-->End of Python script error report<--

It seems that having a unicode character in the filename of a rom causes the scraper (occurs when using GamesDB, but should apply to all scrapers) to fail with the following stack trace:

1:44:56.477 T:139951996065536 ERROR: /usr/lib/python2.7/urllib.py:1298: UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal return ''.join(map(quoter, s)) 11:44:56.477 T:139951996065536 ERROR: AEL ERROR: SingleInstance::__exit__() Unhandled excepcion in protected code 11:44:56.483 T:139951996065536 ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<-- - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS! Error Type: <type 'exceptions.KeyError'> Error Contents: u'\xe8' Traceback (most recent call last): File "/home/loucipher/.kodi/addons/plugin.program.advanced.emulator.launcher/addon.py", line 39, in <module> main.Main().run_plugin() File "/home/loucipher/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 270, in run_plugin self.run_protected(command, args) File "/home/loucipher/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 363, in run_protected self._command_add_roms(args['launID'][0]) File "/home/loucipher/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 2401, in _command_add_roms self._roms_import_roms(launcher) File "/home/loucipher/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 8809, in _roms_import_roms romdata = self._roms_process_scanned_ROM(launcherID, ROM) File "/home/loucipher/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 8972, in _roms_process_scanned_ROM results = self.scraper_data.get_search(rom_name_scraping, ROM.getBase_noext(), platform) File "/home/loucipher/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/scrap_metadata.py", line 203, in get_search return Scraper_TheGamesDB.get_search(self, search_string, rom_base_noext, platform) File "/home/loucipher/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/scrap_common.py", line 74, in get_search 'name=' + urllib.quote_plus(search_string) + '&platform=' + urllib.quote_plus(scraper_platform) File "/usr/lib/python2.7/urllib.py", line 1303, in quote_plus s = quote(s, safe + ' ') File "/usr/lib/python2.7/urllib.py", line 1298, in quote return ''.join(map(quoter, s)) KeyError: u'\xe8' -->End of Python script error report<--

This is probably because the OS (this is on 64 bit debian sid) is returning the filename with a different character encoding than what AEL expects/uses for all its strings (probably defaults to ascii?), causing urllib.quote() to fail. I'm personally of the opinion that the best solution to this is to use utf-8 for all strings, converting whatever filename strings the OS returns from ascii to utf-8 as necessary, thereby allowing unicode characters in filenames (the example filename that was crashing my scrapes is 'Andrè Agassi Tennis (U).bin'). But, that's my initial gut reaction, it could well be that GamesDB doesn't support unicode, in which case the solution is to either convert all utf-8 strings to ascii, or we just have to settle for renaming rom files to ascii-only strings.

(I do realize that the example filename I gave is wrong, turns out his name is properly spelled Andre and not Andrè, but it does expose what could be an issue with, for example, import roms that have Japanese characters in their name. I had the same issue with 720 Degrees for the NES, my rom was named 720°)

And on a related note, it would be nice if the scraper would fail gracefully and have a resume/scrape missing option. Right now, if you hit this error, the scraper bombs out, and you have no roms in your launcher. It would be a nice feature if it would write out the xml for what it's already scraped (I'm planning to make a branch to implement this, time permitting), and allow you to resume scanning the folder (unless there's a way to do this now and I'm missing it). I was lucky that my errors happened alphabetically early, this would suck had I already scraped 99% of my library and one failure caused me to have to re-scrape the entire thing!

Love this plugin, it's completely replaced the venerable romcollectionbrowser for me!

Listed below is the kodi.log Error that i get when i try to add a trailer to one of my roms.

-Kodi v.16 Jarvis
-Windows 7
(Rdyott on kodi forums)

https://youtu.be/QSuT1Dh-2PI

18:45:51 T:7396   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <type 'exceptions.UnboundLocalError'>
                                            Error Contents: local variable 'app' referenced before assignment
                                            Traceback (most recent call last):
                                              File "C:\Users\Monki\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher-master\addon.py", line 45, in <module>
                                                plugin.run_plugin()
                                              File "C:\Users\Monki\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher-master\resources\main.py", line 237, in run_plugin
                                                self._command_edit_rom(args['catID'][0], args['launID'][0], args['romID'][0])
                                              File "C:\Users\Monki\AppData\Roaming\Kodi\addons\plugin.program.advanced.emulator.launcher-master\resources\main.py", line 1397, in _command_edit_rom
                                                if not app: return
                                            UnboundLocalError: local variable 'app' referenced before assignment
                                            -->End of Python script error report<--

Hi with latest git version I can no longer scrape metadata, here the error in kodi.log :

21:50:19.196 T:139866616624896   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <type 'exceptions.NameError'>
                                            Error Contents: global name 'text_clean_ROM_name_for_scraping' is not defined
                                            Traceback (most recent call last):
                                              File "/home/mac/.kodi/addons/plugin.program.advanced.emulator.launcher/addon.py", line 42, in <module>
                                                plugin.run_plugin()
                                              File "/home/mac/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 243, in run_plugin
                                                self._command_add_roms(args['launID'][0])
                                              File "/home/mac/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 1793, in _command_add_roms
                                                self._roms_import_roms(launcher)
                                              File "/home/mac/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 6414, in _roms_import_roms
                                                romdata     = self._roms_process_scanned_ROM(launcherID, ROM)
                                              File "/home/mac/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 6619, in _roms_process_scanned_ROM
                                                romdata[A.key] = self._roms_scrap_asset(asset_kind, local_asset_list[i], ROM, launcher)
                                              File "/home/mac/.kodi/addons/plugin.program.advanced.emulator.launcher/resources/main.py", line 6678, in _roms_scrap_asset
                                                rom_name_scraping = text_clean_ROM_name_for_scraping(ROM.getBasename_noext())
                                            NameError: global name 'text_clean_ROM_name_for_scraping' is not defined
                                            -->End of Python script error report<--

Hi,

Sorry if I'm missing something, but when I try to add a standalone game, it comes up with a "Select launcher application" dialogue, and the only option is SuperRepo (a repository I installed earlier). Do I need to install something else before I can add standalone software with AEP?

Thanks in advance,
Aston