Giter VIP home page Giter VIP logo

Comments (11)

Wintermute0110 avatar Wintermute0110 commented on September 13, 2024 1

No, I didn't touch the scrapers in 0.9.7. 0.9.8 will be the "scrapers edition" and I plan to polish the scrapers a lot, also finally adding the Levenshtein distance algortihm. Unfortunately, my free time during Christmas season is going to be very limited.

OK, no problem at all updating the submodules in AEL-offline-scraper. I have already done it for you.

from plugin.program.ael.dev.

Wintermute0110 avatar Wintermute0110 commented on September 13, 2024 1

This was fixed some time ago so I'm closing this issue. There are still some problems with the offline scraper, I will solve those when I had time.

from plugin.program.ael.dev.

Wintermute0110 avatar Wintermute0110 commented on September 13, 2024

Thanks for reporting. Offline scraper will be fixed in 0.9.8. It's a huge task and will take some time, though.

from plugin.program.ael.dev.

h3llrais3r avatar h3llrais3r commented on September 13, 2024

I think this could be easily done with some xslt transformation 😉
EDIT: sorry for asking, but any idea when 0.9.8 will be released? If no deadline yet, no worries, I'll dowload the latest version from master branch.

from plugin.program.ael.dev.

h3llrais3r avatar h3llrais3r commented on September 13, 2024

@Wintermute0110 Please find in attachment a fixed version of the "Sega Megadrive.xml".
I've changed it by applying some xslt transformations. Feel free to check it out and use it if it suits your needs. 😉 It's not in the exact layout (empty elements are in short notation like <crc/> instead of <crc></crc>) so you'll probably want to do some modifications.

EDIT: apparently there are still some strange characters (�) inside the xml, so they are also in the fixed version... 😢

Sega MegaDrive - fixed.zip

from plugin.program.ael.dev.

Wintermute0110 avatar Wintermute0110 commented on September 13, 2024

Thanks a lot for your help.

Yeah, changing one XML is easy. What is a huge task is to fix all the XMLs.

Have a look at this repo. The original files of the offline scraper are CSV files made by Billyc666 and the problem is that some of the CSV files are wrong. Currently, convert_GameDBInfo_CVS_to_XML.py converts the CSV files to XML and that Python file is the one that needs a fix.

For 0.9.8, I plan to combine the XML output files produced by convert_GameDBInfo_CVS_to_XML.py with a No-Intro or Redump DAT file to produce the final offline scraper XML. Once the CSV to XML conversion is fixed I will abandon the CSV files forever and keep using the XML only. Users will be able to edit the XML to improve the Offline Scraper database.

Still there are some things I have to think about like Parent/Clone generation. 0.9.8 is going to take some time to develop and I will be somewhat busy with real life in the next months. I would say a realistic release time for 0.9.8 could be February or March 2018.

from plugin.program.ael.dev.

h3llrais3r avatar h3llrais3r commented on September 13, 2024

I just ran the converter for csv to xml and the data for Sega MegaDrive is correct (Description, year and rating is correct). The xml for Sega MegaDrive in your plugin is not the same as the output generated by the converter... is this normal?

from plugin.program.ael.dev.

h3llrais3r avatar h3llrais3r commented on September 13, 2024

Made 2 PR's that may already help you:
Wintermute0110/Game-database-info#3
#50

When generating the xml's from csv's with these changes, a lot of errors are fixed.

from plugin.program.ael.dev.

Wintermute0110 avatar Wintermute0110 commented on September 13, 2024

I just ran the converter for csv to xml and the data for Sega MegaDrive is correct (Description, year and rating is correct). The xml for Sega MegaDrive in your plugin is not the same as the output generated by the converter... is this normal?

AEL-offline-repo is still in the design state, so expect incomplete stuff. Also, I have some uncommited files in one of my computers. As soon as I have some time I will update that repo.

from plugin.program.ael.dev.

h3llrais3r avatar h3llrais3r commented on September 13, 2024

@Wintermute0110 You didn't regenerate the gamedbinfo xml files for release 0.9.7?
Sega MegaDrive still has wrong xml tags.

EDIT: just wondering I see that the repo's AEL-offline-scraper, Game-database-info and plugin.program.advanced.emulator.launcher are linked via submodules.
I can run the csv to xml conversion from the AEL-offline-scraper repo, but I need to use the latest version of the Game-database-info csv files...
Can I update those links to the submodules and create PR's for that? Or do you need to do that?
I'm not used to work with submodules... 😊

from plugin.program.ael.dev.

h3llrais3r avatar h3llrais3r commented on September 13, 2024

Thanks. No need to rush. My time is also limited, and it's not that this is really urgent. 😉

from plugin.program.ael.dev.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.