yazninja / itheme Goto Github PK

Currently the icons on the top bar have a boarder behind them like here with the lyrics button:

But the Queue button doesn't have one, same if its toggled;

The specific situation is shown below (due to network problems, there is a chance that the picture can not be displayed properly)

In addition, my screen resolution is 2560 * 1600, the scaling ratio is 200%, the screen ratio is 10:9 (my kind of screen should be relatively rare)
Hope this information is useful to you, thanks.

(Can't decide if this is a bug or not so you decide) When using Inline Drawers, it is visible behind the top bar, its most noticable when Mica is on as seen in the picture below. The drawers should stop before it reaches the top bar and not go behind it. {p.s. I actually like this, think it looks cool and makes sense}

In the same way, scrollbars tend to not be cutoff at the top bar and instead are infront of it. This actually still happens with the queue and lyrics closed as seen here;

The queue section has many clipping issues, mainly stuff like the song time and explicit tag will clip through the text, lines will also be cutoff early etc as seen below.

Compared to AM web below, AM web doesnt display the album title next to the Artist, as i know it might not be possible to remove this from Cider at the minute, outright removing the song lengh could fix this, but other than that it just looks.. off to me. AM web feels like how it should look in Cider yet it don't.

The middle part of the top bar that shows the song title and artist doesn't have any transparency on light mode as seen below;

This is how it looks in dark mode for reference;

While using this theme I have noticed that the Queue and Cast buttons disapear when the window gets smaller. This appears to be specific to this theme as I have not been able to recreate this behaviour with the stock appearence.

Basic structure

#app
 - default theme variables (perrably dark)
 - modals/popup global changes
#app-main
 - app main compontnts global changes

@media light
 #app
  -light theme variables
  -light modal/popup changes (might use variable instead of repetative code)
 #app-main
   - app main light component changes

@media dark
 #app
  -dark theme variables
  -dark modal/popup changes
 #app-main
   - app main dark component changes

Addtional Tasks

• combine and clustetize selectors out to in following structure of app
• add helpful comments for code review
• add support for redmond

Thought you'd miss this :)

Playback controls too far left and leaks into the left pane.

Apple Music profile picture and Cider title at the top left/top of the left pane are both askew and not centred at the top of the left pane.

For mostly every small context menu, the highlight box is misaligned, see below picture and video:

https://user-images.githubusercontent.com/93286201/165977241-5348faf9-d094-4b26-8e2a-c91b1734e4b0.mp4

Same issue seen in #3, when in the tab view you can't read the text because its black on black in light mode.

I also had a hard time clicking on the queue button, clicking on the lyric button takes you straight to it and works all the time, but the queue button takes a couple of clicks and moving your mouse around before it finally clicks on it, maybe a bug there?

I love the old fashion iTunes style, but these play control buttons inclined to the left

env: Windows 11, Cider 1.5.0(Microsoft Store), 3840×2160(150% scale)

Currently, artist artwork in the artist page has a much smaller hight than that of the web page or Mac AM, this results in most of the video being cut off and strange to look at. What should happen is the video artwork should be increased in height in order to display more of the video and have it more natural looking. Below is what it looks like on the web which is a good size and you can see mostly all of the artists face, and below that is what your theme has, which only shows around half or under half of her face, which is not good to look at.

So for light mode firstly, the colour for this logo is the wrong colour, should be black. Secondly, in both colour modes the text is cutoff.

Ok so techinally from a CSS point of view, this is alligned. However from just looking at it its not alligned.

When you view a playlist or a album that has only songs and nothing else (featured on, music videos, extras etc) the iTheme fade effect conflicts with the Cider fade effect added by Booploops, causing a mismatch in them both.

The Artist name is in white when in light mode, white on white making it almost impossible to read it.

The hearts in the song view are not centered.

As you see, black text on black shifting background makes it very hard to read the text.

See picture above

Big popout content menus in Darkmode use a hard black colour instead of using the mica-grey colour standard used in the small context menus and other areas of iTheme.

what it looks like now, pure black:

What it should be using, mica-grey colour:

Cannot click on these buttons labled "View all" in The Listen Now and Browse tab.

playlist icon having kinda sorta bad color

yay

Hard to explain but if you look above the search bar and at the nav buttons when I scroll, due to the Mica effect I'm guessing its causing it to look weird because the search bar has a much harder blur than the nav buttons, then its cut off by the top bar which all together makes scrolling look weird in this tab. If the nav bar had the same blur as the search bar in this specific tab I think it would fix the issue.

There is no blur effect in the control bar and lyrics area
It's completely transparent.

Did i set something wrong?

TLDR is they are in dark mode and not light mode when the theme is in light mode.
I checked the other menus under the drop down menu and they are fine so its just these 4.

Web remotes not too bad, but the text is a bit faded.

Cast is unreadable lol, defiantly needs a colour change.

Audio settings and Plug-Ins isn't too bad, but is in dark mode when the theme is in light mode.

Solution:
The theme has been updated and requires Cider version 1.3.1539 or above to show profile pictures.
Using winget? Update with this command:
winget upgrade CiderCollective.Cider.Nightly

As you can see, the text telling you whether a song is loved or not is behind the main menu text, making it unreadable, it should be on the forefront in front of the main menu.

You also cannot visually tell if the song is loved or not, other themes or default Cider fill it in with a easy to see colour but its not done here. Maybe fill in the whole heart instead of the outline?

In library, if song name&album name&artist name is too long, this row's layout is broken

Both light and dark mode have misaligned play buttons for albums.

After update iTheme to last version (3.2.2), I found Album view text covered the UI on top of it.
It only happens on Album page view and Recently added page only.

Album view on Browse page works well.

Temprorary workaround is disable iTheme

Cider 1.5.1-beta 455 on Windows 11 via winget

Currently when you select a artist in the artist page, it doesn't highlight that artist as seen in this picture below:

This makes it hard to see the selected artist in the sideview, I suggest it highlights it like in the image below:

So a bit hard to explain, but on dark mode as you see here, when you hover the mouse over the tabs here, such as the songs tab, it highlights it;

But heres how it looks on light mode, you can barely see it;

1. as shown in the screenshort, Part of the arrow icon is covered by the album cover

2. The page incorrectly jumps to the album details page when I click with the mouse on the place I circled, which is a part of arrow icon
   
   and when i click the centor of the icon, the cover moved a little.

Sorry for the non descriptive title I don't know what this is called lol, the waiting dots? lol,. Either way, With the white theme the text is black on a white background and I'm guessing these dots should be black too but they are white instead, therefore making them quite hard to see.

As you see below, right clicking a playlist on the sidebar brings up a context menu with misaligned text:

So a bit hard to explain, but the space next to the artwork to the left is not transparent but instead white, this means it doesn't seamlessly transition and so looks off.

When toggling Hide Library while using Mojave layout there are 2 noticeable anomalies:

• Top nav bar is see through where the Library bar once was:
  

• Playbar remains at the default position thus leaves a wide space where the library bar once was:
  

I know you are aware of this, so I thought I'd make a bug report to keep track of it.

What it looked like before:

What it looks like now:

I think this has something to do with the length of the window, currently, the 1040x600 size for the window will not show either.

On Albums they will typically have little Stars next to the songs that are the most popular, for example, Positions by Ariana Grande has the song Positions as the most popular one in the Album, hence the Star next to it.

However in your theme, the colours are the exact same as the background expect for a slight tink that its almost impossible to see (try finding it in the first image, bet you cant :)

As the title says, when playing a song from the Songs Library, its missing the Now Playing animation.

What it looks like:

Its suppose to have this:

As shown, when the music is playing it removes the heart from the song and replaces it with nothingness.
It would be looking perfect

On light mode its coloured, on dark its not..