yazninja / itheme Goto Github PK
View Code? Open in Web Editor NEWiTheme
License: MIT License
iTheme
License: MIT License
On Albums they will typically have little Stars next to the songs that are the most popular, for example, Positions by Ariana Grande has the song Positions as the most popular one in the Album, hence the Star next to it.
However in your theme, the colours are the exact same as the background expect for a slight tink that its almost impossible to see (try finding it in the first image, bet you cant :)
TLDR is they are in dark mode and not light mode when the theme is in light mode.
I checked the other menus under the drop down menu and they are fine so its just these 4.
Web remotes not too bad, but the text is a bit faded.
Cast is unreadable lol, defiantly needs a colour change.
Audio settings and Plug-Ins isn't too bad, but is in dark mode when the theme is in light mode.
Hard to explain but if you look above the search bar and at the nav buttons when I scroll, due to the Mica effect I'm guessing its causing it to look weird because the search bar has a much harder blur than the nav buttons, then its cut off by the top bar which all together makes scrolling look weird in this tab. If the nav bar had the same blur as the search bar in this specific tab I think it would fix the issue.
Currently, artist artwork in the artist page has a much smaller hight than that of the web page or Mac AM, this results in most of the video being cut off and strange to look at. What should happen is the video artwork should be increased in height in order to display more of the video and have it more natural looking. Below is what it looks like on the web which is a good size and you can see mostly all of the artists face, and below that is what your theme has, which only shows around half or under half of her face, which is not good to look at.
As you can see, the text telling you whether a song is loved or not is behind the main menu text, making it unreadable, it should be on the forefront in front of the main menu.
You also cannot visually tell if the song is loved or not, other themes or default Cider fill it in with a easy to see colour but its not done here. Maybe fill in the whole heart instead of the outline?
(Can't decide if this is a bug or not so you decide) When using Inline Drawers, it is visible behind the top bar, its most noticable when Mica is on as seen in the picture below. The drawers should stop before it reaches the top bar and not go behind it. {p.s. I actually like this, think it looks cool and makes sense}
In the same way, scrollbars tend to not be cutoff at the top bar and instead are infront of it. This actually still happens with the queue and lyrics closed as seen here;
Basic structure
#app
- default theme variables (perrably dark)
- modals/popup global changes
#app-main
- app main compontnts global changes
@media light
#app
-light theme variables
-light modal/popup changes (might use variable instead of repetative code)
#app-main
- app main light component changes
@media dark
#app
-dark theme variables
-dark modal/popup changes
#app-main
- app main dark component changes
Addtional Tasks
Solution:
The theme has been updated and requires Cider version 1.3.1539 or above to show profile pictures.
Using winget? Update with this command:
winget upgrade CiderCollective.Cider.Nightly
Same issue seen in #3, when in the tab view you can't read the text because its black on black in light mode.
I also had a hard time clicking on the queue button, clicking on the lyric button takes you straight to it and works all the time, but the queue button takes a couple of clicks and moving your mouse around before it finally clicks on it, maybe a bug there?
In library, if song name&album name&artist name is too long, this row's layout is broken
The specific situation is shown below (due to network problems, there is a chance that the picture can not be displayed properly)
In addition, my screen resolution is 2560 * 1600, the scaling ratio is 200%, the screen ratio is 10:9 (my kind of screen should be relatively rare)
Hope this information is useful to you, thanks.
For mostly every small context menu, the highlight box is misaligned, see below picture and video:
https://user-images.githubusercontent.com/93286201/165977241-5348faf9-d094-4b26-8e2a-c91b1734e4b0.mp4
The queue section has many clipping issues, mainly stuff like the song time and explicit tag will clip through the text, lines will also be cutoff early etc as seen below.
Compared to AM web below, AM web doesnt display the album title next to the Artist, as i know it might not be possible to remove this from Cider at the minute, outright removing the song lengh could fix this, but other than that it just looks.. off to me. AM web feels like how it should look in Cider yet it don't.
While using this theme I have noticed that the Queue and Cast buttons disapear when the window gets smaller. This appears to be specific to this theme as I have not been able to recreate this behaviour with the stock appearence.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.