Giter VIP home page Giter VIP logo

Comments (3)

jihoonl avatar jihoonl commented on July 26, 2024

It was to reduce my headache to make internal launch convenient. I still think it is good to keep it here.

Instead, we can replace these params to free the turtlebot_dependency.

from yujin_ocs.

bit-pirate avatar bit-pirate commented on July 26, 2024

What is "internal launch"? If you are using this launcher inside larger launchers, e.g. for turtlebot, waiterbot, then please add move_base, velocity smoother etc. there.

from yujin_ocs.

jihoonl avatar jihoonl commented on July 26, 2024

Can you explain what benefits are there not to keep them in the package?
I kept them in the package for these reasons.

  • don't want to keep the same launch files for every robot with small configuration changes.
  • move_base and vel_smoother are used for all of our robots anyway.

It is possible to keep move_base and vel_smoother for every robot. But I kept them for these convenient reasons. Also I don't think it badly hurting dependencies since these modules are mostly required for all of our robots anyway.

from yujin_ocs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.