zeeguu / web Goto Github PK

here i felt like saying, "i'm not sure of this translation".
actually it should be "bad translation".

• "back to reading" is not centered in the button.
• they are aligned center page while words are to their left
• "more exercises" - sounds like it might be interpreted as "other exercises" while instead it means "one more round of exercises"

it's not nice!

looking at the past user interactions, it seems that there were 600 times when the users have selected this option in the past (when it was present).

I wonder if we should add it back in.

tagging @SaraTolstrupHusum for her teaching expertise :)

the first time i click on the Classroom Language dropbox it always auto-closes :)

From Pernille:

2. The UI works in Danish - YEAH!! :) A suggestion could be to make it possible to make the choice independent of native language, since this preference won't always be connected to the native language. A minor thing again..

To migrate:

• FeedbackButtons.css
• FindWordInContext.css

e.g. see how we did it in TranslatableText.sc.js.

To remove since they're not used anywhere anymore:

• newStyleWords.css
• Exercises.css

maybe a bold?

"getReadingSessions" object should include:

• readingSession (date),
• title of article,
• articleID,
• article length,
• article level,
• time spent on reading the article,
• a list of translated words in sentences with translations and isExercised boolean depending on duration.

api.getReadingSessions(studentID, cohortID, duration) - returns a list of "readingSessions" objects of what reading sessions the student has completed within the time period.

based on mircea's practice, they seem to be missing:

• I learned/know this already!
• bad translation
• I'm not sure about this...

Bad_translation was actually used 91 times in the past... when it was a possible feedback option

• one thing that might be great actually, is to allow the learner to "update" the translation if they know it is wrong and they want to fix it!

"other" should provide the learner the chance to type in their feedback!

it used to be like that but we didn't port it yet!

src/teacher/DeleteTextWarning.js
Line 11:9: 'history' is assigned a value but never used no-unused-vars

src/teacher/StudentInfoLine.sc.js
Line 2:20: 'lightGrey' is defined but never used no-unused-vars

This would allow teachers to upload text with pictures too.
Would also pave the way for the Readability-like extension.

Could this be the first specialized hook from Zeeguu-React? :)

import LandingPage from "./landingPage/LandingPage";
@@ -28,13 +28,25 @@ function App() {

  const [uiLanguage, setUiLanguage] = useState(LocalStorage.getUiLanguage());

  useEffect(() => {
    const uiLang = LocalStorage.getUiLanguage();
    if (uiLang === undefined) {
      LocalStorage.setUiLanguage({ code: "en" });
    }
    setUiLanguage(uiLang);
  }, []);

  useEffect(() => {
    if (uiLanguage !== undefined) strings.setLanguage(uiLanguage.code);
  }, [uiLanguage]);

To improve the readability of the code.

I have the impression that it's quite large by default on a laptop screen.

On my MacBook Pro 13' the article page looks like:

zooming out to 80% looks already a bit better:

we must!

it's visually interfering with the translation now.

We must increase the spaces between the title and translations.

in this particular case i've got it after the second
try but I still don't know the word :))

alternative: make the whole text translatable as in the reader, and let me interact with it?

Teacher should be able to delete texts without first unattaching classes and vice versa.

So, the two endpoints need to be modified to allow removal of classes and texts without the need of unattaching texts from classes and classes from texts: "delete_own_text" and "/remove_cohort/${cohortID}".

Some OSes like OS X come with a bunch of voices for text-to-speech preloaded.

On some others, e.g. Microsoft, only English text-to-speech support is present by default.

If the absence of the appropriate support for the learned language is detected, a popup could inform the learner about the steps they can take to add that support.

Steps for Windows are straightforward (verified by Mircea)

Some more detailed steps on StackOverflow (including explicitly downloading TTS)

Allow users to delete the texts they saved using the Zeeguu extension

How should this be implemented?
New ArticlePreview component?
Modification to existing ArticlePreview component?

it's cute, it's like a nudge :)

@mariatim

we've talked about this, but i'm adding it here, so it's in writing:

• the user dashboard graphs should have some minimum default y-axis. e.g. for daily it should be 15min, for weekly should be 60, and for monthly should be 300 or something like that. otherwise we end up with these huge bars that represent 2min. it feels wrong.

or at least it feels wrong for me. what do you think @mariatim ?

At least in Exercises.js the source of feedback is always Recognize_L1W_in_L2T as in the snippet below. Must check if feedback is uploaded in other places in the code too.

function stopShowingThisFeedback(reason) {
    moveToNextExercise();
    api.uploadExerciseFeedback(
      reason,
      "Recognize_L1W_in_L2T",
      0,
      currentBookmarkToStudy.id
    );
    setShowFeedbackButtons(false);
  }

simplest thing: tell them to write email to [email protected].

mostly a backend thing actually.

living doc

start with:

• VSC extensions

I just realized that Sara was not aware of the fact that teachers can share classes.
I guess the first step towards righting that wrong is to update the class info with the list of current teachers.
to support this I've updated the cohort_info endpoints with info about teachers.
/cohort_info returns now a teachers_for_cohort list that looks like this:

{
"cur_students": 20,
"declared_level_max": 10,
"declared_level_min": 0,
"id": "121",
"inv_code": "dui1",
"language_name": "German",
"max_students": 21,
"name": "4H dui1",
"teachers_for_cohort": [
    {
        "email": "[email protected]",
        "user_id": 123,
        "name": "Berti",
    },
    {
        "email": "[email protected]",
        "user_id": 124,
        "name": "Maria",
    }
]

}

Abstract JSON parsing and stringifying into LocalStorage.js for all methods

@mircealungu: May I, please?

probably also some more lint-ing?

If practicing words in specific text, no nudge to read more. In general exercises, nudge to read more to unlock.
If 0 bookmarks: nothing to study, go and read more.

it's not being referenced anymore

src/userDashboard/UserDashboard.js
Line 88:6: React Hook useEffect has a missing dependency: 'api'. Either include it or remove the dependency array react-hooks/exhaustive-deps
Line 106:6: React Hook useEffect has a missing dependency: 'api'. Either include it or remove the dependency array react-hooks/exhaustive-deps
Line 114:7: Imported JSX component UserDashboard_Top must be in PascalCase or SCREAMING_SNAKE_CASE react/jsx-pascal-case

Become a betatester" is currently the primary option. (2 out of 3 teachers go to that first)

Two endpoints need to be modified to allow removal of classes and texts without the need of unattaching texts from classes and classes from texts: "delete_own_text" and "/remove_cohort/${cohortID}".

In some styled components, there are unused classes.
All components should have get a sweep-though.

would be nice to have: see zeeguu.org for examples (usually exercise 3 and 4 from easy)

it's called three times for the first exercise:

also, if I arrive at the end, and I start another session I get really strange behavior :(

i.e.

• the second exercise (multiple choice) ends up changing options live - after wait, it's rendered, and then, while I'm looking at it, it rerenders with different options (maybe also different exercise? I'm not sure)
• as it rerenders, at some point I see four options in the bottom choices

• by now, the backend has received a lot of calls to /bookmarks_to_study and /similar_words (16 calls in total more exactly)

the input box is "shaking" a bit on a wrong answer in the original zeeguu.org ... something like that, or something else, but... some feedback should be provided :)

We’re missing the “Asked_for_hint” exercise outcome that should be reported

Although what we could do is to send higher-level info instead of sending an asked-for-hint followed by a correct (which would require extra work on the backend to merge multiple interactions with the same bookmark):

• correct from the 1st attempt (this includes typo-forgiving input)
• correct from the 2nd attempt (either because of asking for a hint or because of trying the wrong multiple-choice option)
• incorrect after exhausting all the options (clicked through all the hints / tried out all the alternatives)

can we localize the menu in danish?
seems that some students could benefit from that!

for danish at least, sometimes you click on the 'speak' button and you have to wait for more than 1s w/o any visual feedback.
it would be nice if there was some way, any way, to hint at the fact that the system is working. pulse the button, show a spinner, animate the Speak text... anything :)

somewhere to the right of the foreign language word: