Response emitter not setting Content-Length about zend-diactoros HOT 4 CLOSED

That's a great catch; I think it should be the job of the emitter, to be honest. Considering the information is in the response stream already (via getSize()), it could be something like this:

if (! $response->hasHeader('Content-Length')) {
    $response = $response->withHeader('Content-Length', $response->getBody()->getSize());
}

That could even be provided as a trait method (e.g., injectContentLength(ResponseInterface $response): ResponseInterface), which emitters can then compose in order to provide this functionality.

Want to give it a whirl, @mnapoli ?

from zend-diactoros.

Great, that will also simplify my code. It's on my todo list then!

from zend-diactoros.

This was fixed by #88.

from zend-diactoros.

@mnapoli @weierophinney A little late to the game, but why exactly was this added? AFAIK, Content-Length is only needed for downloads.

I am asking because we have some issue reports about truncated JSON responses for Flarum which seem to have to do with this header not matching the true content length.

EDIT: Fixed the issue link.

from zend-diactoros.