Inline rendering only shows the first line of properties in reading view about obsidian-dataview HOT 10 CLOSED

This bug is actually not exclusive to mobile, as I also see the same behavior on desktop.

from obsidian-dataview.

This sounds a lot like ##2216, which sadly I'm not sure if we're able to correct, or whether we need to code some workaround to avoid this happening.

from obsidian-dataview.

That's sad to hear as I do prefer reviewing my notes in reading mode... If you are familiar with this issue, can you give a technical rundown of where the issue is stemming or what files are involved in inline rendering. That way more eyes can get up to speed with the issue and thus may bring us closer to a possible fix.

-edit-
I noticed that there is some detail that you provided in the issue you linked. If there isn't any new findings then that's ok. Thanks for having looked into it.

from obsidian-dataview.

It's documented in that linked issue. The bug(s) was introduced after 0.5.59, and is related to a double rendering of text as markdown, where in the new (and buggy) version it assumes it gets the current line of a list item, but it receives the entire block of the list, which results in a faulty re-rendering.

from obsidian-dataview.

I've been contemplating to "hide" all the related changes of this bug under some experimental setting within Dataview, but it's a lot of code which needs to be reviewed and handled, and I've not received any response from he who implemented this stuff as to why it was implemented or if he could fix it. So I'm kind of unsure why this code is there in the first place.

from obsidian-dataview.

@holroy I found the offending line and was able to fix the issue with some minor changes. I made a fork with the fix. I also made a pull request.

pull request: #2377

from obsidian-dataview.

That's interesting indeed, and I hope you're right, but are you sure you're preserved the same logic (whatever that was) which was introduced in 0.5.60++?

I'll look into this out of personal interest, but can't do so before in a day or two, but I hope your solution is solid and can be included and solve this long lasting issue.

from obsidian-dataview.

Yes, so the last time the file was touched 8 months ago by @RyotaUshio. The change essentially reverts his changes in this one file alone and not the other changes he's made to other files. This is straightforward in resolving the rendering issue without impacting anything else.

from obsidian-dataview.

There is no question that you've found the tricky code spot. I do remember the affected code from my last review of this issue. I just fail at understanding @RyotaUshio purpose with the code change, and how (and where) to implement the solution.

Therefore I find it very interesting to see this change which seems to take a very different approach and implementation of the issue at hand.

So I'm not opposing this PR in any way, I just want to figure out what is happening, how this code resolves it, and also see that my test cases related to this issue are resolved.

from obsidian-dataview.

I did some more digging and realized that @RyotaUshio made the change to fix issue #2084. The issue was that latex code does not render in reading view. In fixing this, everything else in reading view broke (i.e. stopped rendering). I reviewed his code thoroughly to understand where it went wrong to keep the fix for #2084. Ultimately, I was able to get it working so both non-latex and latex code both renders in reading view the way it should. Live preview continues to work as per-usual since this code doesn't affect live preview. Furthermore, this change works on mobile too.

This took longer than I expected. I updated the PR and added a comment in the code explaining the snippet that's involved in latex handling for any future maintainers of the code. I hope this gets resolved so inline properties can become usable once again.

from obsidian-dataview.