Giter VIP home page Giter VIP logo

magento2-ordercomments's People

Contributors

amadeco avatar boldbart avatar boldjurh avatar boldsidney avatar chamnand1 avatar danslo avatar ebusinessatlantique avatar erikhansen avatar ilevennet avatar indykoning avatar itaymesh avatar luukbold avatar milanu13 avatar newkarn avatar nordcompcz avatar pablomagestio avatar pabman11 avatar pathtolife avatar pczyz avatar peterjaap avatar rhorii avatar schmengler avatar sreichel avatar tanolalano avatar yonn-trimoreau avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

magento2-ordercomments's Issues

Support Magento 2.4

Hi guys!

I created a new pull request to support the Magento 2.4, you need only to approved.

Change css of this extension

Hello, thanks for your extension. I works but my theme shows it with black background and blue font color. where can I change the css?
Also how can I change the collapsing text field to regular text field which is always shown?
Thank you!

404 in REST api after clicking 'order' button

After installing the plugin, it appears properly in the configuration of Magento 2, and also the textarea shows in the card. However, when I enter a value in the textarea, the order button does not respond anymore because the plugin requests a REST api call to validate the input, but this call returns a 404.

Managing checkout comment REST API

I have created the cart --> https://example.com/rest/us/V1/carts/mine
Added Products ---> https://example.com/rest/us/V1/carts/mine/items
Now, I want to add the comment so I used the below API:
PUT https://example.com/rest/us/V1/carts/mine/set-order-comment?cartId=841xx
Body JSON:
{
"orderComment": "The is test comment"
}
Response 200 OK []
Then I follow the process and place the order but when looking at the orders in the admin grid the comment is not there.
I have tested the comment through the website and it is working but it does not work through APIs.

In app\code\Bold\OrderComment\Model\OrderCommentManagement.php
Line 52 : $comment = $orderComment->getComment();
The $comment variable has a NULL value.

Magento 2.3.6

Unable to save comment with Stripe Payment

The comment isn't saved when using stripe payment.

Stripe Payment Module Version: 2.5.7

If the credit card (processed via Stripe) is used as the payment method, the custom validator order-comment-validator.js validate function is not invoked after order is placed.

Adding comment in order POST call

Hi Team,

I am trying to create an order using the REST API. But how do you include order comment on POST call? I have tried adding "bold_order_comment" into the extension_attributes and checkout_fields inside extension_attributes but did not work.

Add order comments to order confirmation email

Hi, Plugin works fine and I see comments in magento backend.
What I have to write into the email template that the comment is shown in order confirmation email?
I try:

<h3>Order comment</h3>
<p>{{var getOrderCommentHtml()}}</p>

Yes I know, it is not correct, but is it possible?

Cache Comments

Hi Team,
Could you please let me know why we are using $this->_isScopePrivate = true; in app/code/Bold/OrderComment/Block/Order/Comment.php.
Do we really need this under this block?
Since this variable definition is different.

Please suggest

Feature Request: Add Order Comments to Generated (Print) PDFs Order & Packing Slip

Hi,

Thanks for adding the API features of this module - Definitely helped with this business case.
However, I encountered an issue. Most businesses, don't have the Magento Admin panel open when processing orders and as such, they print out the Order, or Packing Slip PDF and give this to their delivery teams.

It would be nice to add these comments optionally onto the Order / Packing Slip PDF's

Let me know if this is a feature you're interested in completing. It would make this module fully usable for all cases, from integrations to companies that print off PDFs directly from Magento.

Thanks again for the module, it's great!

Robert

Unit Testing Deprecated getMock()

deprecated class

I'm using magento 2.3 with php 7.2.

OLD extends \PHPUnit_Framework_TestCase
NEW extends \PHPUnit\Framework\TestCase

OLD getMock()
$this->_request = $this->getMockBuilder()->disableOriginalConstructor()->getMock();

Issue at production mode

Hello guys,

thanks for your extension. Really helpful! We have noticed that at the production mode of the Magento (2.3.6), the extension generates a bug when we try to load the checkout page:

Uncaught TypeError: Cannot read property 'length' of null

Seems to us that the method initialize() at Bold_OrderComment/js/view/checkout/order-comment-block.js doesn't handle the NULL value of this action:

        initialize: function() {
            this._super();
            var self = this;
            this.comment = ko.observable(getExistingComment()).extend({maxOrderCommentLength: this.getMaxLength()});

            this.remainingCharacters = ko.computed(function(){
                return self.getMaxLength() - self.comment().length; // THE ISSUE IS HERE!!
            });
        },

Thanks

Error Compiling

Compilation was started.
Repositories code generation... 1/7 [====>-----------------------] 14% 1 sec 76.0 MiB
Parse error: syntax error, unexpected ':', expecting ';' or '{' in /home/zaoorgan/public_html/vendor/boldcommerce/magento2-ordercomments/Block/Order/Comment.php on line 30

Magento 2.1.8

Can somebody help me with this??

Thanks

No output, not verbosing

Hi,

I'm using /V1/carts/mine/set-order-comment in postman except I'm getting an empty array in return.

My body is:

{
"cartId": "102693",
"orderComment": "Dit is een test comment"
}

I'm using put and the bearer token of my account. When using it in postman I'm getting an empty array in return and nothing is happening after placing an order.

Italian translation fails

Please check csv file for italian language:
magento2-ordercomments/i18n/it_IT.csv

There are plus "+" in the file.

module break order view in backend - M2 2.1.7

Hey guys,

i installed the module using composer require "boldcommerce/magento2-ordercomments" "~1.1.1",
magneto version 2.1.7
when i try to view order details from Sales -> Orders -> select view order

the page breaks and gives me this error :

Information Changes have been made to this section that have not been saved. This tab contains invalid data. Please resolve this before saving.
Invoices Changes have been made to this section that have not been saved. This tab contains invalid data. Please resolve this before saving.
Credit Memos Changes have been made to this section that have not been saved. This tab contains invalid data. Please resolve this before saving.
Shipments Changes have been made to this section that have not been saved. This tab contains invalid data. Please resolve this before saving.
Comments History Changes have been made to this section that have not been saved. This tab contains invalid data. Please resolve this before saving.

Variable for Emails?

Hi,

I was just curious if there is a variable I can use to get the comment for the transaction emails?

Thanks!
Ryan TeGantvoort

[2.2.3] Can't place order when there is text in the comment box.

Just installed your plugin in a test environment, I can place orders without a comment but as soon as I add a comment the "Place order" button stops working. I tried a recompile and to clean and flush the cache but unfortunately that didn't work. I did get some errors in the chrome console, would those be helpful for you?

Move comment field to first step

Could you provide a setting to have the comment textarea shown at the first step in the checkout. Preferably after entering the name and address.

Compile Error

Parse error: syntax error, unexpected ':', expecting ';' or '{' in /app/code/Bold/OrderComment/Block/Order/Comment.php on line 30

Add Delivery Instructions

Hi,

Thanks for this wonderful extension. Although I have few queries to extend the module. How can I achieve below

  • Can we add more than one input area? For example along with order comments, user also needs to add delivery instructions, delivery date&time, etc.? What changes I can do in the module to add more custom fields on checkout page?
  • Can we change the location of order comment input area to be displayed after all payment methods and above discount code? Or is there any configuration to change the position of the comments input in the checkout?
  • How can we disable comments in the backend on the order grid? It should only appear in order view page
  • Do the order comments appear in order confirmation email sent to user?
  • How can I change the default text Do you have any comments regarding the order?

Thanks.

Order view issue with Magento 2.3.0

When i try to open an order, i get the following error message :

Information Changes have been made to this section that have not been saved. This tab contains invalid data. Please resolve this before saving.

Adobe issue with extension

DETAIL: OBSOLETE _ISSCOPEPRIVATE PROPERTY

Description

The following table shows the private content block(s) that have the _isScopePrivate variables configured making the block not cacheable.

PATH

vendor/boldcommerce/magento2-ordercomments/Block/Order/Comment.php

Recommendation

Do not use the _isScopePrivate property in your blocks. This property is obsolete and will not work properly.

Replace _isScopePrivate property by private content instead.

Reference our developer documentation for guidance:

Please submit a Magento Support ticket for assistance or feedback.

Root Cause

The _isPrivateScope variable is making block(s) not cacheable. 

Scenario/Preconditions

Since private content is specific to individual users, it is reasonable to handle this on the client-side (i.e., the web browser) instead of hitting the server for retrieving the same data on each customer request.

Always test in the Staging environment prior to making any changes to the Production environment.

Site Impact

Each request to Magento can trigger additional Ajax requests for non-cacheable blocks causing negative  site performance.


get order comment via API call

Is it possible to download order comment using API?

I'm not an expert unfortunately, but the company that develops an application for me, claims it is not possible, making this module not feasible for my system.
Could you please confirm if this attribute is visible to API calls?

Many thanks!
Kate

Method Not Allowed

Hello
I have a problem, when click "Place Order" (checkout) i get error:

Method Not Allowed
The requested method PUT is not allowed for the URL /pl/rest/pl/V1/guest-carts/ee9577cbbf710fd909783fdbff2a1f14/set-order-comment.

please help me

Best regards

PHP Returns Problem on Magento 2.1.14

Ran into a problem with you Module after an Upgrade to Magento 2.1.14.

For some reason, the Magento compiler in this version ignores PHP return values, while generating an interceptor. Because of this, the interceptor becomes incompatible to the original file and past orders can no longer be reviewed in the customer area.

Fix for me was to override Bold/OrderComment/Block/Order/Comment.php and remove the PHP return values. I'm not sure why they are there, so I did not sent a PR.

The fix is simple. Example
Change: public function getOrder() : Order
To; public function getOrder()

Only this file needs changing for Magento 2.1.14 to work.

Can not add custom translation

Hi,

I've added translation strings for this module in my template/i18n/sl_SI.csv (Slovenian language) and it looks like it does not work.
Is there any other way I can override translation?

Best regards,
Matic

Please add the greek translation

Hi, please add also the greek translation. I have attached the corresponding file.
el_GR.csv

How can I use my translation in your module without placing it in vendor/module directory? If I place it there it will be overwritten in the next update. If you integrate it of course this will not be a problem

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.