chef-server-ctl reconfigure does not create symlinks for runit about omnibus-chef-server HOT 10 CLOSED

I have absolutely no idea why this is there, but:

https://github.com/opscode/omnibus-chef-server/blob/master/files/chef-server-cookbooks/runit/definitions/runit_service.rb#L155

Is why the links are not getting created.

from omnibus-chef-server.

this would only make sense if there are alterntive init-scripts, so i guess there is no need for that

from omnibus-chef-server.

Yep - my guess is that the embedded version of the runit cookbook was mid-gentoo refactor?

Regardless - try commenting out those lines in your ctl scripts on a new install, do a reconfigure, and confirm success?

If that works, send a PR removing those lines, and we'll merge.

from omnibus-chef-server.

if have patched this lines out and i think i have found the reason why it was there.

chef-master01 ~ # chef-server-ctl start rabbitmq
fail: rabbitmq: unable to change to service directory: file does not exist

Ìf i watch the process with strace i could see that the process tries to switch to /var/service, the default service path for runit. It seems like the envvar SVDIR is not set.

with SVDIR=/opt/chef-server/service chef-server-ctl start rabbitmq i could start the service.

But SVDIR=/opt/chef-server/service chef-server-ctl reconfigure does still fail with unable to change to service directory: file does not exist

from omnibus-chef-server.

I reinstalled the system from an older image, and everything works. I think there was some garbage left after the debugging, PR follows

from omnibus-chef-server.

This runit cookbook is version 0.14.2, which is well over 2 years old now. The current version of runit uses a resource/provider instead of a definition to manage runit based services as a first class Chef::Resource::Service provider. The gentoo-specific conditional was dropped when I refactored the definition to the resource/provider.

You can see version 0.14.2 of the runit cookbook in its history here. The conditional for gentoo was added when gentoo support was originally added to the runit cookbook, almost four years ago. I don't know why this was done here, but that's ancient history.

TL;DR - we should update omnibus-chef-server to use the current runit cookbook.

from omnibus-chef-server.

Maybe?

We don't need a particularly wide degree of support here, and the current
code just works, and the patch is two lines long. Rather than eating the
whole bowl of the refactor.

Adam

On Tue, Jul 22, 2014 at 11:18 PM, Joshua Timberman <[email protected]

wrote:

This runit cookbook is version 0.14.2, which is well over 2 years old now.
The current version of runit
https://supermarket.getchef.com/cookbooks/runit uses a
resource/provider instead of a definition to manage runit based services as
a first class Chef::Resource::Service provider. The gentoo-specific
conditional was dropped when I refactored the definition to the
resource/provider.

You can see version 0.14.2 of the runit cookbook in its history here
https://github.com/hw-cookbooks/runit/blob/6c39418faaa1a938447909a41d857302c3a63d02/definitions/runit_service.rb#L128-L132.
The conditional for gentoo was added when gentoo support was originally
added to the runit cookbook
https://github.com/hw-cookbooks/runit/tree/1ee0a78, almost four years
ago. I don't know why this was done here, but that's ancient history.

TL;DR - we should update omnibus-chef-server to use the current runit
cookbook.

—
Reply to this email directly or view it on GitHub
#77 (comment)
.

from omnibus-chef-server.

So, why does EC suffer from the CHEF-3838 bug on OEL when its pulling the community cookbook which appears to properly use platform_family and is test-kitchen tested on RHEL? I think we're either depsolving and shipping an old version of the community runit cookbook in EC or else the community cookbook's platform_family support is buggy somewhere..

But, yeah, we blocked CHEF-3838 for a whole year waiting for the whole-bowl-refactor to appear which never did, so I patched it here, so we should accept this 2-line patch by the same logic.

from omnibus-chef-server.

Then we shall accept this patch. I'll merge it down for the 11.1.4 release.

from omnibus-chef-server.

And this has been merged down: 4d513fe

So this issue can be closed. Thanks for the patch @tbe.

from omnibus-chef-server.