Comments (7)
Thanks also from me @jbracher - very glad you spotted this!
@seabbs - I think we should by default return deaths by date of death, since the rest of the package is aiming to be as user-friendly and analysis-ready as possible. Then include an option to return RKI data as-is (by date of case report), with a warning. Let me know what you think, I'll work on this today.
from covidregionaldata.
@kathsherratt agreed. Just needs to be flagged clearly in the docs (and the source for the updated reports etc for credit).
from covidregionaldata.
Sorry for the late reply. There is no reference to our data other than the github repo. But you should also mention the RKI dashboard and the repo https://github.com/ard-data/2020-rki-archive from which we obtained the data snapshots from before we started getting them directly from RKI.
from covidregionaldata.
Thanks for this @jbracher,
Really helpful stuff. The install issues should now be cleaned up and we think everything is in pretty good shape (apart from this RKI data issue you have flagged).
There is a bit of a conflict here between supporting more "official" data sources and supporting data sources that are actually useful (i.e yours). Perhaps we can add a logical switch and some documentation for the German data. What do you think @kathsherratt?
Sam
from covidregionaldata.
I see Sam's point about sticking to the official data sources. If you decide to optionally read data from our repo please let me know. To be fully transparent, we have had some issues with our automatic updates recently (which we could correct thanks to https://github.com/ard-data/2020-rki-archive). In any case I agree that sone informative message should be printed when reading the German data.
from covidregionaldata.
I think we will be adding this as an option (likely the default) with an informative message indicating what is being output. Good to know about the issues with the updates - it is a fairly common theme with these regional datasets as many of them are quite hard to collect. In terms of linking to your data source is the github link the best pointer or is there a citation to also mention?
from covidregionaldata.
This issue has been flagged as stale due to lack of activity
from covidregionaldata.
Related Issues (20)
- Add tests for download_JSON and JSON_reader HOT 2
- Add memoise support for download_JSON HOT 1
- Update package logo with new datasets HOT 1
- Review depreciated features HOT 2
- HTTP error 502 when downloading Vietnam's json data HOT 6
- Upstream data changes break our regional code - Colombia, Cuba, India, United States HOT 11
- Check if some required packages could be made suggested HOT 4
- Switch to preferably pkgdown theme HOT 3
- Giant package logo in web docs HOT 6
- Vietnam handles province labels badly, possible str_conv issue
- We've also made a fix to `complete()` to ensure that it always works as expected with grouped data frames. One of the results of this fix is that you can no longer supply group variables to `complete()` (if you have a grouped data frame, `complete()` will work "within" each group so you shouldn't have access to them). See https://github.com/tidyverse/tidyr/pull/1300 for more details. HOT 2
- Warnings from countrycode
- Vietnam data timing out HOT 1
- Colombia failing download tests
- Italian COVID-19 Integrated Surveillance Data HOT 19
- Run country-specific tests when relevant files are modified HOT 2
- France has moved their data - this breaks slowstart
- France has moved their data - we need to use a new upstream source HOT 1
- covidregionaldata archived on CRAN HOT 3
- South Africa new reported cases around higher than Our World In Data/WHO HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from covidregionaldata.