Model estimation broken for upstream PX4 about data-driven-dynamics HOT 6 CLOSED

@Jaeyoung-Lim Is the corresponding ulog-File available somewhere online to reproduce the issue? It seems like the flight time estimation based on the landed topic somehow doesn't work for this log.

from data-driven-dynamics.

@sjschlapbach That was where I was just at :)

num_of_groups is 4 which looks like a case not handled in the code

Log: https://review.px4.io/plot_app?log=2832a4ac-2906-4327-a5f0-98db8df6e3e3

from data-driven-dynamics.

@Jaeyoung-Lim Thanks, now this makes total sense... I didn't take a look at the landed topic yet, but if I draw the right conclusions from these logged messages, the log contains "two flights" in some sense where the second one probably occurred from a bump during landing?

What's the behavior that would be expected? To just use the first section where the landed topic is 1 or to concatenate all parts to allow for flights with multiple parts?

from data-driven-dynamics.

I think we want to take all the data while the vehicle is "in air"...but good question.

I am not sure if land detector would be reliable enough to assume it only triggers during flight. But certainly good idea to take the data out when the land detector has triggered.

from data-driven-dynamics.

Alright, this makes sense. I can have a look at this in the coming days. I think it should be fairly easy to fix this with the test log you provided.

from data-driven-dynamics.

@Jaeyoung-Lim I addressed this issue with PR #225, which also worked when I tested it with the flight log you provided. I hope this solves the problem? :)

from data-driven-dynamics.