Giter VIP home page Giter VIP logo

Comments (3)

deustp01 avatar deustp01 commented on July 29, 2024

The reasoning in @goodb comment on 4 Sep sounds risky. Will this approach correctly handle cases where an activity (enzyme) is located in a membrane and accessible to substrates in an adjoining lumen, so the reaction actually occurs at the membrane - lumen interface and substrates / inputs / left bucket and products / output / right bucket are all in the lumen? And the cases where a protein with transport activity moves physical entities between the two cell components separated by that membrane?
Probably the answer, at least for Reactome, is that in all these cases the various reaction participants are all correctly assigned to compartments (failure to do that is a major curation error and we have QA that reliably finds such cases) so you should never need to use reasoning tools to assign cell component annotations.

from pathways2go.

goodb avatar goodb commented on July 29, 2024

@deustp01 just to clarify, we can't generate a MF occurs_in CC relation assertion directly from what I see in the BioPAX as the CC annotations only hang on the physical entities. The above logic (or adaptations you can suggest) is needed to produce those relations based on the participant CC annotations. I think we are safe here in that the rule will only activate if all of the participants are annotated to the same CC. And, if it goes haywire and we end up getting reactions that occur in multiple locations at once, the reasoner raises an alarm.

from pathways2go.

deustp01 avatar deustp01 commented on July 29, 2024

Agree - we should mostly be OK and the reasoner will give an additional level of QA when we make a mistake.

from pathways2go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.