Giter VIP home page Giter VIP logo

Comments (7)

ukemi avatar ukemi commented on September 4, 2024 1

It's way simpler than that. In my own worrisome way, I just want to make sure that the process worked. That is, when I see a chemical in a model, it is the chemical that was in the original Reactome pathway and the label on the chemical is correct though the chain of Reactome ID->ChebiID in Reactome->ChebiID in GO-CAM->GO-CAM graph label.

from pathways2go.

deustp01 avatar deustp01 commented on September 4, 2024

N.b. Once we are sure that all chemicals do have ChEBI IDs, need to clean up REACTO to remove chemical IDs
Also need QA check and a way to automatically convert items like David Hill's manual mouse GO-CAMs that have REACTO chemicals in them.
Changes to ShEX to fix this.
Long term goal - retire REACTO. Short term process - retire parts of it as possible. Chemicals here, proteoforms soon.
Link to Ben's global ticket
https://github.com/geneontology/noctua-models-migrations/issues

from pathways2go.

ukemi avatar ukemi commented on September 4, 2024

Separate from the missing (unresolving) ChEBI identifiers that were already spotted. I need a way to check the integrity of the identifiers that are resolving. The best method that I can think of is to open the model in the graph editor, output the GPAD and cross check the label in the graph editor with the Chebi identifier in the GPAD and then cross-check those with Chebi. I will also check them with respect to the cross references in Reactome. This is a labor-intensive manual process, but I think it is necessary to ensure that things happened correctly. I will start a spreadsheet and link it to this ticket. I'm not sure how many I will check, but will look at several different pathways and several different kinds of reactions.

from pathways2go.

nataled avatar nataled commented on September 4, 2024

@ukemi that shouldn't have to be done manually. I can probably whip up a way to check automatically once given the GPAD. This is not to stop any manual work that could proceed while the automated check is in progress (that's my usual procedure anyway).

from pathways2go.

ukemi avatar ukemi commented on September 4, 2024

That would be awesome @nataled! @dustine32 do you know if there are products generated from the development server? If so, is there a GPAD that @nataled could use? Even if it is a mega-file, it would be straightforward to filter on annotations from Reactome models. We might actually want to put something like this in place beyond just for this project.

from pathways2go.

deustp01 avatar deustp01 commented on September 4, 2024

I need a way to check the integrity of the identifiers that are resolving.

Item for Monday "weeds" - what exactly are the integrity problems (wrong charge states of ionizable compounds? other?)? In principle, this is really a Reactome curation integrity issue: we should only be using correct ChEBI instances in the first place, so the follow-on question is how to change Reactome curation and QA practice to fix them at the source. And, as suggested on Wednesday, get rid of ChEBI terms used to identify polynucleotides where SO terms would work. And, probably, also identify classes of ChEBI instances that Reactome needs to annotate weird cases - perhaps we really need those electrons and photons - to add to Jim's list of ChEBI terms legal for GO-CAM.

Your spreadsheet will be a good resource for starting to sort this out.

from pathways2go.

ukemi avatar ukemi commented on September 4, 2024

I did a bit of this today and I am convinced that the integrity of the information being transferred is intact:
https://docs.google.com/spreadsheets/d/1-NxsN6eVxxWuAGuH9tGX0W2FMi3mc90AodOOxaOP7sY/edit#gid=0
I looked at the ones in the spreadsheet in detail, but also checked other reactions in the pathways.

from pathways2go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.