Orphaned Triangles After Operation about three-bvh-csg HOT 6 CLOSED

Thanks for the details!

I didn't create an actual THREE scene, since the scene itself looks fine. Let me know if you would like me to add that.

It would be useful to add a simple scene with a bounding box to inspect the issue more easily.

from three-bvh-csg.

Ok I retooled the example with a scene and a bounding box: https://codepen.io/jakedluhy/pen/YzBJgPp?editors=0010

Unfortunately the zoom/dolly isn't working for the controls (I think because there's a multiple versions of THREE.js issue due to weird Codepen imports). Let me know if you need anything else!

from three-bvh-csg.

Yes looks like there are extra points being added:

The same thing seems to happen with ADDITION and DIFFERENCE:

There are no extra points with INTERSECTION, though:

Commenting out the first performSplitTriangleOperations removes the excess points so there may be a bug in that section of code. So this at least helps narrow down which point in the operation these points are being generated from. I'll have to dig in more later

from three-bvh-csg.

It looks like this has been happening all the way back to v0.0.3 (didn't check earlier versions) with the SUBTRACTION operation.

However with the ADDITION operation this only started happening in v0.0.12. The extra points were not present in v0.0.11.

from three-bvh-csg.

It looks like this is occurring because the provided geometry contains degenerate triangles with an area of 0, 0, 0 causing the barycoordinate calculations to be incorrect. I think by some measures this may be at odds with the idea that a geometry needs to be watertight / two-manifold but this shouldn't be too big of an issue to handle.

from three-bvh-csg.

Thanks so much for jumping on this!

from three-bvh-csg.