Performance: Font caching redundantly executing Font.size() about nodezator HOT 6 CLOSED

Mr. Richards,

First of all, thank you for taking the time to help improve Nodezator. This detailed report is much appreciated and shows your dedication. I'm just stopping by to acknowledge receipt/awareness of this issue and to let you know I'll give you a proper reply in a couple of days (excluding Sunday).

Have a nice weekend,

Peace

from nodezator.

Mr. Richards,

I apologize for my delay in tending to this. I've been working in a new feature for the next release since Monday and only today I was able to reach a point where I could show something (I posted about it in the discussion regarding current work #34 ).

I'll tend to this issue and the related pull request from tomorrow onwards (probably after lunch, since I have a commitment in the morning).

Peace

from nodezator.

Thanks for the acknowledgement, I'm glad this appears helpful.

dedication

I seek to clearly identify areas I find worthy of attention, from my current perspective as a user.

from nodezator.

@KennedyRichard Please have a look at referenced experimental fix for font performance, and also for unlikely infinite loop and a crash with too small/large heights.

Edit: This is no longer experimental! I tested it and it launches much faster than without this change.

from nodezator.

Note to self:

I might want to add in another test, for font size of 23. Size of 22 and font size is 24 both return a font and font size of 23 returns a unreachable font size exception. It would be good probably to test for that to validate that it works the way it's supposed to work.

from nodezator.

The issue was solved by the related pull request, so I'm closing it now!

from nodezator.