Comments (3)
hi @ArnaudBelcour
Thank you for your thoughtful comment! You are right; the current approach does not match the expected behavior.
And sure, it would be great to have a pull request for this!
The only thing why I am a bit hesitating is that gapseq doall
is supposed to perform a default and recommended settings. Adding parameters for all sub-processes would probably add too much complexity, and for these use cases, advanced users should, in my opinion, better call the sub-processes like gapseq find
or gapseq fill
directly.
For -K
, it makes total sense to add it, and maybe also for -v
although I am not so completely sure here because doall
starts the pipeline and is not primarily for getting general information and version numbers. What do you think?
from gapseq.
I understand your point of using only default option with gapseq doall
and yes, only the -K
option could be added. I will make this minimal modification and we can discuss it on the PR.
For the other option, I was more thinking of -n
, which allows to have a more verbose output when using gapseq doall
. Because indeed, -v
is not very useful to such command, but I was using it as the difference of outputs were the most striking.
from gapseq.
I agree that -v
and -K
both make sense for gapseq doall
!
If you still want to implement it, feel free to open a PR, otherwise, I can also do it.
from gapseq.
Related Issues (20)
- gapseq advice for colonisation HOT 1
- GapSeq protein is absent when it is .faa shows its present HOT 10
- gapseq medium HOT 4
- Question about doall command HOT 1
- How was dat/media/gut.csv formulated?
- stat: cannot stat '/scratch/users/nus/e0512805/gapseq/src/../dat/seq/Bacteria/rev/sequences.tar.gz': No such file or directory HOT 8
- Error in curl::curl_fetch_memory(url, handle = handle) : Timeout was reached: [rest.uniprot.org] SSL connection timeout HOT 4
- Download sequences fails HOT 2
- HTML entities for special characters in reaction name causes incorrect uniprot queries HOT 1
- libsbml and libglpk not found while installed using conda HOT 4
- Question: GapSeq includes a protein as being present when it got a bad blast? HOT 14
- Reaction inferred from pseudogene regions when using gapseq on genome fasta file.
- CHNOSZ NOT FOUND HOT 1
- [Request Update] [Tutorial] For anyone who intend to use CPLEX in gapseq HOT 3
- Diamond not used for the transport-find command HOT 2
- Could not use find-transport function using '-m' option for specific metabolite. HOT 8
- subex.tbl issue HOT 1
- Any plans on updating MetaCyc database? HOT 2
- Using seed reaction database in Adapt function HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gapseq.