krockot / unity-taskmanager Goto Github PK

I'm not sure if this repo is still being maintained but I saw a commit 4 months ago so thought I'd give it a shot.

If you try to use a UnityWebRequest within a coroutine that's called via new Task(), the coroutine doesn't actually yield until the UnityWebRequest is done. Instead, the next line in the coroutine is called immediately, followed by the response from the UnityWebRequest when it is done.

This doesn't happen if you just use plain coroutines for everything. When you call yield return req.SendWebRequest(); in a regular coroutine, it will pause its execution until the webrequest is done.

I've looked at the code but have no idea how to fix this. Would appreciate some pointers on what to do if you don't have time to maintain this repo anymore @krockot.

i think
IEnumerator CallWrapper()
{
yield return null;
IEnumerator e = coroutine;
while(running) {
if(paused)
yield return null;
else {
if(e != null && e.MoveNext()) {
yield return e.Current;
}
else {
running = false;
}
}
}

        FinishedHandler handler = Finished;
        if (handler != null) {
            handler (stopped);
        }
        yield return null;
    }

should change to
IEnumerator CallWrapper()
{
///yield return null;
IEnumerator e = coroutine;
while(running) {
if(paused)
yield return null;
else {
if(e != null && e.MoveNext()) {
yield return e.Current;
}
else {
running = false;
}
}
}

        FinishedHandler handler = Finished;
        if (handler != null) {
            handler (stopped);
        }
        yield return null;
    }

otherwise the coroutine will be one frame delay to execute, and in some case may cause wrong effect.

Would be fantastic if you could add a license to this for some clarity over whether this can be used in commercial software <3