http://prntscr.com/5al1tf

SellItem packets are currently broken. (Or at least it doesn't work for trinkets.)

Hi, I get code 44 to Sivir W, should get 1, because

public enum SpellSlot
{
Unknown = -1,
Q = 0,
W = 1,
E = 2,
R = 3,
Item1 = 4,
Item2 = 5,
Item3 = 6,
Item4 = 7,
Item5 = 8,
Item6 = 9,
Trinket = 10,
Recall = 11,
}

Thank you.

it tends to get outta fight when holding combo button after 20-25 min^^

Hi Esk0r, I have a problem. I have been using leaguesharp, and now i cant enter to my account because i have to go to other house to live. Can you help me? Thank you for your attention.

var slot = ObjectManager.Player.GetSpellSlot(sdataname);
if (slot == SpellSlot.Unknown)
return;

It returns even when spellslot/spelldata is valid

Structure is roughly (taken from intWars):

typedef struct _UpdateModel {
_UpdateModel(uint32 netID, const char *szModel) {
memset(this, 0, sizeof(_UpdateModel));
header.cmd = (PacketCmd)0x97;
header.netId = netID;
id = netID & ~0x40000000;
bOk = 1;
unk1 = -1;
strncpy((char *)szName, szModel, 32);
}
PacketHeader header;
uint32 id;
uint8 bOk;
uint32 unk1;
uint8 szName[32];
} UpdateModel;

You know sometimes when your holding orbwalk somewhere and you suddenly hover above one of LoLs UI like character ui and your champion starts glitching for a second.

Is it possible for the orbwalking to ignore the UIs around you?

With the most recent fixes it all of a sudden stopped working and have been giving "CompilingError" since then.

                    result.CastPosition = input.RangeCheckFrom +
                                          input.Range *
                                          (result.UnitPosition - input.RangeCheckFrom).To2D().Normalized().To3D();

This code (in Prediction) multiples the z coordinate by input.Range given invalid values.

Please update dmg for skill Q nasus !!!! It is : "Passive Count + Default Dmg + 100% Basic Attack Dmg"

I have a request a few requests that i wish to be added

1. that you add a (prioritize farm over harass) for each mode (lasthit,waveclear, and harass) because i want to harass more than farm (unless big minion) if i'm holding harass button and then i wish to waveclear because a big wave is comming and do not wish to harass and so on..

2. Prioritize big minions over small ones as sometimes it will attack the small and leave the big minion to die to our wave of minions

3. something like assassin manager for big minions http://www.joduska.me/forum/topic/751-assassin-manager-for-assassin-characters/
   the idea here is when you are holding specific button (lasthit,waveclear, and harass) and a big minion which is about to die is within assassin manager range it will try to prioritize that big minion over the small minion near you

4. Check what is the tower attacking and then do a check if the tower will kill it or not with the hit and if you will kill it before the tower
   For example; lets say there are 2 minions who are both under the tower ofcourse the tower will target one of them and any human player will kill the one the tower is targeting so the tower itself doesn't kill it and therefore lose gold because he will also have time to attack the other minion before the tower kills it but the orbwalker here will attack whichever is closer to you no matter if its killable or not and sometimes making you lose 2 minions instead of losing none

5. LessAttackPriority + LessCastPriority self-explained

I actually had more in mind but i forgot them when writing this.

http://i.imgur.com/85YFd3k.png

My menus are all smooshed together almost off the screen, orbwalker doesn't move to mouse, and no spells cast with Spell.Cast

I'm using a fresh L# installation (27 september build), everything updated to latest github versions, and this persists across games/champions. Everything worked completely fine yesterday, and I'm quite puzzled as to what happened. If anyone has any insight, I would greatly appreciate it.

Also, Damage.GetItemDamage is still not implemented

Volibear W damage doesn't take in consideration the 15% bonus health, only the targeting missing health

I see you have add 4 type Collision Obj but in Prediction you set default it only use Minion, Yasuo Wall ? What about some skill can go through Hero, please add option so we can choose what we want

Can someone explain me Buff.DisplayName will change with other languages LoL ? or it always like that same like Name ? Bcz in L# Common i see you always use DisplayName instead of Name

hi, in this line: https://github.com/LeagueSharp/LeagueSharp.Common/blob/master/TargetSelector.cs#L255
the health should be increased. A trynda with a normal health reg. wil regain 2 health nearly every second, which causes weird target switching in some assemblies

Pretty sure it's Common related so I'm just putting it here

Altrough nobody using it only I with Zed :P ,IMO its working pretty stupid. You need to have nonstop cursor on target to attack him. 50 is pretty low. If you get out of 50 it will just walk without attacking.
It should attack closest target near mouse

case TargetingMode.NearMouse:
return targets.FirstOrDefault(hero => hero.Distance(Game.CursorPos) < 50);

to

case TargetingMode.NearMouse:
return targets.FirstOrDefault(hero => hero.Distance(Game.CursorPos));

• not sure if it will work or if it will cause lag, I am not coder.

The calculated damage is 2.0 too low when attacking lane minions, also it does not incorporate Butcher mastery (then it is 4.0 too low). Tested with Ashe without any other items/masteries/runes.

Drawing.OnDraw doesnt not Fire when you load a script with orbwalker.
The menu isn't shown and it doesnt draw

Is there a reason that ForceTarget(Obj_AI_Base) is not the first target to be returned if it's valid?

https://github.com/LeagueSharp/LeagueSharpCommon/blob/master/LeagueSharp.Common/LeagueSharp.Common/Orbwalking.cs#L669-L673

Am I doing something wrong or are the HP bar indicators broken?
They are not showing up at all.

var dmgComboWithItem =  new MenuItem("DrawComboDamage", "Draw Combo Damage").SetValue(true);
Utility.HpBarDamageIndicator.DamageToUnit = GetComboDmg;
Utility.HpBarDamageIndicator.Enabled = dmgComboWithItem.GetValue<bool>();

dmgComboWithItem.ValueChanged += delegate(object sender, OnValueChangeEventArgs eventArgs)
    {
        Utility.HpBarDamageIndicator.Enabled = eventArgs.GetNewValue<bool>();
    };

Gragas R is listed as SpellSlot.E in Damage.cs. This needs to be changed for Damage prediction to work correctly on Gragas.

The error in DmgLib (Leesin champ):
case SpellType.R:
return CalcPhysicalDmg((ObjectManager.Player.Spellbook.GetSpell(SpellSlot.R).Level * 200) + (2.0 * ObjectManager.Player.FlatMagicDamageMod), enemy);

The error in Dmg (Leesin champ): Q2 don't have stage to check
new DamageSpell{Slot = SpellSlot.Q, DamageType = DamageType.Physical, Damage = (source, target, level) => new double[]{50, 80, 110, 140, 170}[level] + 0.9 * source.FlatPhysicalDamageMod },
new DamageSpell{Slot = SpellSlot.Q, DamageType = DamageType.Physical, Damage = (source, target, level) => new double[]{50, 80, 110, 140, 170}[level] + 0.9 * source.FlatPhysicalDamageMod + 0.08 * (target.MaxHealth - target.Health)},

http://pastebin.com/eJUqBJyt
Has update to the lastes version of NA (4.18). Fixed champion name, fix spellslot wrong, update spell damage data and add Stage for Rengar etc....

yup 😄
just one picture 😃

using xSalice's Religion AIO, but that assembly just uses Q after GetPrediction and calc Hitchance!

maybe no problem on assembly.

calculation error? (20% hitchance on lane fight 😭 )

Hate to compare this to that "other" script competitor, but it has a wonderful feature that allows you to see only the AA-range of the enemy ADC. With L#, currently, you see all enemies AA range in the Common Orbwalk option, and this can be chaotic. If you could implement sub-options that let you see only the enemy ADC and/or APC AA range, that would be amazing.

If you're curious, the competitor shows all 5 enemy AA ranges as an individual toggle.

can make GetLineAOECastPosition? for ult sona =P

Items.CanUseItem(int) is printing false when the item is actually ready.

Marksman and BaseUlt3 doesn't after the last commit.

it seems like Zed E have a issue with Packetcasting

E = new Spell(SpellSlot.E, 125);

Works = E.CastOnUnit(ObjectManager.Player);
Not Works = E.CastOnUnit(ObjectManager.Player , true);

I would do this as a pull request but I have no idea what the 6 bytes in the middle mean

Also, the damage type seem to have changed. So far, I've worked out that:
4 = Basic attack/Spell damage
3 = Critical attack

Sample packet (hex):
65 06 00 00 40 04 55 00 B2 33 D2 42 06 00 00 40 05 00 00 40

Same like title. I see the Common dont have Passive for Shen ?

Hello Common gurus,

It's been demonstrated mathematically that killing the small minions in a jungle camp results in healthier clears. Could you implement logic that would allow the Lane Clear / Jungle Clear orbwalk to attack small minions in a jungle camp before attacking the main minion? If the concern is enemy invasion, you can implement range logic such as "attack small minions first if no enemy within 1000 yards".

The method has a parameter to set the position around which minions are selected, but the actual position used is always the player position as minion.IsValidTarget() is used for the distance check.

In Packet.cs:202 and Packet.cs:187 you directly go from a byte to Spellslot and Spellslot to byte. This casting does not work as intended. I believe we want a mapping as follows:

128 = Q
129 = W
130 = E
131 = R
132 = Item_1
133 = Item_2
134 = Item_3
135 = Item_4
136 = Item_5
137 = Item_6
64 = Summoner_1
65 = Summoner_2
192 = Summoner_1
193 = Summoner_2
10 = Recall

Hydra Don't Work ;(
And Esp Tiamat too

Assemblies using utility.delay may cause NA users to disconnect.

Found out why cass ults are casting backwards when AOE is on and multiple targets are available:
(most assemblies fix it by checking if its casting bullsht and blocking the cast - which is not good because this way it can happen that it's not casting at all)

Basically
https://github.com/LeagueSharp/LeagueSharp.Common/blob/master/Prediction.cs#L670-670
is converting the positions to positions relative to the player, but
https://github.com/LeagueSharp/LeagueSharp.Common/blob/master/Prediction.cs#L709-709
doesn't calculate the real position and is returning the relative position. Replace the line with
CastPosition = (bestCandidate + input.From.To2D()).To3D(),
to make it work properly

Not sure exactly what is causing this bug, it has proven a little hard to isolate. TargetsHit doesn't seem to work for AOE spells (always returns 1). Tested with Oriannas ult and W (both of which don't cast on a position or target, they just... cast, which might be the issue here. Not sure how getprediction handles spells that don't actually have a target).

•                    case SpellSlot.Summoner1:
  

•                        return 0xEF;
  

•                    case SpellSlot.Summoner2:
  

  Packet.cs(346,40): error CS0117: 'LeagueSharp.SpellSlot' enthält keine Definition für 'Summoner1'.
  Packet.cs(348,40): error CS0117: 'LeagueSharp.SpellSlot' enthält keine Definition für 'Summoner2'.

// IS FIXXED, GOT ALT LEAGUESHARP.DLL

Error compiling

Black Warwick
Master yi by prunes
Roach_'s pantheon
FALeesin
Metasmite
J_utity
Oracle
Diabeths assemblies

how to build this project?
where is the clipper_library,LeagueSharp,LeagueSharp.Sandbox,SharpDX,SharpDX.Direct3D9 Lib?

IsReady() will currently return true even if that skill has not yet been leveled. Should return false for all non-leveled spells

I tested on too many games. Because many korean have AA-canceling problem. (Include me)
We set "Extra Winduptime" to 200. but we still had AA-canceling problem.

Reason is..

Method "CanMove(float extraWindup)" on Orbwalking.cs
I deleted line...

if (_missileLaunched)
    return true;

It has no AA-canceling problem.

But it has big problem after channeling skills like Miss Fortune R and Caitlyn R, Orbwalking stops move before i use another skill.
(Yeah, just stops! It don't attack any object, and don't move to mouse.
But after i use any skill, it works.)

Any good idea to fix this problem?
(I try more to fix this problem on custom game before no Koreans have this problem.)

I believe this bug has now been Isolated to the Menu.cs file. The new menu implemented, causes a severe delay when clicking icons on the screen.

Shop/Spells/Teleport/Pings all seem to effected when using the mouse, I'm quite sure shortcut keys work fine but i'm not 100% on that, let me know if you need that info.

For now I am injecting the old Menu.cs file into a local version of the latest common commit, this appears to correct the issue but I am no longer on the gorgeous new menu.

Thanks and love your skills!!!

Hey,

I noticed that the "flowers" of Zyra are not being attacked by the common orbwalker.

Would you mind to add them or is their a reason why they are not being attacked?