Giter VIP home page Giter VIP logo

Comments (6)

barentsen avatar barentsen commented on May 29, 2024

Thinking out loud: this could be a job for the meta attribute, i.e. the fold() method could set lc.meta['is_folded'] = True. The plot method could look for that, and if it's not set, go with the default.

If the user specified the label as an argument to plot, that would get priority over anything, of course.

from lightkurve.

christinahedges avatar christinahedges commented on May 29, 2024

I think that it might be better to have some description attribute for what's held in flux, flux_err and time. Then when the user prints them it displays that description? The description can update if you run the fold method or flatten method.

e.g.
lc = tpf.to_lightcurve()

flux: 'Flux in counts [e-s-1]

lc = lc.normalize()

flux: 'Normalized Flux'

from lightkurve.

barentsen avatar barentsen commented on May 29, 2024

Interesting. I wonder if we want to keep track of flux_label and flux_units as attributes or using the meta dictionary.

Related note: right now we don't support astropy Quantity at all (if flux is a Quantity is converted to a simple numpy array in the constructor of LightCurve).

from lightkurve.

christinahedges avatar christinahedges commented on May 29, 2024

This can be fixed by the user if they pass the xlabel keyword...but we're not doing it. And it's in all our docs and tutorials and gifs.

from lightkurve.

barentsen avatar barentsen commented on May 29, 2024

I've proposed a fix in #64.

from lightkurve.

barentsen avatar barentsen commented on May 29, 2024

#64 has been merged, meaning this issue should be fixed now!

from lightkurve.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.