mazurel / modbus Goto Github PK

When parsing a request to generate a read coils response, the number of inputs is not parsed correctly. The bytes value should be a uint16_t instead of uint8_t. The standard requires 0x0000-0xFFFF. Currently, if you're value is 0x0000-0x00FF, you won't generate any value bytes.

You'll also need to change the value to be read:

uint16_t bytes; 
  
switch (_functionCode) { 
    case utils::ReadDiscreteOutputCoils: 
    case utils::ReadDiscreteInputContacts: 
    bytes = inputData[2] << 8 + inputData[3]; 

when i receive data use rtu, how to can i show data on display?

If I create an ModbusRequest without any values, it uses the ctor with default values. There is a switch statement and a valid function code value is required, so exception will be thrown

switch (functionRegisters()) { case utils::OutputCoils: ...

Hi, Mazurel. I have been trying to use your modbus library for a RTU project. It seems like a nice implementation and it supports CMake which I appreciate. I have hocked the RTU Service up to a Osciloscope and your baudrates aren't working properly. It probably has something to do with the:
cfsetospeed(&_termios, speed);
cfsetispeed(&_termios, speed);
functions in setBaudRate. I would solve it myself, but I'm not proficient with the Linux Api calls. Thanks for providing anyhow.
Best regards

When adding this library to my project like described in the Readme.md, i get the following error.

In file included from /home/bumblebee/dev/optimal-sensor/lib/Modbus/src/Serial/connection.cpp:5:
/home/bumblebee/dev/optimal-sensor/lib/Modbus/include/MB/Serial/connection.hpp:15:10: fatal error: poll.h: No such file or directory
15 | #include <poll.h>