Giter VIP home page Giter VIP logo

Comments (8)

obiot avatar obiot commented on May 23, 2024

thank you very much for the report, we will look into it.

We are still in the process of providing proper typings for melonJS, please do share if you find any other issues. In the mean time, you can use @ts-ignore to remove the warning/error report in VSC.

from melonjs.

muyaszed avatar muyaszed commented on May 23, 2024

I have a fix for this, just need the suitable replacement name for Body class. Atm I'm using BodyObject for it. the Method will still be using body

from melonjs.

muyaszed avatar muyaszed commented on May 23, 2024

Do I need to commit the updated Doc as well?

from melonjs.

daniel-centore avatar daniel-centore commented on May 23, 2024

For now I'm working around this with:

import { Body } from "melonjs";

const body = this.body as unknown as Body;
//  use `body` wherever needed

Would be great to get a real fix for it!

from melonjs.

obiot avatar obiot commented on May 23, 2024

me too It has been bothering me, but I really don't know how to fix it properly (I mean without renaming the object!)

from melonjs.

obiot avatar obiot commented on May 23, 2024

This one should be fixed now, I just simply "tricked" it by importing Body within the Renderable class (together with referencing the Body class, so that the bundler doesnt complain).

I found out another issue is that rollup does not always respect the right module order in the bundle if I add import/reference for Application. Another issue, but at least the Body one should be resolved now.

I will leave this one open until the next 17.1 version is released and the fix confirmed to work.

from melonjs.

obiot avatar obiot commented on May 23, 2024

17.1.0 released, if you guys could confirm it's now correct from your side as well, thanks !

from melonjs.

obiot avatar obiot commented on May 23, 2024

closing this one, working on my side.

from melonjs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.