microsoft / spatialaudio-unity Goto Github PK

Claims master branch never built, and image for develop branch is not showing for me.

Describe the bug

Output and spectrum data do not exist while running on HoloLens 2.

Sample of how we're using the two methods:

audioSource.GetOutputData(audioSamples, 0);
audioSource.GetSpectrumData(audioSpectrum, 0, FFTWindow.BlackmanHarris);

To reproduce

Steps to reproduce the behavior:

1. Have an AudioSource that's playing looping audio with all spatializer settings enabled.
2. Write a simple script that computes DB, like so: https://answers.unity.com/questions/157940/getoutputdata-and-getspectrumdata-they-represent-t.html
3. Verify this works with MS HRTF Spatializer on HoloLens 2.
4. Swap to Microsoft Spatializer and redeploy.
5. See that the results now on HoloLens 2 are not consistent.

Expected behavior

Behavior should be consistent with MS HRTF Spatializer and what's being seen in the Unity editor.

Your setup

• Unity Version 2019.2.21f1
• Microsoft Spatializer v1.0.0

Target platform

• HoloLens 2
• WMR immersive

Sample project can't be auto-ugraded by Unity to current Unity LTS (2019.4) because MRTK version used in sample project doesn't support Unity 2019.4.

When I try to add the code into unity via package manager and the git link I receive this error

[Package Manager Window] Cannot perform upm operation: Unable to add package [https://github.com/microsoft/spatialaudio-unity.git]:
[https://github.com/microsoft/spatialaudio-unity.git] does not point to a valid package. No package manifest was found. [NotFound].

I'm using Windows 11 and unity 2021.2.19

VS2019 generator, unlike VS2017 and prior, defaults to host architecture rather than Win32 (x86). CMake generator scripts need to change to address this.

Need to add PDBs to the plugin package to help with diagnosability.

In the latest version 2.0.37 the import settings for x86_64 HrtfDsp.dll are not configured correctly - x64 should be checked in Platform settings for standalone builds. At the moment both available options (x86, x64) are unchecked.

CMake project generation needs to take the right flags for UWP configs. Right now UWP plugins fail to load because of non-UWP CRT linkage.

The sample is missing NuGet for Unity binaries, so doesn't load the Nuget packages for MRTK and the spatializer on project start.

Will there be a package update in the near future or is this project dead?

I reported an issue over a year ago and it got closed with the notice that it will be fixed with the next update, but this never happened (#83).

Per Unity's Terms of Service, Microsoft Mixed Reality UPM packages are currently not distributed via scoped registry. Please update the instructions on the readme to reference the Mixed Reality Feature Tool for acqusition.

Download location for MRFT is https://aka.ms/mrfeaturetool
Here is an image of the spatializer in the tool UI

When using the Microsoft Spatializer on desktop, I sometimes want to change my spatial sound mode between Windows Sonic, Dolby Atmos, and DTS. I've seen that once I play any audio in one of these modes, I need to close and reopen Unity to change to another mode. For example:
Have spatial sound mode set to Windows Sonic for Headphones.
Play some spatial audio in Unity. Works!
Change spatial sound mode to Dolby Atmos for Home Theater.
Play some spatial audio in Unity. Doesn't work.
Close Unity.
Open Unity.
Play some spatial audio in Unity. Works!

It would be nice if the Microsoft Spatializer was updated to handle these mode switches automatically without needing to restart Unity.

Latest release on Nuget is v.1.0.36: https://www.nuget.org/packages/Microsoft.SpatialAudio.Spatializer.Unity/
Latest release on Github is v1.0.18: https://github.com/microsoft/spatialaudio-unity/releases

Is Nuget the direction that this project is heading? It would be great if the Unity packages could be kept in lock-step

We publish a Hololens2 Unity app that uses Microsoft audio spatializer. And in the device portal, we receives many reports about application crashes at invalid_pointer_read_c0000005_audiopluginmicrosoftspatializer.dll!unitygetaudioeffectdefinitions. The following is the callstack (not very helpful since it has no symbol)

Any ideas how to resolve the problem?

I think the documentation [here: https://docs.microsoft.com/en-us/windows/mixed-reality/spatial-sound-in-unity] should be updated to include any required dependencies that the user needs to install. I thought this plugin was independent.

Got this error:
Plugins: Failed to load 'Assets/Packages/Microsoft.SpatialAudio.Spatializer.Unity.1.0.0/Plugins/x86_64/AudioPluginMicrosoftSpatializer.dll' because one or more of its dependencies could not be loaded.