Giter VIP home page Giter VIP logo

mgs-bias-manuscript's Introduction

mikemc

mgs-bias-manuscript's People

Contributors

mikemc avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar

mgs-bias-manuscript's Issues

Re-consider use of LazyData and update Rmd's accordingly

Currently, I have LazyData: true in the DESCRIPTION file, which means that the datasets in data/ are available without calling the data() function. If I keep this setting, then I can remove the calls to data() from the Rmd's.

Reduction in compositional error is incorrectly calculated

Calculating the error with adist as in

error <- pred %>%
    group_by(Mixture_type, Bias_type) %>%
    summarize(
        RAdist = sqrt(mean(adist(Observed, Predicted))),
        Adist2 = mean(adist(Observed, Predicted)^2),
(...)
        )

is incorrect, as the Aitchison distance must be calculated within samples and then averaged. This is currently done twice in the Brooks2015 analysis, though the results are not currently used or referenced in the manuscript.

Improve documentation for scripts in data-raw/

Possible ways to improve documentation include adding a README.md to the folder giving the overall purpose and a brief description of each script, and adding a numerical prefix to the scripts for the costea2017 dataset by order in which they need to be run.

Use rrnDB to obtain more robust estimates of 16S copy number

In particular, the estimated CN of 1 for L. iners is suspicious. Should compare the estimates from the refseq genomes to the closest relatives in the rrnDB, and if warranted, use the median of the rrnDB numbers instead of the refseq annotation.

Using the method

Many thanks for providing the tools for using correcting bias in metagenomic sequencing measurements. I still need to fully understood the paper but it is very interesting.

However I couldn't use the method implemented on the paper by calling the package with library. The package only exports some data: "%>%", "brooks2015_counts", "brooks2015_sample_data", "brooks2015_species_info", "costea2017_metaphlan2_profiles", "costea2017_mock_composition", "costea2017_sample_data".
To correct this you need to add the @export tag on each function that you want to make available for the user. I could provide a pull request if you wanted.

Make three-color figures colorblind friendly

Currently the figures make heavy use of ggplot's default colors for a three-level categorical variable---red, green, and blue---making essential variables impossible to distinguish for people who are red/green colorblind. To fix, need to pick new colors for the taxa in Figures 1 and 2, and change the text references to e.g. "the red taxon", and also need to pick new colors to distinguish the three protocols in the shotgun dataset.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.